Mailing List Archive: Linux: Kernel

linux-next: build failure after merge of the final tree (battery tree related)

Index | Next | Previous | View Threaded

sfr at canb

Apr 21, 2011, 3:05 PM

Post #1 of 5 (88 views)
Permalink

linux-next: build failure after merge of the final tree (battery tree related)

Hi Anton,

After merging the final tree, today's linux-next build (s390 allyesconfig)
failed like this:

drivers/built-in.o: In function `max8903_remove':
drivers/power/max8903_charger.c:355: undefined reference to `free_irq'
drivers/power/max8903_charger.c:357: undefined reference to `free_irq'
drivers/power/max8903_charger.c:359: undefined reference to `free_irq'

Caused by commit b14a9ccc1ddd ("power_supply: Add driver for MAX8903
charger"). This driver needs some Kconfig dependency.
--
Cheers,
Stephen Rothwell sfr [at] canb
http://www.canb.auug.org.au/~sfr/

cbouatmailru at gmail

Apr 21, 2011, 4:27 PM

Post #2 of 5 (81 views)
Permalink

Re: linux-next: build failure after merge of the final tree (battery tree related) [In reply to]

Hi Stephen,

On Fri, Apr 22, 2011 at 08:05:55AM +1000, Stephen Rothwell wrote:
> Hi Anton,
>
> After merging the final tree, today's linux-next build (s390 allyesconfig)
> failed like this:
>
> drivers/built-in.o: In function `max8903_remove':
> drivers/power/max8903_charger.c:355: undefined reference to `free_irq'
> drivers/power/max8903_charger.c:357: undefined reference to `free_irq'
> drivers/power/max8903_charger.c:359: undefined reference to `free_irq'

I added the following patch to the battery-2.6.git, so this should be
fixed now. Thanks!

commit 6f9efe76cb213e9b0dd89e465efaf9725f4bf492
Author: Anton Vorontsov <cbouatmailru [at] gmail>
Date: Fri Apr 22 03:08:22 2011 +0400

max8903_charger: Add GENERIC_HARDIRQS as a dependency (fixes S390 build)

S390 is special as it doesn't have IRQ lines, so these errors pop up:

drivers/built-in.o: In function 'max8903_remove':
drivers/power/max8903_charger.c:355: undefined reference to 'free_irq'
drivers/power/max8903_charger.c:357: undefined reference to 'free_irq'
drivers/power/max8903_charger.c:359: undefined reference to 'free_irq'

This commit fixes the issue by making the driver depend on
GENERIC_HARDIRQS feature.

Reported-by: Stephen Rothwell <sfr [at] canb>
Signed-off-by: Anton Vorontsov <cbouatmailru [at] gmail>

diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
index 1f50ebc..cc019c9 100644
--- a/drivers/power/Kconfig
+++ b/drivers/power/Kconfig
@@ -205,6 +205,7 @@ config CHARGER_ISP1704

config CHARGER_MAX8903
tristate "MAX8903 Battery DC-DC Charger for USB and Adapter Power"
+ depends on GENERIC_HARDIRQS
help
Say Y to enable support for the MAX8903 DC-DC charger and sysfs.
The driver supports controlling charger-enable and current-limit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

mika.westerberg at linux

May 7, 2012, 1:26 AM

Post #3 of 5 (51 views)
Permalink

Re: linux-next: build failure after merge of the final tree (battery tree related) [In reply to]

On Mon, May 07, 2012 at 05:14:58PM +1000, Stephen Rothwell wrote:
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/power/smb347-charger.c: In function 'smb347_probe':
> drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
>
> Caused by commit 34298d40e585 ("smb347-charger: Convert to regmap API").

I'm unable to reproduce this on x86 build. I guess <linux/err.h> gets
included implicitly there.

Patch below should fix this. Anton, care to pick this one as well (or fold
it into the 34298d40e585 ("smb347-charger: Convert to regmap API") commit)?

From: Mika Westerberg <mika.westerberg [at] linux>
Subject: [PATCH] smb347-charger: include missing <linux/err.h>

Without the include we get build errors like:

drivers/power/smb347-charger.c: In function 'smb347_probe':
drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]

Reported-by: Stephen Rothwell <sfr [at] canb>
Signed-off-by: Mika Westerberg <mika.westerberg [at] linux>
---
drivers/power/smb347-charger.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c
index 09d19d2..f8eedd8 100644
--- a/drivers/power/smb347-charger.c
+++ b/drivers/power/smb347-charger.c
@@ -11,6 +11,7 @@
* published by the Free Software Foundation.
*/

+#include <linux/err.h>
#include <linux/gpio.h>
#include <linux/kernel.h>
#include <linux/module.h>
--
1.7.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

sfr at canb

May 15, 2012, 11:12 PM

Post #4 of 5 (50 views)
Permalink

Re: linux-next: build failure after merge of the final tree (battery tree related) [In reply to]

Hi all,

On Mon, 7 May 2012 11:26:37 +0300 Mika Westerberg <mika.westerberg [at] linux> wrote:
>
> On Mon, May 07, 2012 at 05:14:58PM +1000, Stephen Rothwell wrote:
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/power/smb347-charger.c: In function 'smb347_probe':
> > drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> > drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
> >
> > Caused by commit 34298d40e585 ("smb347-charger: Convert to regmap API").
>
> I'm unable to reproduce this on x86 build. I guess <linux/err.h> gets
> included implicitly there.
>
> Patch below should fix this. Anton, care to pick this one as well (or fold
> it into the 34298d40e585 ("smb347-charger: Convert to regmap API") commit)?
>
> From: Mika Westerberg <mika.westerberg [at] linux>
> Subject: [PATCH] smb347-charger: include missing <linux/err.h>
>
> Without the include we get build errors like:
>
> drivers/power/smb347-charger.c: In function 'smb347_probe':
> drivers/power/smb347-charger.c:1039:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> drivers/power/smb347-charger.c:1040:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
>
> Reported-by: Stephen Rothwell <sfr [at] canb>
> Signed-off-by: Mika Westerberg <mika.westerberg [at] linux>
> ---
> drivers/power/smb347-charger.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c
> index 09d19d2..f8eedd8 100644
> --- a/drivers/power/smb347-charger.c
> +++ b/drivers/power/smb347-charger.c
> @@ -11,6 +11,7 @@
> * published by the Free Software Foundation.
> */
>
> +#include <linux/err.h>
> #include <linux/gpio.h>
> #include <linux/kernel.h>
> #include <linux/module.h>

Ping?
--
Cheers,
Stephen Rothwell sfr [at] canb

cbouatmailru at gmail

May 18, 2012, 5:16 PM

Post #5 of 5 (54 views)
Permalink

Re: linux-next: build failure after merge of the final tree (battery tree related) [In reply to]

On Wed, May 16, 2012 at 04:12:56PM +1000, Stephen Rothwell wrote:
[...]
> > diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c
> > index 09d19d2..f8eedd8 100644
> > --- a/drivers/power/smb347-charger.c
> > +++ b/drivers/power/smb347-charger.c
> > @@ -11,6 +11,7 @@
> > * published by the Free Software Foundation.
> > */
> >
> > +#include <linux/err.h>
> > #include <linux/gpio.h>
> > #include <linux/kernel.h>
> > #include <linux/module.h>
>
> Ping?

Applied, thank you!

--
Anton Vorontsov
Email: cbouatmailru [at] gmail
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads