Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH] param: don't complain about unused module parameters.

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


rusty at rustcorp

Nov 30, 2009, 8:26 PM

Post #1 of 3 (110 views)
Permalink
[PATCH] param: don't complain about unused module parameters.

Jon confirms that recent modprobe will look in /proc/cmdline, so these
cmdline options can still be used.

See http://bugzilla.kernel.org/show_bug.cgi?id=14164

Reported-by: Adam Williamson <awilliam [at] redhat>
Cc: stable [at] kernel
Signed-off-by: Rusty Russell <rusty [at] rustcorp>
---
init/main.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/init/main.c b/init/main.c
--- a/init/main.c
+++ b/init/main.c
@@ -251,7 +251,7 @@ early_param("loglevel", loglevel);

/*
* Unknown boot options get handed to init, unless they look like
- * failed parameters
+ * unused parameters (modprobe will find them in /proc/cmdline).
*/
static int __init unknown_bootoption(char *param, char *val)
{
@@ -272,14 +272,9 @@ static int __init unknown_bootoption(cha
if (obsolete_checksetup(param))
return 0;

- /*
- * Preemptive maintenance for "why didn't my misspelled command
- * line work?"
- */
- if (strchr(param, '.') && (!val || strchr(param, '.') < val)) {
- printk(KERN_ERR "Unknown boot option `%s': ignoring\n", param);
+ /* Unused module parameter. */
+ if (strchr(param, '.') && (!val || strchr(param, '.') < val))
return 0;
- }

if (panic_later)
return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


jonathan at jonmasters

Nov 30, 2009, 11:11 PM

Post #2 of 3 (105 views)
Permalink
Re: [PATCH] param: don't complain about unused module parameters. [In reply to]

On Tue, 2009-12-01 at 14:56 +1030, Rusty Russell wrote:
> Jon confirms that recent modprobe will look in /proc/cmdline, so these
> cmdline options can still be used.

Yup. Thanks for that.

Jon.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


awilliam at redhat

Nov 30, 2009, 11:42 PM

Post #3 of 3 (105 views)
Permalink
Re: [PATCH] param: don't complain about unused module parameters. [In reply to]

On Tue, 2009-12-01 at 14:56 +1030, Rusty Russell wrote:
> Jon confirms that recent modprobe will look in /proc/cmdline, so these
> cmdline options can still be used.
>
> See http://bugzilla.kernel.org/show_bug.cgi?id=14164

Thanks for the fix, Rusty. This'll save a lot of confusion :)

--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Fedora Talk: adamwill AT fedoraproject DOT org
http://www.happyassassin.net

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.