Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH 1/2] EDAC: add __init to i7core_xeon_pci_fixup

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


jslaby at suse

Nov 30, 2009, 12:19 PM

Post #1 of 4 (164 views)
Permalink
[PATCH 1/2] EDAC: add __init to i7core_xeon_pci_fixup

It's called only from an __init function and is the only user
of pcibios_scan_specific_bus which will be marked as __devinit in
the next patch.

Signed-off-by: Jiri Slaby <jslaby [at] suse>
Cc: Mauro Carvalho Chehab <mchehab [at] redhat>
---
drivers/edac/i7core_edac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
index 4de5a18..c7fc0d5 100644
--- a/drivers/edac/i7core_edac.c
+++ b/drivers/edac/i7core_edac.c
@@ -1141,7 +1141,7 @@ static void i7core_put_all_devices(void)
i7core_put_devices(i7core_dev);
}

-static void i7core_xeon_pci_fixup(int dev_id)
+static void __init i7core_xeon_pci_fixup(int dev_id)
{
struct pci_dev *pdev = NULL;
int i;
--
1.6.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


jbarnes at virtuousgeek

Dec 4, 2009, 3:54 PM

Post #2 of 4 (151 views)
Permalink
Re: [PATCH 1/2] EDAC: add __init to i7core_xeon_pci_fixup [In reply to]

On Mon, 30 Nov 2009 21:19:41 +0100
Jiri Slaby <jslaby [at] suse> wrote:

> It's called only from an __init function and is the only user
> of pcibios_scan_specific_bus which will be marked as __devinit in
> the next patch.
>
> Signed-off-by: Jiri Slaby <jslaby [at] suse>
> Cc: Mauro Carvalho Chehab <mchehab [at] redhat>
> ---
> drivers/edac/i7core_edac.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
> index 4de5a18..c7fc0d5 100644
> --- a/drivers/edac/i7core_edac.c
> +++ b/drivers/edac/i7core_edac.c
> @@ -1141,7 +1141,7 @@ static void i7core_put_all_devices(void)
> i7core_put_devices(i7core_dev);
> }
>
> -static void i7core_xeon_pci_fixup(int dev_id)
> +static void __init i7core_xeon_pci_fixup(int dev_id)
> {
> struct pci_dev *pdev = NULL;
> int i;

I don't know who handles EDAC patches, but I'm pretty sure it's not
me. :) It doesn't apply to my tree anyway, so it probably needs a
refresh.

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


jslaby at suse

Dec 5, 2009, 5:55 AM

Post #3 of 4 (147 views)
Permalink
Re: [PATCH 1/2] EDAC: add __init to i7core_xeon_pci_fixup [In reply to]

On 12/05/2009 12:54 AM, Jesse Barnes wrote:
> On Mon, 30 Nov 2009 21:19:41 +0100
> Jiri Slaby <jslaby [at] suse> wrote:
>
>> It's called only from an __init function and is the only user
>> of pcibios_scan_specific_bus which will be marked as __devinit in
>> the next patch.
>>
>> Signed-off-by: Jiri Slaby <jslaby [at] suse>
>> Cc: Mauro Carvalho Chehab <mchehab [at] redhat>
>> ---
>> drivers/edac/i7core_edac.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
>> index 4de5a18..c7fc0d5 100644
>> --- a/drivers/edac/i7core_edac.c
>> +++ b/drivers/edac/i7core_edac.c
>> @@ -1141,7 +1141,7 @@ static void i7core_put_all_devices(void)
>> i7core_put_devices(i7core_dev);
>> }
>>
>> -static void i7core_xeon_pci_fixup(int dev_id)
>> +static void __init i7core_xeon_pci_fixup(int dev_id)
>> {
>> struct pci_dev *pdev = NULL;
>> int i;
>
> I don't know who handles EDAC patches, but I'm pretty sure it's not
> me. :)

Yeah, sorry, it was just I wanted you to know about the function user.
The EDAC masters were in CC, I hope.

> It doesn't apply to my tree anyway, so it probably needs a
> refresh.

I'll resend both patches after rebasing them.

thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


norsk5 at yahoo

Dec 7, 2009, 4:44 PM

Post #4 of 4 (137 views)
Permalink
Re: [PATCH 1/2] EDAC: add __init to i7core_xeon_pci_fixup [In reply to]

--- On Fri, 12/4/09, Jesse Barnes <jbarnes [at] virtuousgeek> wrote:

> From: Jesse Barnes <jbarnes [at] virtuousgeek>
> Subject: Re: [PATCH 1/2] EDAC: add __init to i7core_xeon_pci_fixup
> To: "Jiri Slaby" <jslaby [at] suse>
> Cc: jirislaby [at] gmail, linux-kernel [at] vger, "Mauro Carvalho Chehab" <mchehab [at] redhat>
> Date: Friday, December 4, 2009, 4:54 PM
> On Mon, 30 Nov 2009 21:19:41 +0100
> Jiri Slaby <jslaby [at] suse>
> wrote:
>
> > It's called only from an __init function and is the
> only user
> > of pcibios_scan_specific_bus which will be marked as
> __devinit in
> > the next patch.
> >
> > Signed-off-by: Jiri Slaby <jslaby [at] suse>
> > Cc: Mauro Carvalho Chehab <mchehab [at] redhat>
> > ---
> >  drivers/edac/i7core_edac.c |    2 +-
> >  1 files changed, 1 insertions(+), 1
> deletions(-)
> >
> > diff --git a/drivers/edac/i7core_edac.c
> b/drivers/edac/i7core_edac.c
> > index 4de5a18..c7fc0d5 100644
> > --- a/drivers/edac/i7core_edac.c
> > +++ b/drivers/edac/i7core_edac.c
> > @@ -1141,7 +1141,7 @@ static void
> i7core_put_all_devices(void)
> >         
> i7core_put_devices(i7core_dev);
> >  }
> > 
> > -static void i7core_xeon_pci_fixup(int dev_id)
> > +static void __init i7core_xeon_pci_fixup(int dev_id)
> >  {
> >      struct pci_dev *pdev = NULL;
> >      int i;
>
> I don't know who handles EDAC patches, but I'm pretty sure
> it's not
> me. :) 

Maruo has the i7core tree that he is building on for i7 stuff
boris from AMD has the amd64 tree
I handle the others and send to Andrew Morton

doug thompson


> It doesn't apply to my tree anyway, so it
> probably needs a
> refresh.
>
> Thanks,
> --
> Jesse Barnes, Intel Open Source Technology Center
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo [at] vger
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.