Mailing List Archive: Linux: Kernel

[PATCH] pata_hpt3x2n: fix overclocked MWDMA0 timing

Index | Next | Previous | View Threaded

bzolnier at gmail

Nov 27, 2009, 10:56 AM

Post #1 of 5 (163 views)
Permalink

[PATCH] pata_hpt3x2n: fix overclocked MWDMA0 timing

Remove superfluous timings table entry while at it.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
---
Sergei, XFER_UDMA_5 timing also looks suspicious,
please take a look when you have a minute, thanks.

drivers/ata/pata_hpt3x2n.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Index: b/drivers/ata/pata_hpt3x2n.c
===================================================================
--- a/drivers/ata/pata_hpt3x2n.c
+++ b/drivers/ata/pata_hpt3x2n.c
@@ -80,14 +80,13 @@ static struct hpt_clock hpt3x2n_clocks[]

{ XFER_MW_DMA_2, 0x2c829c62 },
{ XFER_MW_DMA_1, 0x2c829c66 },
- { XFER_MW_DMA_0, 0x2c829d2c },
+ { XFER_MW_DMA_0, 0x2c829d2e },

{ XFER_PIO_4, 0x0c829c62 },
{ XFER_PIO_3, 0x0c829c84 },
{ XFER_PIO_2, 0x0c829ca6 },
{ XFER_PIO_1, 0x0d029d26 },
{ XFER_PIO_0, 0x0d029d5e },
- { 0, 0x0d029d5e }
};

/**
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

sshtylyov at ru

Nov 27, 2009, 11:41 AM

Post #2 of 5 (145 views)
Permalink

Re: [PATCH] pata_hpt3x2n: fix overclocked MWDMA0 timing [In reply to]

Bartlomiej Zolnierkiewicz wrote:

> Remove superfluous timings table entry while at it.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
> ---
> Sergei, XFER_UDMA_5 timing also looks suspicious,
> please take a look when you have a minute, thanks.

Yeah, but it's the same as XFER_UDMA_4, so actually underclocked...
However, it matches what the HPT371N datasheet and the vendor drivers have.
The 'hpt366' driver uses more speedy mode, with 22.5 ns cycle. ;-)

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

sshtylyov at ru

Nov 27, 2009, 11:47 AM

Post #3 of 5 (146 views)
Permalink

Re: [PATCH] pata_hpt3x2n: fix overclocked MWDMA0 timing [In reply to]

Hello, I wrote:

>> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
>> ---
>> Sergei, XFER_UDMA_5 timing also looks suspicious,
>> please take a look when you have a minute, thanks.

> Yeah, but it's the same as XFER_UDMA_4, so actually underclocked...
> However, it matches what the HPT371N datasheet and the vendor drivers
> have. The 'hpt366' driver uses more speedy mode, with 22.5 ns cycle. ;-)

I have just verified: this driver has always used this timing
historically, at least for HPT372+ chips.

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

jeff at garzik

Dec 3, 2009, 12:56 PM

Post #4 of 5 (118 views)
Permalink

Re: [PATCH] pata_hpt3x2n: fix overclocked MWDMA0 timing [In reply to]

On 11/27/2009 02:47 PM, Sergei Shtylyov wrote:
> Hello, I wrote:
>
>>> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
>>> ---
>>> Sergei, XFER_UDMA_5 timing also looks suspicious,
>>> please take a look when you have a minute, thanks.
>
>> Yeah, but it's the same as XFER_UDMA_4, so actually underclocked...
>> However, it matches what the HPT371N datasheet and the vendor drivers
>> have. The 'hpt366' driver uses more speedy mode, with 22.5 ns cycle. ;-)
>
> I have just verified: this driver has always used this timing
> historically, at least for HPT372+ chips.

Could you clarify which "this timing" you are referring to? :) I never
saw an Acked-by on this one.

Jeff

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

sshtylyov at ru

Dec 3, 2009, 1:51 PM

Post #5 of 5 (119 views)
Permalink

Re: [PATCH] pata_hpt3x2n: fix overclocked MWDMA0 timing [In reply to]

Hello.

Jeff Garzik wrote:

>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
>>>> ---
>>>> Sergei, XFER_UDMA_5 timing also looks suspicious,
>>>> please take a look when you have a minute, thanks.
>>
>>> Yeah, but it's the same as XFER_UDMA_4, so actually underclocked...
>>> However, it matches what the HPT371N datasheet and the vendor drivers
>>> have. The 'hpt366' driver uses more speedy mode, with 22.5 ns cycle.
>>> ;-)
>>
>> I have just verified: this driver has always used this timing
>> historically, at least for HPT372+ chips.
>
> Could you clarify which "this timing" you are referring to? :)

UDMA5 timing which looked suspicious to Bart: 'hpt366' driver uses
faster timing at 66 MHz clock than the vendor drivers and HPT371N
datasheet have (they have it the same as UDMA4).

> I never saw an Acked-by on this one.

I usually don't ACK libata patches, but this one can be an exception:

Acked-by: Sergei Shtylyov <sshtylyov [at] ru>

Though I guess you're waiting for Alan's ACK... :-)

> Jeff

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads