Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH 03/86] pata_artop: add 32-bit PIO support

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


bzolnier at gmail

Nov 25, 2009, 9:02 AM

Post #1 of 4 (63 views)
Permalink
[PATCH 03/86] pata_artop: add 32-bit PIO support

From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
Subject: [PATCH] pata_artop: add 32-bit PIO support

There shouldn't be any problems with it as IDE aec62xx host driver
has been allowing 32-bit PIO operations for years.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
---
drivers/ata/pata_artop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: b/drivers/ata/pata_artop.c
===================================================================
--- a/drivers/ata/pata_artop.c
+++ b/drivers/ata/pata_artop.c
@@ -312,7 +312,7 @@ static struct scsi_host_template artop_s
};

static struct ata_port_operations artop6210_ops = {
- .inherits = &ata_bmdma_port_ops,
+ .inherits = &ata_bmdma32_port_ops,
.cable_detect = ata_cable_40wire,
.set_piomode = artop6210_set_piomode,
.set_dmamode = artop6210_set_dmamode,
@@ -321,7 +321,7 @@ static struct ata_port_operations artop6
};

static struct ata_port_operations artop6260_ops = {
- .inherits = &ata_bmdma_port_ops,
+ .inherits = &ata_bmdma32_port_ops,
.cable_detect = artop6260_cable_detect,
.set_piomode = artop6260_set_piomode,
.set_dmamode = artop6260_set_dmamode,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


alan at lxorguk

Nov 25, 2009, 9:12 AM

Post #2 of 4 (64 views)
Permalink
Re: [PATCH 03/86] pata_artop: add 32-bit PIO support [In reply to]

On Wed, 25 Nov 2009 18:02:39 +0100
Bartlomiej Zolnierkiewicz <bzolnier [at] gmail> wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
> Subject: [PATCH] pata_artop: add 32-bit PIO support
>
> There shouldn't be any problems with it as IDE aec62xx host driver
> has been allowing 32-bit PIO operations for years.

Allowing or defaulting too ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


bzolnier at gmail

Nov 25, 2009, 9:18 AM

Post #3 of 4 (62 views)
Permalink
Re: [PATCH 03/86] pata_artop: add 32-bit PIO support [In reply to]

On Wednesday 25 November 2009 06:12:42 pm Alan Cox wrote:
> On Wed, 25 Nov 2009 18:02:39 +0100
> Bartlomiej Zolnierkiewicz <bzolnier [at] gmail> wrote:
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
> > Subject: [PATCH] pata_artop: add 32-bit PIO support
> >
> > There shouldn't be any problems with it as IDE aec62xx host driver
> > has been allowing 32-bit PIO operations for years.
>
> Allowing or defaulting too ?

For aec62xx: allowing, for some other drivers: defaulting ('using'
in the patch description instead of 'allowing'). However some
popular distributions have been defaulting to always enabling it
if was supported by the driver.

--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


alan at lxorguk

Nov 25, 2009, 9:59 AM

Post #4 of 4 (63 views)
Permalink
Re: [PATCH 03/86] pata_artop: add 32-bit PIO support [In reply to]

On Wed, 25 Nov 2009 18:18:18 +0100
Bartlomiej Zolnierkiewicz <bzolnier [at] gmail> wrote:

> On Wednesday 25 November 2009 06:12:42 pm Alan Cox wrote:
> > On Wed, 25 Nov 2009 18:02:39 +0100
> > Bartlomiej Zolnierkiewicz <bzolnier [at] gmail> wrote:
> >
> > > From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
> > > Subject: [PATCH] pata_artop: add 32-bit PIO support
> > >
> > > There shouldn't be any problems with it as IDE aec62xx host driver
> > > has been allowing 32-bit PIO operations for years.
> >
> > Allowing or defaulting too ?
>
> For aec62xx: allowing, for some other drivers: defaulting ('using'
> in the patch description instead of 'allowing'). However some
> popular distributions have been defaulting to always enabling it
> if was supported by the driver.

I wonder what their coverage of old devices is like though and what they
enabled. No problem with those that defaulted, would be nice to get the
rest tested more systematically
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.