Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH 69/86] pata_scc: add 32-bit PIO support

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


bzolnier at gmail

Nov 25, 2009, 9:10 AM

Post #1 of 3 (64 views)
Permalink
[PATCH 69/86] pata_scc: add 32-bit PIO support

From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
Subject: [PATCH] pata_scc: add 32-bit PIO support

There shouldn't be any problems with it as IDE scc_pata host driver
has been allowing 32-bit PIO operations for years.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
---
drivers/ata/pata_scc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/ata/pata_scc.c
===================================================================
--- a/drivers/ata/pata_scc.c
+++ b/drivers/ata/pata_scc.c
@@ -966,7 +966,7 @@ static struct scsi_host_template scc_sht
};

static struct ata_port_operations scc_pata_ops = {
- .inherits = &ata_bmdma_port_ops,
+ .inherits = &ata_bmdma32_port_ops,

.set_piomode = scc_set_piomode,
.set_dmamode = scc_set_dmamode,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


alan at lxorguk

Nov 25, 2009, 9:48 AM

Post #2 of 3 (62 views)
Permalink
Re: [PATCH 69/86] pata_scc: add 32-bit PIO support [In reply to]

On Wed, 25 Nov 2009 18:10:39 +0100
Bartlomiej Zolnierkiewicz <bzolnier [at] gmail> wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
> Subject: [PATCH] pata_scc: add 32-bit PIO support
>
> There shouldn't be any problems with it as IDE scc_pata host driver
> has been allowing 32-bit PIO operations for years.

NAK; Read the code - it uses its own private data_xfer handler anyway
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


bzolnier at gmail

Nov 25, 2009, 9:49 AM

Post #3 of 3 (64 views)
Permalink
Re: [PATCH 69/86] pata_scc: add 32-bit PIO support [In reply to]

On Wednesday 25 November 2009 06:48:44 pm Alan Cox wrote:
> On Wed, 25 Nov 2009 18:10:39 +0100
> Bartlomiej Zolnierkiewicz <bzolnier [at] gmail> wrote:
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
> > Subject: [PATCH] pata_scc: add 32-bit PIO support
> >
> > There shouldn't be any problems with it as IDE scc_pata host driver
> > has been allowing 32-bit PIO operations for years.
>
> NAK; Read the code - it uses its own private data_xfer handler anyway

Ah, this one can be indeed dropped.

--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.