Mailing List Archive: Linux: Kernel

[PATCH 19/86] pata_cmd640: document known issues

Index | Next | Previous | View Threaded

bzolnier at gmail

Nov 25, 2009, 9:04 AM

Post #1 of 6 (81 views)
Permalink

[PATCH 19/86] pata_cmd640: document known issues

From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
Subject: [PATCH] pata_cmd640: document known issues

Document known issues with the driver to aid distribution makers,
users and developers in making informed decisions instead of wasting
their time needlessly.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
---
drivers/ata/Kconfig | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Index: b/drivers/ata/Kconfig
===================================================================
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -287,8 +287,11 @@ config PATA_CMD640_PCI
depends on PCI && EXPERIMENTAL
help
This option enables support for the CMD640 PCI IDE
- interface chip. Only the primary channel is currently
- supported.
+ interface chip.
+
+ Known issues:
+ - only the primary channel is currently supported
+ - only the PCI chip interface is currently supported

If unsure, say N.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

alan at lxorguk

Nov 25, 2009, 9:26 AM

Post #2 of 6 (83 views)
Permalink

Re: [PATCH 19/86] pata_cmd640: document known issues [In reply to]

On Wed, 25 Nov 2009 18:04:36 +0100
Bartlomiej Zolnierkiewicz <bzolnier [at] gmail> wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
> Subject: [PATCH] pata_cmd640: document known issues
>
> Document known issues with the driver to aid distribution makers,
> users and developers in making informed decisions instead of wasting
> their time needlessly.

Umm. its a) under CONFIG_PCI, and b) says CMD640 PCI IDE...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

bzolnier at gmail

Nov 25, 2009, 9:34 AM

Post #3 of 6 (84 views)
Permalink

Re: [PATCH 19/86] pata_cmd640: document known issues [In reply to]

On Wednesday 25 November 2009 06:26:33 pm Alan Cox wrote:
> On Wed, 25 Nov 2009 18:04:36 +0100
> Bartlomiej Zolnierkiewicz <bzolnier [at] gmail> wrote:
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
> > Subject: [PATCH] pata_cmd640: document known issues
> >
> > Document known issues with the driver to aid distribution makers,
> > users and developers in making informed decisions instead of wasting
> > their time needlessly.
>
> Umm. its a) under CONFIG_PCI, and b) says CMD640 PCI IDE...

c)

* This drives only the PCI version of the controller. If you have a
* VLB one then we have enough docs to support it but you can write
* your own code.

Then what has happened to CMD640 VLB IDE support in libata?

--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

jeff at garzik

Nov 25, 2009, 9:37 AM

Post #4 of 6 (84 views)
Permalink

Re: [PATCH 19/86] pata_cmd640: document known issues [In reply to]

On 11/25/2009 12:26 PM, Alan Cox wrote:
> On Wed, 25 Nov 2009 18:04:36 +0100
> Bartlomiej Zolnierkiewicz<bzolnier [at] gmail> wrote:
>
>> From: Bartlomiej Zolnierkiewicz<bzolnier [at] gmail>
>> Subject: [PATCH] pata_cmd640: document known issues
>>
>> Document known issues with the driver to aid distribution makers,
>> users and developers in making informed decisions instead of wasting
>> their time needlessly.
>
> Umm. its a) under CONFIG_PCI, and b) says CMD640 PCI IDE...

Agreed, that's a bit redundant.

Also, as I noted in another email, known issues should be listed in the
driver source code at the top of the file, not in Kconfig.

That way the list of known issues actually follows the implementation,
as the source code is copied around various kernel trees.

Jeff

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

bzolnier at gmail

Nov 25, 2009, 9:44 AM

Post #5 of 6 (86 views)
Permalink

Re: [PATCH 19/86] pata_cmd640: document known issues [In reply to]

On Wednesday 25 November 2009 06:37:19 pm Jeff Garzik wrote:
> On 11/25/2009 12:26 PM, Alan Cox wrote:
> > On Wed, 25 Nov 2009 18:04:36 +0100
> > Bartlomiej Zolnierkiewicz<bzolnier [at] gmail> wrote:
> >
> >> From: Bartlomiej Zolnierkiewicz<bzolnier [at] gmail>
> >> Subject: [PATCH] pata_cmd640: document known issues
> >>
> >> Document known issues with the driver to aid distribution makers,
> >> users and developers in making informed decisions instead of wasting
> >> their time needlessly.
> >
> > Umm. its a) under CONFIG_PCI, and b) says CMD640 PCI IDE...
>
> Agreed, that's a bit redundant.
>
> Also, as I noted in another email, known issues should be listed in the
> driver source code at the top of the file, not in Kconfig.

Agreed, since virtually everybody should be looking into source
code of each single driver before compiling kernel and/or deciding
to include it into distribution kernel.

--
Bartlomiej Zolnierkiewicz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

alan at lxorguk

Nov 25, 2009, 10:14 AM

Post #6 of 6 (81 views)
Permalink

Re: [PATCH 19/86] pata_cmd640: document known issues [In reply to]

On Wed, 25 Nov 2009 18:34:04 +0100
Bartlomiej Zolnierkiewicz <bzolnier [at] gmail> wrote:

> On Wednesday 25 November 2009 06:26:33 pm Alan Cox wrote:
> > On Wed, 25 Nov 2009 18:04:36 +0100
> > Bartlomiej Zolnierkiewicz <bzolnier [at] gmail> wrote:
> >
> > > From: Bartlomiej Zolnierkiewicz <bzolnier [at] gmail>
> > > Subject: [PATCH] pata_cmd640: document known issues
> > >
> > > Document known issues with the driver to aid distribution makers,
> > > users and developers in making informed decisions instead of wasting
> > > their time needlessly.
> >
> > Umm. its a) under CONFIG_PCI, and b) says CMD640 PCI IDE...
>
> c)
>
> * This drives only the PCI version of the controller. If you have a
> * VLB one then we have enough docs to support it but you can write
> * your own code.
>
> Then what has happened to CMD640 VLB IDE support in libata?

There is none. Nobody has complained about that either, and in fact I've
not even been able to find a board on ebay to test either driver with
VLB !
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads