Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


u.kleine-koenig at pengutronix

Nov 24, 2009, 1:07 PM

Post #1 of 2 (29 views)
Permalink
[PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p

The function mlx4_remove_one is defined in .text, so there is no need to
wrap it with __devexit_p.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig [at] pengutronix>
Cc: Roland Dreier <rolandd [at] cisco>
Cc: Yevgeny Petrilin <yevgenyp [at] mellanox>
Cc: Yang Hongyang <yanghy [at] cn>
Cc: Jack Morgenstein <jackm [at] dev>
Cc: Eli Cohen <eli [at] mellanox>
Cc: linux-kernel [at] vger
Cc: Andrew Morton <akpm [at] linux-foundation>
Cc: netdev [at] vger
---
drivers/net/mlx4/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
index 291a505..a581860 100644
--- a/drivers/net/mlx4/main.c
+++ b/drivers/net/mlx4/main.c
@@ -1293,7 +1293,7 @@ static struct pci_driver mlx4_driver = {
.name = DRV_NAME,
.id_table = mlx4_pci_table,
.probe = mlx4_init_one,
- .remove = __devexit_p(mlx4_remove_one)
+ .remove = mlx4_remove_one
};

static int __init mlx4_verify_params(void)
--
1.6.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


franco at lastsummer

Nov 25, 2009, 1:19 AM

Post #2 of 2 (26 views)
Permalink
Re: [PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p [In reply to]

Uwe Kleine-König wrote:
> diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
> index 291a505..a581860 100644
> --- a/drivers/net/mlx4/main.c
> +++ b/drivers/net/mlx4/main.c
> @@ -1293,7 +1293,7 @@ static struct pci_driver mlx4_driver = {
> .name = DRV_NAME,
> .id_table = mlx4_pci_table,
> .probe = mlx4_init_one,
> - .remove = __devexit_p(mlx4_remove_one)
> + .remove = mlx4_remove_one
>
You may want to add the trailing comma while you're at it...

> };
>
> static int __init mlx4_verify_params(void)
>

f
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.