Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCHSET 0-5] remove unneeded nfsd #includes

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


bharrosh at panasas

Nov 24, 2009, 9:58 AM

Post #1 of 4 (106 views)
Permalink
[PATCHSET 0-5] remove unneeded nfsd #includes

Some arch files had unneeded #includes directives from linux/nfsd/*.
Some vfs files had unneeded #includes directives from linux/nfsd/*.

In an effort to move some of the now public nfsd headers to the source
directory, submitted a cleanup.

I have cross compiled sparc64 and s390, parsic needs testing. Please ARCH
people sends ACKs, or take these patches through your trees.

patches:
[PATCH 1/5] parsic: remove unused nfsd #includes
Some kind soul, please compile with this patch? compile
is all that's needed.

[PATCH 2/5] sparc: remove unused nfsd #includes
[PATCH 3/5] s390: remove unused nfsd #includes
These two were cross compiled. Should we submit them through
nfsd tree or the ARCH trees?

[PATCH 4/5] vfs: nfsctl.c unused nfsd #includes
[PATCH 5/5] lockd: Remove unused nfsd headers #includes
Can these patches go through the nfsd tree?
Who's ACKs should we collect? Andrew?

Bruce Hi
With this set applied, the only nfsd files used publicly are:
const.h export.h nfsfh.h stats.h syscall.h

These files can be moved to source folder:
cache.h debug.h nfsd.h state.h xdr3.h xdr4.h xdr.h

Why is debug.h exported from Kernel? (include/linux/nfsd/Kbuild)

So just to see how this move might look like see last patch:
[RFC] nfsd: Move private headers to source directory
This patch was compiled, as well, on x86(32/64), sparc64, s390

Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


grundler at parisc-linux

Nov 24, 2009, 1:27 PM

Post #2 of 4 (100 views)
Permalink
Re: [PATCHSET 0-5] remove unneeded nfsd #includes [In reply to]

On Tue, Nov 24, 2009 at 07:58:15PM +0200, Boaz Harrosh wrote:
> Some arch files had unneeded #includes directives from linux/nfsd/*.
> Some vfs files had unneeded #includes directives from linux/nfsd/*.
...
> patches:
> [PATCH 1/5] parsic: remove unused nfsd #includes
> Some kind soul, please compile with this patch? compile
> is all that's needed.

Boaz,
linux-2.6 compiles for parisc with this patch. Please add:
Tested-by: Grant Grundler <grundler [at] parisc-linux>

thanks,
grant

>
> [PATCH 2/5] sparc: remove unused nfsd #includes
> [PATCH 3/5] s390: remove unused nfsd #includes
> These two were cross compiled. Should we submit them through
> nfsd tree or the ARCH trees?
>
> [PATCH 4/5] vfs: nfsctl.c unused nfsd #includes
> [PATCH 5/5] lockd: Remove unused nfsd headers #includes
> Can these patches go through the nfsd tree?
> Who's ACKs should we collect? Andrew?
>
> Bruce Hi
> With this set applied, the only nfsd files used publicly are:
> const.h export.h nfsfh.h stats.h syscall.h
>
> These files can be moved to source folder:
> cache.h debug.h nfsd.h state.h xdr3.h xdr4.h xdr.h
>
> Why is debug.h exported from Kernel? (include/linux/nfsd/Kbuild)
>
> So just to see how this move might look like see last patch:
> [RFC] nfsd: Move private headers to source directory
> This patch was compiled, as well, on x86(32/64), sparc64, s390
>
> Thanks
> Boaz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo [at] vger
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


bfields at citi

Nov 24, 2009, 3:08 PM

Post #3 of 4 (100 views)
Permalink
Re: [PATCHSET 0-5] remove unneeded nfsd #includes [In reply to]

On Tue, Nov 24, 2009 at 07:58:15PM +0200, Boaz Harrosh wrote:
> Why is debug.h exported from Kernel? (include/linux/nfsd/Kbuild)

I suppose it's so rpcdebug can get the rpc debug flags; see e.g.
nfs-utils/tools/rpcdebug/rpcdebug.c.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


bharrosh at panasas

Nov 25, 2009, 12:42 AM

Post #4 of 4 (102 views)
Permalink
Re: [PATCHSET 0-5] remove unneeded nfsd #includes [In reply to]

On 11/25/2009 01:08 AM, J. Bruce Fields wrote:
> On Tue, Nov 24, 2009 at 07:58:15PM +0200, Boaz Harrosh wrote:
>> Why is debug.h exported from Kernel? (include/linux/nfsd/Kbuild)
>
> I suppose it's so rpcdebug can get the rpc debug flags; see e.g.
> nfs-utils/tools/rpcdebug/rpcdebug.c.
>

OK, thanks, so I didn't touch it

> --b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.