monstr at monstr
Nov 24, 2009, 1:07 AM
Post #2 of 2
(83 views)
Permalink
|
|
Re: Add UPF_FIXED_TYPE flag - eedacbf02df462d6c915d8d642b23fb450d485c7
[In reply to]
|
|
Hi,
I found where the problem was. We have uart16550a compatible device not
only uart16550.
I will send patch for extension of compatible list.
Regards,
Michal
Michal Simek wrote:
> Hi Ben and David,
>
> I have found one problem with input overrun. My problem is of course on
> Microblaze with uart16550.
>
> Here is the behavior - I just pressed left arrow.
>
> ~ # fdasfdakjsdhfkajsdhfkjadklasdjfhajksdhfkahsdfjkahsdkjfhjkattyS0: 3
> input overrun(s)
> [[DttyS0: 3 input overrun(s)
> [[[[[DDDahsdk[[[[D[DDjfhjka[D [[[DttyS0: 6 input
> overrun(s)jk[[D[D[[D[[
> [[[[D[Dsd[[Dhfkah[[[[DD[[DDsdfjk[[D[D[[[[D[[[D[Dsd[[Dhfkah[[[[DD[[DDsdfjk[[D[D[[
>
> D[[[[DDDahsdk[[[[D[DDjfhjka[D
> -sh:
> fdasfdakjsdhfkajsdhfkjadklasdjfhajk[[D[[[D[Dsd[[Dhfkah[[[[DD[[DDsdfjk[[D[D[[D[[[[DDDahsdk[[[[D[DDjfhjka[D:
> not found
>
>
> I bisected it and yours Subject patch caused my problems. It is really
> old patch and I was surprised how old it is.
>
>
> Here is your diff
> diff --git a/drivers/serial/of_serial.c b/drivers/serial/of_serial.c
> index 02406ba..54483cd 100644
> --- a/drivers/serial/of_serial.c
> +++ b/drivers/serial/of_serial.c
> @@ -67,7 +67,7 @@ static int __devinit of_platform_serial_setup(struct
> of_device *ofdev,
> port->type = type;
> port->uartclk = *clk;
> port->flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_IOREMAP
> - | UPF_FIXED_PORT | UPF_FIXED_TYPE;
> + | UPF_FIXED_PORT;
> port->dev = &ofdev->dev;
> /* If current-speed was set, then try not to change it. */
> if (spd)
>
>
> If I trace port->type I am getting 3. (drivers/serial/8250.c:3089
> serial8250_register_port func 3118 - serial8250_register_port)
> Grant: Could you please print that value on ppc?
>
> Can you give me any hints what could be wrong? I will continue on it
> tomorrow.
>
> Thanks,
> Michal
>
>
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
|
