Mailing List Archive: Linux: Kernel

PATCH [0/2] - CHECKSTACK: sparc-stack-size and formatting

Index | Next | Previous | View Threaded

pboettcher at kernellabs

Nov 23, 2009, 3:01 AM

Post #1 of 3 (130 views)
Permalink

PATCH [0/2] - CHECKSTACK: sparc-stack-size and formatting

Hi,

I shamelessly stole the checkstack-script for a project of mine and now
want to contribute what I changed:

1) CHECKSTACK: sparc: fix regex to match all stacksizes
2) CHECKSTACK: simplify text-formatting for displaying the stacksize

For 1): as there are no comments in the script as to why the regex was
limiting the detection of stacksizes to less 300 bytes and if I understood
it correctly, to a maximum of 1000, I simply removed it.

best regards,
--

Patrick Boettcher - Kernel Labs
http://www.kernellabs.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

xiyou.wangcong at gmail

Nov 23, 2009, 7:50 AM

Post #2 of 3 (124 views)
Permalink

Re: PATCH [0/2] - CHECKSTACK: sparc-stack-size and formatting [In reply to]

On Mon, Nov 23, 2009 at 12:01:00PM +0100, Patrick Boettcher wrote:
> Hi,
>
> I shamelessly stole the checkstack-script for a project of mine and now
> want to contribute what I changed:
>
> 1) CHECKSTACK: sparc: fix regex to match all stacksizes

Please Cc sparc people for this, he should be David Miller, I think.

> 2) CHECKSTACK: simplify text-formatting for displaying the stacksize
>
> For 1): as there are no comments in the script as to why the regex was
> limiting the detection of stacksizes to less 300 bytes and if I
> understood it correctly, to a maximum of 1000, I simply removed it.

Please don't do this, write your change log for each patch please.

--
Live like a child, think like the god.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

davem at davemloft

Nov 29, 2009, 5:09 PM

Post #3 of 3 (118 views)
Permalink

Re: PATCH [0/2] - CHECKSTACK: sparc-stack-size and formatting [In reply to]

From: Patrick Boettcher <pboettcher [at] kernellabs>
Date: Mon, 23 Nov 2009 12:01:00 +0100 (CET)

> I shamelessly stole the checkstack-script for a project of mine and
> now want to contribute what I changed:
>
> 1) CHECKSTACK: sparc: fix regex to match all stacksizes
> 2) CHECKSTACK: simplify text-formatting for displaying the stacksize
>
> For 1): as there are no comments in the script as to why the regex was
> limiting the detection of stacksizes to less 300 bytes and if I
> understood it correctly, to a maximum of 1000, I simply removed it.

The limit is just an oversight as far as I can tell, your sparc
regex fix looks fine to me, thanks!

Acked-by: David S. Miller <davem [at] davemloft>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads