Mailing List Archive: Linux: Kernel

[PATCH] Fixed bug in Wireless Extension Code (CONFIG_WEXT_CORE).

Index | Next | Previous | View Threaded

mike at mspradling

Nov 22, 2009, 4:36 PM

Post #1 of 6 (286 views)
Permalink

[PATCH] Fixed bug in Wireless Extension Code (CONFIG_WEXT_CORE).

From: Michael Spradling <mike [at] mspradling>

When CONFIG_WEXT_CORE is not enabled and CONFIG_WEXT_PRIV is enabled
there currently is a few build errors. This is because several
functions call function call_commit_handler which is currently only
defined when CONFIG_WEXT_CORE is enabled.

Signed-off-by: Michael Spradling <mike [at] mspradling>
---
include/net/wext.h | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/include/net/wext.h b/include/net/wext.h
index 4f6e742..773c8c6 100644
--- a/include/net/wext.h
+++ b/include/net/wext.h
@@ -24,6 +24,10 @@ static inline int compat_wext_handle_ioctl(struct net *net, unsigned int cmd,
{
return -EINVAL;
}
+static inline int call_commit_handler(struct net_device *dev)
+{
+ return -EINVAL;
+}
#endif

#ifdef CONFIG_WEXT_PROC
--
1.6.5.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

johannes at sipsolutions

Nov 23, 2009, 1:45 AM

Post #2 of 6 (252 views)
Permalink

Re: [PATCH] Fixed bug in Wireless Extension Code (CONFIG_WEXT_CORE). [In reply to]

Hi,

Please send wireless patches to the correct list (linux-wireless) in the
future.

On Sun, 2009-11-22 at 19:36 -0500, mike [at] mspradling wrote:

> When CONFIG_WEXT_CORE is not enabled and CONFIG_WEXT_PRIV is enabled
> there currently is a few build errors.

This should never happen unless there's as bug in Kconfig, please
provide the config that creates this problem so we can fix that issue
rather than work around it. When PRIV is enabled but not CORE, this
patch may fix compilation but it doesn't fix that the configuration
makes no sense at all.

johannes

Attachments:

signature.asc (0.78 KB)

mike at mspradling

Nov 23, 2009, 7:42 AM

Post #3 of 6 (252 views)
Permalink

Re: [PATCH] Fixed bug in Wireless Extension Code (CONFIG_WEXT_CORE). [In reply to]

I don't think its a Kconfig issue, see notes below. However,
I have included my config file just in case I may be wrong.

Thank you
On Mon, Nov 23, 2009 at 10:45:41AM +0100, Johannes Berg wrote:
> Hi,
>
> Please send wireless patches to the correct list (linux-wireless) in the
> future.
>
> On Sun, 2009-11-22 at 19:36 -0500, mike [at] mspradling wrote:
>
> > When CONFIG_WEXT_CORE is not enabled and CONFIG_WEXT_PRIV is enabled
> > there currently is a few build errors.
>
> This should never happen unless there's as bug in Kconfig, please
> provide the config that creates this problem so we can fix that issue
> rather than work around it. When PRIV is enabled but not CORE, this
> patch may fix compilation but it doesn't fix that the configuration
> makes no sense at all.
>
> johannes
>

I at first assumed there was a bug in Kconfig and looked into this.
However, I found this solution is not a hack. PRIV does not depend
on CORE. Some header files in "PRIV CODE" check and see if CORE is
defined. If it is not defined it appears to impliment dummy functions
that return an error code. All but one of these dummy functions are
implimented. This patch just implements one that was forgoten.

Michael Spradling

Attachments:

config (34.6 KB)

johannes at sipsolutions

Nov 23, 2009, 7:53 AM

Post #4 of 6 (253 views)
Permalink

Re: [PATCH] Fixed bug in Wireless Extension Code (CONFIG_WEXT_CORE). [In reply to]

On Mon, 2009-11-23 at 10:42 -0500, Michael Spradling wrote:
> I don't think its a Kconfig issue, see notes below. However,
> I have included my config file just in case I may be wrong.

You config file doesn't have _any_ wireless options set. Not even
CONFIG_NET.

johannes

Attachments:

signature.asc (0.78 KB)

mike at mspradling

Nov 23, 2009, 5:12 PM

Post #5 of 6 (246 views)
Permalink

Re: [PATCH] Fixed bug in Wireless Extension Code (CONFIG_WEXT_CORE). [In reply to]

Sorry, I lost my config file and haven't been able to reproduce it.
If I come across this again I will email you directly.

--
Mike Spradling

On Mon, Nov 23, 2009 at 04:53:46PM +0100, Johannes Berg wrote:
> On Mon, 2009-11-23 at 10:42 -0500, Michael Spradling wrote:
> > I don't think its a Kconfig issue, see notes below. However,
> > I have included my config file just in case I may be wrong.
>
> You config file doesn't have _any_ wireless options set. Not even
> CONFIG_NET.
>
> johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

randy.dunlap at oracle

Dec 1, 2009, 9:46 AM

Post #6 of 6 (212 views)
Permalink

Re: [PATCH] Fixed bug in Wireless Extension Code (CONFIG_WEXT_CORE). [In reply to]

Michael Spradling wrote:
> Sorry, I lost my config file and haven't been able to reproduce it.
> If I come across this again I will email you directly.

> --
> Mike Spradling
>
> On Mon, Nov 23, 2009 at 04:53:46PM +0100, Johannes Berg wrote:
>> On Mon, 2009-11-23 at 10:42 -0500, Michael Spradling wrote:
>>> I don't think its a Kconfig issue, see notes below. However,
>>> I have included my config file just in case I may be wrong.
>> You config file doesn't have _any_ wireless options set. Not even
>> CONFIG_NET.
>>
>> johannes

All of the cases that I have seen where call_commit_handler() is undefined
have been kconfig errors -- mostly in drivers/staging/.

If you do have this problem again, please be sure to send the problem
.config file.

--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads