Mailing List Archive: Linux: Kernel

[patch 0/8] x86: UV - XPC fixes with related support functionality V2.

Index | Next | Previous | View Threaded

holt at sgi

Nov 19, 2009, 9:31 AM

Post #1 of 8 (252 views)
Permalink

[patch 0/8] x86: UV - XPC fixes with related support functionality V2.

The UV BIOS has been updated to implement some of our interface
functionality differently than originally expected. These patches
update us to that working bios and include a few minor bug fixes
which prevent us from doing significant testing on real hardware.

Changes from V1:

- Actually include the patch introducing the gru_read_gpa. This
was missed in the V1 submission.

- One additional BIOS change has the OS no longer passing blade
to the BIOS when registering a message queue watchlist.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

mingo at elte

Nov 23, 2009, 10:03 AM

Post #2 of 8 (229 views)
Permalink

Re: [patch 0/8] x86: UV - XPC fixes with related support functionality V2. [In reply to]

* Robin Holt <holt [at] sgi> wrote:

>
> The UV BIOS has been updated to implement some of our interface
> functionality differently than originally expected. These patches
> update us to that working bios and include a few minor bug fixes
> which prevent us from doing significant testing on real hardware.
>
> Changes from V1:
>
> - Actually include the patch introducing the gru_read_gpa. This
> was missed in the V1 submission.
>
> - One additional BIOS change has the OS no longer passing blade
> to the BIOS when registering a message queue watchlist.

Note, the patches are a bit hard to review without diffstats - mind
generating them for future patches? Also, putting a 'summary' diffstat
(the total diffstat effect of all patches) into the 0/8 description mail
is common courtesy that is much welcome by maintainers and reviewers as
well.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

mingo at elte

Nov 23, 2009, 10:10 AM

Post #3 of 8 (231 views)
Permalink

Re: [patch 0/8] x86: UV - XPC fixes with related support functionality V2. [In reply to]

* Ingo Molnar <mingo [at] elte> wrote:

> * Robin Holt <holt [at] sgi> wrote:
>
> >
> > The UV BIOS has been updated to implement some of our interface
> > functionality differently than originally expected. These patches
> > update us to that working bios and include a few minor bug fixes
> > which prevent us from doing significant testing on real hardware.
> >
> > Changes from V1:
> >
> > - Actually include the patch introducing the gru_read_gpa. This
> > was missed in the V1 submission.
> >
> > - One additional BIOS change has the OS no longer passing blade
> > to the BIOS when registering a message queue watchlist.
>
> Note, the patches are a bit hard to review without diffstats - mind
> generating them for future patches? Also, putting a 'summary' diffstat
> (the total diffstat effect of all patches) into the 0/8 description mail
> is common courtesy that is much welcome by maintainers and reviewers as
> well.

Ah, sorry - they were there, just merged together with the patch so i
missed them.

Regarding the patches - i still very much dislike how the code
interfaces to the 'BIOS'. The drivers/misc/sgi-xp/ code looks rather
messy.

Why isnt a pure hardware interface exposed, as both hpa and me suggested
in the past?

Anyway ... these bits got merged via -mm in the past so i guess it could
be done there in the future too - the series does not look horrible -
but the whole concept ought to be done in a cleaner way.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

holt at sgi

Nov 23, 2009, 3:57 PM

Post #4 of 8 (225 views)
Permalink

Re: [patch 0/8] x86: UV - XPC fixes with related support functionality V2. [In reply to]

> Regarding the patches - i still very much dislike how the code
> interfaces to the 'BIOS'. The drivers/misc/sgi-xp/ code looks rather
> messy.
>
> Why isnt a pure hardware interface exposed, as both hpa and me suggested
> in the past?

The information is stored on hardware (UV-Hub and RAM) outside this instance of hardware.

The only safe way to access that hardware is via the GRU.

No GRU resources are available to the BIOS.

Ergo, this interface method with multiple passes is needed.

If there is a better way, I am open to suggestions.

> Anyway ... these bits got merged via -mm in the past so i guess it could
> be done there in the future too - the series does not look horrible -
> but the whole concept ought to be done in a cleaner way.

I will ask Andrew to take them.

Thanks,
Robin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

holt at sgi

Nov 23, 2009, 5:39 PM

Post #5 of 8 (224 views)
Permalink

[patch 0/8] x86: UV - XPC fixes with related support functionality V2. [In reply to]

The UV BIOS has been updated to implement some of our interface
functionality differently than originally expected. These patches update
the kernel to the bios implementation and include a few minor bug fixes
which prevent us from doing significant testing on real hardware.

Changes from V1:

- Actually include the patch introducing the gru_read_gpa. This
was missed in the V1 submission.

- One additional BIOS change has the OS no longer passing blade
to the BIOS when registering a message queue watchlist.

---

arch/x86/include/asm/uv/bios.h | 11 --------
arch/x86/include/asm/uv/uv_hub.h | 20 +++++++++++++++
arch/x86/kernel/bios_uv.c | 8 +-----
drivers/misc/sgi-gru/gru_instructions.h | 13 ++++++++++
drivers/misc/sgi-gru/grukservices.c | 23 +++++++++++++++++
drivers/misc/sgi-gru/grukservices.h | 14 ++++++++++
drivers/misc/sgi-gru/gruprocfs.c | 1
drivers/misc/sgi-gru/grutables.h | 1
drivers/misc/sgi-xp/xp.h | 1
drivers/misc/sgi-xp/xp_main.c | 3 ++
drivers/misc/sgi-xp/xp_sn2.c | 10 +++++++
drivers/misc/sgi-xp/xp_uv.c | 33 +++++++++++++++++++++++++
drivers/misc/sgi-xp/xpc_partition.c | 13 +++++++---
drivers/misc/sgi-xp/xpc_uv.c | 41 +++++++++++++++++---------------
14 files changed, 153 insertions(+), 39 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

mingo at elte

Nov 23, 2009, 11:19 PM

Post #6 of 8 (216 views)
Permalink

Re: [patch 0/8] x86: UV - XPC fixes with related support functionality V2. [In reply to]

* Robin Holt <holt [at] sgi> wrote:

> > Regarding the patches - i still very much dislike how the code
> > interfaces to the 'BIOS'. The drivers/misc/sgi-xp/ code looks rather
> > messy.
> >
> > Why isnt a pure hardware interface exposed, as both hpa and me
> > suggested in the past?
>
> The information is stored on hardware (UV-Hub and RAM) outside this
> instance of hardware.
>
> The only safe way to access that hardware is via the GRU.
>
> No GRU resources are available to the BIOS.
>
> Ergo, this interface method with multiple passes is needed.
>
> If there is a better way, I am open to suggestions.

Erm, the better way is to not use the BIOS but to access those registers
that the BIOS accesses? (which is currently hidden by the BIOS)

In other words, we want to remove arch/x86/kernel/bios_uv.c and the
uv_bios_call*() APIs and replace them via clear implementations for
clear hardware abstractions. That 'bios message queue' thing is absolute
madness for example. But the type-opaque software API too.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

holt at sgi

Dec 15, 2009, 9:04 AM

Post #7 of 8 (193 views)
Permalink

Re: [patch 0/8] x86: UV - XPC fixes with related support functionality V2. [In reply to]

Andrew, did this get lost in the shuffle? If you need me to
resubmit, please let me know.

Thanks,
Robin

On Mon, Nov 23, 2009 at 07:39:37PM -0600, Robin Holt wrote:
>
> The UV BIOS has been updated to implement some of our interface
> functionality differently than originally expected. These patches update
> the kernel to the bios implementation and include a few minor bug fixes
> which prevent us from doing significant testing on real hardware.
>
> Changes from V1:
>
> - Actually include the patch introducing the gru_read_gpa. This
> was missed in the V1 submission.
>
> - One additional BIOS change has the OS no longer passing blade
> to the BIOS when registering a message queue watchlist.
>
> ---
>
> arch/x86/include/asm/uv/bios.h | 11 --------
> arch/x86/include/asm/uv/uv_hub.h | 20 +++++++++++++++
> arch/x86/kernel/bios_uv.c | 8 +-----
> drivers/misc/sgi-gru/gru_instructions.h | 13 ++++++++++
> drivers/misc/sgi-gru/grukservices.c | 23 +++++++++++++++++
> drivers/misc/sgi-gru/grukservices.h | 14 ++++++++++
> drivers/misc/sgi-gru/gruprocfs.c | 1
> drivers/misc/sgi-gru/grutables.h | 1
> drivers/misc/sgi-xp/xp.h | 1
> drivers/misc/sgi-xp/xp_main.c | 3 ++
> drivers/misc/sgi-xp/xp_sn2.c | 10 +++++++
> drivers/misc/sgi-xp/xp_uv.c | 33 +++++++++++++++++++++++++
> drivers/misc/sgi-xp/xpc_partition.c | 13 +++++++---
> drivers/misc/sgi-xp/xpc_uv.c | 41 +++++++++++++++++---------------
> 14 files changed, 153 insertions(+), 39 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

holt at sgi

Dec 15, 2009, 9:06 AM

Post #8 of 8 (191 views)
Permalink

Re: [patch 0/8] x86: UV - XPC fixes with related support functionality V2. [In reply to]

Argh. Forget it. I see them now. I am sorry for the noise.

Robin

On Tue, Dec 15, 2009 at 11:04:39AM -0600, Robin Holt wrote:
> Andrew, did this get lost in the shuffle? If you need me to
> resubmit, please let me know.
>
> Thanks,
> Robin
>
> On Mon, Nov 23, 2009 at 07:39:37PM -0600, Robin Holt wrote:
> >
> > The UV BIOS has been updated to implement some of our interface
> > functionality differently than originally expected. These patches update
> > the kernel to the bios implementation and include a few minor bug fixes
> > which prevent us from doing significant testing on real hardware.
> >
> > Changes from V1:
> >
> > - Actually include the patch introducing the gru_read_gpa. This
> > was missed in the V1 submission.
> >
> > - One additional BIOS change has the OS no longer passing blade
> > to the BIOS when registering a message queue watchlist.
> >
> > ---
> >
> > arch/x86/include/asm/uv/bios.h | 11 --------
> > arch/x86/include/asm/uv/uv_hub.h | 20 +++++++++++++++
> > arch/x86/kernel/bios_uv.c | 8 +-----
> > drivers/misc/sgi-gru/gru_instructions.h | 13 ++++++++++
> > drivers/misc/sgi-gru/grukservices.c | 23 +++++++++++++++++
> > drivers/misc/sgi-gru/grukservices.h | 14 ++++++++++
> > drivers/misc/sgi-gru/gruprocfs.c | 1
> > drivers/misc/sgi-gru/grutables.h | 1
> > drivers/misc/sgi-xp/xp.h | 1
> > drivers/misc/sgi-xp/xp_main.c | 3 ++
> > drivers/misc/sgi-xp/xp_sn2.c | 10 +++++++
> > drivers/misc/sgi-xp/xp_uv.c | 33 +++++++++++++++++++++++++
> > drivers/misc/sgi-xp/xpc_partition.c | 13 +++++++---
> > drivers/misc/sgi-xp/xpc_uv.c | 41 +++++++++++++++++---------------
> > 14 files changed, 153 insertions(+), 39 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads