a.p.zijlstra at chello
Nov 16, 2009, 3:18 AM
Post #1 of 1
(72 views)
Permalink
|
|
[tip:sched/urgent] sched: Sched_rt_periodic_timer vs cpu hotplug
|
|
Commit-ID: 047106adcc85e3023da210143a6ab8a55df9e0fc
Gitweb: http://git.kernel.org/tip/047106adcc85e3023da210143a6ab8a55df9e0fc
Author: Peter Zijlstra <a.p.zijlstra [at] chello>
AuthorDate: Mon, 16 Nov 2009 10:28:09 +0100
Committer: Ingo Molnar <mingo [at] elte>
CommitDate: Mon, 16 Nov 2009 10:46:27 +0100
sched: Sched_rt_periodic_timer vs cpu hotplug
Heiko reported a case where a timer interrupt managed to
reference a root_domain structure that was already freed by a
concurrent hot-un-plug operation.
Solve this like the regular sched_domain stuff is also
synchronized, by adding a synchronize_sched() stmt to the free
path, this ensures that a root_domain stays present for any
atomic section that could have observed it.
Reported-by: Heiko Carstens <heiko.carstens [at] de>
Signed-off-by: Peter Zijlstra <a.p.zijlstra [at] chello>
Acked-by: Heiko Carstens <heiko.carstens [at] de>
Cc: Gregory Haskins <ghaskins [at] novell>
Cc: Siddha Suresh B <suresh.b.siddha [at] intel>
Cc: Martin Schwidefsky <schwidefsky [at] de>
LKML-Reference: <1258363873.26714.83.camel [at] lapto>
Signed-off-by: Ingo Molnar <mingo [at] elte>
---
kernel/sched.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index cea2bea..3c91f11 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -7912,6 +7912,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)
static void free_rootdomain(struct root_domain *rd)
{
+ synchronize_sched();
+
cpupri_cleanup(&rd->cpupri);
free_cpumask_var(rd->rto_mask);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
|
