Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

Fix typo in intel cache size

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


davej at redhat

Nov 10, 2009, 12:01 PM

Post #1 of 2 (127 views)
Permalink
Fix typo in intel cache size

I double-checked the datasheet. This should be 2MB.

Signed-off-by: Dave Jones <davej [at] redhat>

diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 804c40e..6123138 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -94,7 +94,7 @@ static const struct _cache_table __cpuinitconst cache_table[] =
{ 0xd1, LVL_3, 1024 }, /* 4-way set assoc, 64 byte line size */
{ 0xd2, LVL_3, 2048 }, /* 4-way set assoc, 64 byte line size */
{ 0xd6, LVL_3, 1024 }, /* 8-way set assoc, 64 byte line size */
- { 0xd7, LVL_3, 2038 }, /* 8-way set assoc, 64 byte line size */
+ { 0xd7, LVL_3, 2048 }, /* 8-way set assoc, 64 byte line size */
{ 0xd8, LVL_3, 4096 }, /* 12-way set assoc, 64 byte line size */
{ 0xdc, LVL_3, 2048 }, /* 12-way set assoc, 64 byte line size */
{ 0xdd, LVL_3, 4096 }, /* 12-way set assoc, 64 byte line size */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


mingo at elte

Nov 10, 2009, 12:53 PM

Post #2 of 2 (110 views)
Permalink
Re: Fix typo in intel cache size [In reply to]

* Dave Jones <davej [at] redhat> wrote:

> I double-checked the datasheet. This should be 2MB.
>
> Signed-off-by: Dave Jones <davej [at] redhat>
>
> diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
> index 804c40e..6123138 100644
> --- a/arch/x86/kernel/cpu/intel_cacheinfo.c
> +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
> @@ -94,7 +94,7 @@ static const struct _cache_table __cpuinitconst cache_table[] =
> { 0xd1, LVL_3, 1024 }, /* 4-way set assoc, 64 byte line size */
> { 0xd2, LVL_3, 2048 }, /* 4-way set assoc, 64 byte line size */
> { 0xd6, LVL_3, 1024 }, /* 8-way set assoc, 64 byte line size */
> - { 0xd7, LVL_3, 2038 }, /* 8-way set assoc, 64 byte line size */
> + { 0xd7, LVL_3, 2048 }, /* 8-way set assoc, 64 byte line size */

ah, thanks - applied.

I also marked both fixes from you for -stable backport - these are
pretty risk-free fixes and cpuinfo looks ugly on new CPUs without a
proper cache size entry.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.