Mailing List Archive: Linux: Kernel

Re: [PATCH v2] staging/otus: trivial, fix sparse warnig.

Index | Next | Previous | View Threaded

tfransosi at gmail

Nov 6, 2009, 5:45 PM

Post #1 of 8 (277 views)
Permalink

Re: [PATCH v2] staging/otus: trivial, fix sparse warnig.

*apdbg.c: use NULL pointer instead of 0 integer.

Signed-off-by: Thiago Farina <tfransosi [at] gmail>
---
drivers/staging/otus/apdbg.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/otus/apdbg.c b/drivers/staging/otus/apdbg.c
index d3e2f62..70a40b8 100644
--- a/drivers/staging/otus/apdbg.c
+++ b/drivers/staging/otus/apdbg.c
@@ -109,7 +109,7 @@ int set_ioctl(int sock, struct ifreq *req)

int read_reg(int sock, struct ifreq *req)
{
- struct zdap_ioctl *zdreq = 0;
+ struct zdap_ioctl *zdreq = NULL;

if (!set_ioctl(sock, req))
return -1;
@@ -123,7 +123,7 @@ int read_reg(int sock, struct ifreq *req)

int read_mem(int sock, struct ifreq *req)
{
- struct zdap_ioctl *zdreq = 0;
+ struct zdap_ioctl *zdreq = NULL;
int i;

if (!set_ioctl(sock, req))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

greg at kroah

Nov 19, 2009, 11:34 AM

Post #2 of 8 (243 views)
Permalink

Re: [PATCH v2] staging/otus: trivial, fix sparse warnig. [In reply to]

On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote:
> *apdbg.c: use NULL pointer instead of 0 integer.
>
> Signed-off-by: Thiago Farina <tfransosi [at] gmail>

Still doesn't apply, I don't know what you are doing wrong here :(

odd.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

tfransosi at gmail

Nov 20, 2009, 11:18 AM

Post #3 of 8 (237 views)
Permalink

Re: [PATCH v2] staging/otus: trivial, fix sparse warnig. [In reply to]

Hi Greg,

On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg [at] kroah> wrote:
> On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote:
>> *apdbg.c: use NULL pointer instead of 0 integer.
>>
>> Signed-off-by: Thiago Farina <tfransosi [at] gmail>
>
> Still doesn't apply, I don't know what you are doing wrong here :(
>
> odd.

How are you applying it?

I can try reproduce here and figure out what is wrong :/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

greg at kroah

Nov 20, 2009, 11:22 AM

Post #4 of 8 (236 views)
Permalink

Re: [PATCH v2] staging/otus: trivial, fix sparse warnig. [In reply to]

On Fri, Nov 20, 2009 at 05:18:09PM -0200, Thiago Farina wrote:
> Hi Greg,
>
> On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg [at] kroah> wrote:
> > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote:
> >> *apdbg.c: use NULL pointer instead of 0 integer.
> >>
> >> Signed-off-by: Thiago Farina <tfransosi [at] gmail>
> >
> > Still doesn't apply, I don't know what you are doing wrong here :(
> >
> > odd.
>
> How are you applying it?

'patch -p1 < your_email'

> I can try reproduce here and figure out what is wrong :/

Please do.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

tfransosi at gmail

Nov 20, 2009, 12:09 PM

Post #5 of 8 (238 views)
Permalink

Re: [PATCH v2] staging/otus: trivial, fix sparse warnig. [In reply to]

On Fri, Nov 20, 2009 at 5:22 PM, Greg KH <greg [at] kroah> wrote:
> On Fri, Nov 20, 2009 at 05:18:09PM -0200, Thiago Farina wrote:
>> Hi Greg,
>>
>> On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg [at] kroah> wrote:
>> > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote:
>> >> *apdbg.c: use NULL pointer instead of 0 integer.
>> >>
>> >> Signed-off-by: Thiago Farina <tfransosi [at] gmail>
>> >
>> > Still doesn't apply, I don't know what you are doing wrong here :(
>> >
>> > odd.
>>
>> How are you applying it?
>
> 'patch -p1 < your_email'

Are you getting something like: "Hmm... Ignoring the trailing garbage." ?

The output for me was this:
...
Patching file drivers/staging/otus/apdbg.c using Plan A...
Hunk #1 succeeded at 109.
Hunk #2 succeeded at 123.
Hmm... Ignoring the trailing garbage.
done
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

greg at kroah

Nov 20, 2009, 12:15 PM

Post #6 of 8 (239 views)
Permalink

Re: [PATCH v2] staging/otus: trivial, fix sparse warnig. [In reply to]

On Fri, Nov 20, 2009 at 06:09:09PM -0200, Thiago Farina wrote:
> On Fri, Nov 20, 2009 at 5:22 PM, Greg KH <greg [at] kroah> wrote:
> > On Fri, Nov 20, 2009 at 05:18:09PM -0200, Thiago Farina wrote:
> >> Hi Greg,
> >>
> >> On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg [at] kroah> wrote:
> >> > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote:
> >> >> *apdbg.c: use NULL pointer instead of 0 integer.
> >> >>
> >> >> Signed-off-by: Thiago Farina <tfransosi [at] gmail>
> >> >
> >> > Still doesn't apply, I don't know what you are doing wrong here :(
> >> >
> >> > odd.
> >>
> >> How are you applying it?
> >
> > 'patch -p1 < your_email'
>
> Are you getting something like: "Hmm... Ignoring the trailing garbage." ?
>
> The output for me was this:
> ...
> Patching file drivers/staging/otus/apdbg.c using Plan A...
> Hunk #1 succeeded at 109.
> Hunk #2 succeeded at 123.
> Hmm... Ignoring the trailing garbage.
> done

Are you appling this to the linux-next tree? Or Linus's tree? I just
get a failure against linux-next.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

tfransosi at gmail

Nov 20, 2009, 1:22 PM

Post #7 of 8 (236 views)
Permalink

Re: [PATCH v2] staging/otus: trivial, fix sparse warnig. [In reply to]

On Fri, Nov 20, 2009 at 6:15 PM, Greg KH <greg [at] kroah> wrote:
> On Fri, Nov 20, 2009 at 06:09:09PM -0200, Thiago Farina wrote:
>> On Fri, Nov 20, 2009 at 5:22 PM, Greg KH <greg [at] kroah> wrote:
>> > On Fri, Nov 20, 2009 at 05:18:09PM -0200, Thiago Farina wrote:
>> >> Hi Greg,
>> >>
>> >> On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg [at] kroah> wrote:
>> >> > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote:
>> >> >> *apdbg.c: use NULL pointer instead of 0 integer.
>> >> >>
>> >> >> Signed-off-by: Thiago Farina <tfransosi [at] gmail>
>> >> >
>> >> > Still doesn't apply, I don't know what you are doing wrong here :(
>> >> >
>> >> > odd.
>> >>
>> >> How are you applying it?
>> >
>> > 'patch -p1 < your_email'
>>
>> Are you getting something like: "Hmm... Ignoring the trailing garbage." ?
>>
>> The output for me was this:
>> ...
>> Patching file drivers/staging/otus/apdbg.c using Plan A...
>> Hunk #1 succeeded at 109.
>> Hunk #2 succeeded at 123.
>> Hmm... Ignoring the trailing garbage.
>> done
>
> Are you appling this to the linux-next tree? Or Linus's tree? I just
> get a failure against linux-next.

I'm applying it to the Linus's tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

greg at kroah

Nov 20, 2009, 1:28 PM

Post #8 of 8 (237 views)
Permalink

Re: [PATCH v2] staging/otus: trivial, fix sparse warnig. [In reply to]

On Fri, Nov 20, 2009 at 07:22:59PM -0200, Thiago Farina wrote:
> On Fri, Nov 20, 2009 at 6:15 PM, Greg KH <greg [at] kroah> wrote:
> > On Fri, Nov 20, 2009 at 06:09:09PM -0200, Thiago Farina wrote:
> >> On Fri, Nov 20, 2009 at 5:22 PM, Greg KH <greg [at] kroah> wrote:
> >> > On Fri, Nov 20, 2009 at 05:18:09PM -0200, Thiago Farina wrote:
> >> >> Hi Greg,
> >> >>
> >> >> On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg [at] kroah> wrote:
> >> >> > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote:
> >> >> >> *apdbg.c: use NULL pointer instead of 0 integer.
> >> >> >>
> >> >> >> Signed-off-by: Thiago Farina <tfransosi [at] gmail>
> >> >> >
> >> >> > Still doesn't apply, I don't know what you are doing wrong here :(
> >> >> >
> >> >> > odd.
> >> >>
> >> >> How are you applying it?
> >> >
> >> > 'patch -p1 < your_email'
> >>
> >> Are you getting something like: "Hmm... Ignoring the trailing garbage." ?
> >>
> >> The output for me was this:
> >> ...
> >> Patching file drivers/staging/otus/apdbg.c using Plan A...
> >> Hunk #1 succeeded at 109.
> >> Hunk #2 succeeded at 123.
> >> Hmm... �Ignoring the trailing garbage.
> >> done
> >
> > Are you appling this to the linux-next tree? �Or Linus's tree? �I just
> > get a failure against linux-next.
>
> I'm applying it to the Linus's tree.

Please generate it against linux-next, as there are already otus patches
in my tree, which is included in the linux-next snapshots.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads