Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH] edac: fix i7core build

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


randy.dunlap at oracle

Nov 4, 2009, 1:57 PM

Post #1 of 2 (151 views)
Permalink
[PATCH] edac: fix i7core build

From: Randy Dunlap <randy.dunlap [at] oracle>

Fix build warning (missing header file) and
build error when CONFIG_SMP=n.

drivers/edac/i7core_edac.c:860: error: implicit declaration of function 'msleep'
drivers/edac/i7core_edac.c:1700: error: 'struct cpuinfo_x86' has no member named 'phys_proc_id'

Signed-off-by: Randy Dunlap <randy.dunlap [at] oracle>
Cc: Mauro Carvalho Chehab <mchehab [at] redhat>
---
drivers/edac/i7core_edac.c | 3 +++
1 file changed, 3 insertions(+)

--- linux-next-20091104.orig/drivers/edac/i7core_edac.c
+++ linux-next-20091104/drivers/edac/i7core_edac.c
@@ -25,6 +25,7 @@
#include <linux/pci.h>
#include <linux/pci_ids.h>
#include <linux/slab.h>
+#include <linux/delay.h>
#include <linux/edac.h>
#include <linux/mmzone.h>
#include <linux/edac_mce.h>
@@ -1696,9 +1697,11 @@ static int i7core_mce_check_error(void *
if (mce->bank != 8)
return 0;

+#ifdef CONFIG_SMP
/* Only handle if it is the right mc controller */
if (cpu_data(mce->cpu).phys_proc_id != pvt->i7core_dev->socket)
return 0;
+#endif

smp_rmb();
if ((pvt->mce_out + 1) % MCE_LOG_LEN == pvt->mce_in) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


mchehab at redhat

Nov 7, 2009, 7:45 PM

Post #2 of 2 (129 views)
Permalink
Re: [PATCH] edac: fix i7core build [In reply to]

Em Wed, 4 Nov 2009 13:57:33 -0800
Randy Dunlap <randy.dunlap [at] oracle> escreveu:

> From: Randy Dunlap <randy.dunlap [at] oracle>
>
> Fix build warning (missing header file) and
> build error when CONFIG_SMP=n.
>
> drivers/edac/i7core_edac.c:860: error: implicit declaration of function 'msleep'
> drivers/edac/i7core_edac.c:1700: error: 'struct cpuinfo_x86' has no member named 'phys_proc_id'
>
> Signed-off-by: Randy Dunlap <randy.dunlap [at] oracle>
> Cc: Mauro Carvalho Chehab <mchehab [at] redhat>

Hi Randy,

Thank you for the patch.

FYI, I've just added your and Alan's fixes on my linux-next tree for i7core:

http://git.kernel.org/?p=linux/kernel/git/mchehab/i7core.git;a=commit;h=0480ce880b999703fbb73912054f4de187da543a
http://git.kernel.org/?p=linux/kernel/git/mchehab/i7core.git;a=commit;h=df0a7a70df5e9c5d612b249661f8b3883be41331

Sorry for not doing it earlier. I was handling a big backlog I had here, due to
a training course and my trip to Japan (that happened at the week after the training).

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.