Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Linux: Kernel

[PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

 

 

Linux kernel RSS feed   Index | Next | Previous | View Threaded


jaswinder at kernel

Jul 8, 2009, 8:32 AM

Post #1 of 6 (278 views)
Permalink
[PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

fix the following 'make includecheck' warnings:

drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
drivers/spi/amba-pl022.c: linux/errno.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput [at] gmail>
---
drivers/spi/amba-pl022.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
index da76797..c0f950a 100644
--- a/drivers/spi/amba-pl022.c
+++ b/drivers/spi/amba-pl022.c
@@ -38,14 +38,12 @@
#include <linux/interrupt.h>
#include <linux/spi/spi.h>
#include <linux/workqueue.h>
-#include <linux/errno.h>
#include <linux/delay.h>
#include <linux/clk.h>
#include <linux/err.h>
#include <linux/amba/bus.h>
#include <linux/amba/pl022.h>
#include <linux/io.h>
-#include <linux/delay.h>

/*
* This macro is used to define some register default values.
--
1.6.0.6



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


linus.ml.walleij at gmail

Jul 8, 2009, 10:28 AM

Post #2 of 6 (263 views)
Permalink
Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c [In reply to]

2009/7/8 Jaswinder Singh Rajput <jaswinder [at] kernel>:

> fix the following 'make includecheck' warnings:
>
>  drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
>  drivers/spi/amba-pl022.c: linux/errno.h is included more than once.

Acked-by: Linus Walleij <linus.walleij [at] stericsson>

David are you merging this?

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


david-b at pacbell

Jul 8, 2009, 10:39 AM

Post #3 of 6 (265 views)
Permalink
Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c [In reply to]

On Wednesday 08 July 2009, Jaswinder Singh Rajput wrote:
>
> fix the following 'make includecheck' warnings:
>
> drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
> drivers/spi/amba-pl022.c: linux/errno.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput [at] gmail>

Acked-by: David Brownell <dbrownell [at] users>


> ---
> drivers/spi/amba-pl022.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
> index da76797..c0f950a 100644
> --- a/drivers/spi/amba-pl022.c
> +++ b/drivers/spi/amba-pl022.c
> @@ -38,14 +38,12 @@
> #include <linux/interrupt.h>
> #include <linux/spi/spi.h>
> #include <linux/workqueue.h>
> -#include <linux/errno.h>
> #include <linux/delay.h>
> #include <linux/clk.h>
> #include <linux/err.h>
> #include <linux/amba/bus.h>
> #include <linux/amba/pl022.h>
> #include <linux/io.h>
> -#include <linux/delay.h>
>
> /*
> * This macro is used to define some register default values.
> --
> 1.6.0.6
>
>
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


jaswinder at kernel

Jul 8, 2009, 10:42 AM

Post #4 of 6 (262 views)
Permalink
Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c [In reply to]

On Wed, 2009-07-08 at 19:28 +0200, Linus Walleij wrote:
> 2009/7/8 Jaswinder Singh Rajput <jaswinder [at] kernel>:
>
> > fix the following 'make includecheck' warnings:
> >
> > drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
> > drivers/spi/amba-pl022.c: linux/errno.h is included more than once.
>
> Acked-by: Linus Walleij <linus.walleij [at] stericsson>
>
> David are you merging this?
>

This is a big patchset, So better me or Sam will send this to Linus
after collecting some more ACKs.

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


linus.ml.walleij at gmail

Jul 9, 2009, 2:17 PM

Post #5 of 6 (254 views)
Permalink
Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c [In reply to]

2009/7/8 Jaswinder Singh Rajput <jaswinder [at] kernel>:
> On Wed, 2009-07-08 at 19:28 +0200, Linus Walleij wrote:
>> 2009/7/8 Jaswinder Singh Rajput <jaswinder [at] kernel>:
>>
>> > fix the following 'make includecheck' warnings:
>> >
>> >  drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
>> >  drivers/spi/amba-pl022.c: linux/errno.h is included more than once.
>>
>> Acked-by: Linus Walleij <linus.walleij [at] stericsson>
>>
>> David are you merging this?
>
> This is a big patchset, So better me or Sam will send this to Linus
> after collecting some more ACKs.

Not me I hope (damned I knew this would happen sooner or later).
return -ELINWAL

Having this name is very convenient, people review my drivers like
crazy.

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/


torvalds at linux-foundation

Jul 9, 2009, 2:20 PM

Post #6 of 6 (254 views)
Permalink
Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c [In reply to]

On Thu, 9 Jul 2009, Linus Walleij wrote:
>
> Having this name is very convenient, people review my drivers like
> crazy.

ROTFL.

the-other-Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Linux kernel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.