Mailing List Archive: Linux: Kernel

[PATCH] SOUND: Remove commented out usage of dead MODULE_PARM().

Index | Next | Previous | View Threaded

rpjday at crashcourse

Jul 4, 2009, 5:44 PM

Post #1 of 2 (64 views)
Permalink

[PATCH] SOUND: Remove commented out usage of dead MODULE_PARM().

Signed-off-by: Robert P. J. Day <rpjday[at]crashcourse.ca>

---

get rid of that commented usage of the now defunct MODULE_PARM macro
simply because it pollutes a scan for actual references to that dead
macro.

diff --git a/sound/oss/swarm_cs4297a.c b/sound/oss/swarm_cs4297a.c
index 1edab7b..3136c88 100644
--- a/sound/oss/swarm_cs4297a.c
+++ b/sound/oss/swarm_cs4297a.c
@@ -110,9 +110,6 @@ static void start_adc(struct cs4297a_state *s);
// rather than 64k as some of the games work more responsively.
// log base 2( buff sz = 32k).

-//static unsigned long defaultorder = 3;
-//MODULE_PARM(defaultorder, "i");
-
//
// Turn on/off debugging compilation by commenting out "#define CSDEBUG"
//
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page: http://crashcourse.ca
Linked In: http://www.linkedin.com/in/rpjday
Twitter: http://twitter.com/rpjday
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

jkosina at suse

Jul 7, 2009, 12:59 AM

Post #2 of 2 (41 views)
Permalink

Re: [PATCH] SOUND: Remove commented out usage of dead MODULE_PARM(). [In reply to]

On Sat, 4 Jul 2009, Robert P. J. Day wrote:

>
> Signed-off-by: Robert P. J. Day <rpjday[at]crashcourse.ca>
>
> ---
>
> get rid of that commented usage of the now defunct MODULE_PARM macro
> simply because it pollutes a scan for actual references to that dead
> macro.
>
> diff --git a/sound/oss/swarm_cs4297a.c b/sound/oss/swarm_cs4297a.c
> index 1edab7b..3136c88 100644
> --- a/sound/oss/swarm_cs4297a.c
> +++ b/sound/oss/swarm_cs4297a.c
> @@ -110,9 +110,6 @@ static void start_adc(struct cs4297a_state *s);
> // rather than 64k as some of the games work more responsively.
> // log base 2( buff sz = 32k).
>
> -//static unsigned long defaultorder = 3;
> -//MODULE_PARM(defaultorder, "i");
> -
> //
> // Turn on/off debugging compilation by commenting out "#define CSDEBUG"
> //

Oh what a horrible driver anyway ...

Applied, thanks.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo[at]vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com