Mailing List Archive: Linux: Kernel

[PATCH -tip] perf_counter tools: shorten names for events

1 2

View All

Index | Next | Previous | View Threaded

mingo at elte

Jun 25, 2009, 8:34 AM

Post #26 of 30 (193 views)
Permalink

Re: [PATCH -tip] perf_counter tools: shorten names for events [In reply to]

* Roland Dreier <rdreier [at] cisco> wrote:

> > 266590464 L1d-loads (scaled from 23.03%)
>
> IMHO "L1d" is too abbreviated for it to be obvious that it means
> L1 data cache. If you want something really short maybe "L1-d$"
> might be a little clearer, but I stil like "L1-dcache" best.

i changed it to L1-d$ / L1-i$.

> The formatting of aligning things is nice defitely but we could
> also shorten lines by saying "scaled from" in fewer characters
> maybe? (I have to admit I don't know what "scaled from X%" means
> in this case so I can't suggest something better, but the fact
> that I can't easily tell what it means probably suggests that the
> wording could be improved)

Indeed, the '(scaled from 12.3%)' message should i guess be changed
to:

(9.43x scaled)

( and a multiplicative factor is more expressive anyway, than the
percentage of from where we scale up. )

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

jaswinder at kernel

Jun 26, 2009, 9:06 AM

Post #27 of 30 (193 views)
Permalink

Re: [PATCH -tip] perf_counter tools: shorten names for events [In reply to]

On Thu, 2009-06-25 at 17:34 +0200, Ingo Molnar wrote:
> * Roland Dreier <rdreier [at] cisco> wrote:
>
> > > 266590464 L1d-loads (scaled from 23.03%)
> >
> > IMHO "L1d" is too abbreviated for it to be obvious that it means
> > L1 data cache. If you want something really short maybe "L1-d$"
> > might be a little clearer, but I stil like "L1-dcache" best.
>
> i changed it to L1-d$ / L1-i$.
>
> > The formatting of aligning things is nice defitely but we could
> > also shorten lines by saying "scaled from" in fewer characters
> > maybe? (I have to admit I don't know what "scaled from X%" means
> > in this case so I can't suggest something better, but the fact
> > that I can't easily tell what it means probably suggests that the
> > wording could be improved)
>
> Indeed, the '(scaled from 12.3%)' message should i guess be changed
> to:
>
> (9.43x scaled)
>
> ( and a multiplicative factor is more expressive anyway, than the
> percentage of from where we scale up. )
>

Can you please let me know how you get 9.43x from 12.3%

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

mingo at elte

Jun 26, 2009, 11:47 AM

Post #28 of 30 (192 views)
Permalink

Re: [PATCH -tip] perf_counter tools: shorten names for events [In reply to]

* Jaswinder Singh Rajput <jaswinder [at] kernel> wrote:

> On Thu, 2009-06-25 at 17:34 +0200, Ingo Molnar wrote:
> > * Roland Dreier <rdreier [at] cisco> wrote:
> >
> > > > 266590464 L1d-loads (scaled from 23.03%)
> > >
> > > IMHO "L1d" is too abbreviated for it to be obvious that it means
> > > L1 data cache. If you want something really short maybe "L1-d$"
> > > might be a little clearer, but I stil like "L1-dcache" best.
> >
> > i changed it to L1-d$ / L1-i$.
> >
> > > The formatting of aligning things is nice defitely but we could
> > > also shorten lines by saying "scaled from" in fewer characters
> > > maybe? (I have to admit I don't know what "scaled from X%" means
> > > in this case so I can't suggest something better, but the fact
> > > that I can't easily tell what it means probably suggests that the
> > > wording could be improved)
> >
> > Indeed, the '(scaled from 12.3%)' message should i guess be changed
> > to:
> >
> > (9.43x scaled)
> >
> > ( and a multiplicative factor is more expressive anyway, than the
> > percentage of from where we scale up. )
> >
>
> Can you please let me know how you get 9.43x from 12.3%

it was a guesstimate - the real factor is 8.13x

from X percentage scaling factor you get to the multiplier factor by
doing:

100.0 / X

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

anton at samba

Jul 4, 2009, 5:25 PM

Post #29 of 30 (175 views)
Permalink

Re: [PATCH -tip] perf_counter tools: shorten names for events [In reply to]

Hi,

> IMHO "L1d" is too abbreviated for it to be obvious that it means L1 data
> cache. If you want something really short maybe "L1-d$" might be a
> little clearer, but I stil like "L1-dcache" best.

There's one problem with L1-d$-* for event names. It took me a few goes
before I realised I was being hit by bash variable expansion:

# perf stat -e L1-d$-loads ls

usage: perf stat [<options>] <command>

...

# perf stat -e 'L1-d$-loads' ls

Performance counter stats for 'ls':

1273291 L1-d$-loads

0.004434037 seconds time elapsed

I also prefer the more verbose L1-dcache-* names, and since we support
aliases its mostly a matter of screen real estate when printing out the
statistics.

Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

mingo at elte

Jul 4, 2009, 5:32 PM

Post #30 of 30 (174 views)
Permalink

Re: [PATCH -tip] perf_counter tools: shorten names for events [In reply to]

* Anton Blanchard <anton [at] samba> wrote:

>
> Hi,
>
> > IMHO "L1d" is too abbreviated for it to be obvious that it means L1 data
> > cache. If you want something really short maybe "L1-d$" might be a
> > little clearer, but I stil like "L1-dcache" best.
>
> There's one problem with L1-d$-* for event names. It took me a few goes
> before I realised I was being hit by bash variable expansion:
>
>
> # perf stat -e L1-d$-loads ls
>
> usage: perf stat [<options>] <command>
>
> ...
>
>
> # perf stat -e 'L1-d$-loads' ls
>
> Performance counter stats for 'ls':
>
> 1273291 L1-d$-loads
>
> 0.004434037 seconds time elapsed
>
>
> I also prefer the more verbose L1-dcache-* names, and since we
> support aliases its mostly a matter of screen real estate when
> printing out the statistics.

ok - mind sending a patch for this?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo [at] vger
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

1 2

View All

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads