Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: ivtv: devel

[PATCH] cx18: Read buffer overflow



ivtv devel RSS feed   Index | Next | Previous | View Threaded

roel.kluin at gmail

Jul 29, 2009, 6:35 AM

Post #1 of 1 (1899 views)
[PATCH] cx18: Read buffer overflow

The guard mistakenly tests against sizeof(freqs) instead of ARRAY_SIZE(freqs).

Signed-off-by: Roel Kluin <roel.kluin [at] gmail>
Andy Walls wrote:

> The cx18 driver suffers from the exact same defect in cx18-controls.c.

Thanks, if not already applied, here is it.

diff --git a/drivers/media/video/ivtv/ivtv-controls.c b/drivers/media/video/ivtv/ivtv-controls.c
index a3b77ed..4a9c8ce 100644
--- a/drivers/media/video/ivtv/ivtv-controls.c
+++ b/drivers/media/video/ivtv/ivtv-controls.c
@@ -17,6 +17,7 @@
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+#include <linux/kernel.h>

#include "ivtv-driver.h"
#include "ivtv-cards.h"
@@ -281,7 +282,7 @@ int ivtv_s_ext_ctrls(struct file *file, void *fh, struct v4l2_ext_controls *c)
idx = p.audio_properties & 0x03;
/* The audio clock of the digitizer must match the codec sample
rate otherwise you get some very strange effects. */
- if (idx < sizeof(freqs))
+ if (idx < ARRAY_SIZE(freqs))
ivtv_call_all(itv, audio, s_clock_freq, freqs[idx]);
return err;

ivtv-devel mailing list
ivtv-devel [at] ivtvdriver

ivtv devel RSS feed   Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.