Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: ivtv: devel

default ctrls values not standard values?

 

 

ivtv devel RSS feed   Index | Next | Previous | View Threaded


md001 at gmx

Jul 14, 2008, 2:43 AM

Post #1 of 2 (1484 views)
Permalink
default ctrls values not standard values?

I noticed that the ivtv driver uses some values that are different from the
default settings. After loading ivtv v4l2-ctl --list-ctrls-menus says:

spatial_luma_filter_type (menu) : min=0 max=4 default=0 value=1
0: Off
1: 1D Horizontal
2: 1D Vertical
3: 2D H/V Separable
4: 2D Symmetric non-separable
spatial_chroma_filter_type (menu) : min=0 max=1 default=0 value=1
0: Off
1: 1D Horizontal
temporal_filter_mode (menu) : min=0 max=1 default=0 value=0
flags=update
0: Manual
1: Auto
temporal_filter (int) : min=0 max=31 step=1 default=0 value=8
flags=slider


For the pvrinput vdr-plugin, we are currently detecting the default_value by
using struct v4l2_queryctrl . Unless the user does not set other values,
those detected values are used for initialising the card.

At least in the three cases above, this leads to other values than the driver
would have used by itself.

I always thougt that the default values come from c2341x, but the pvrusb2
driver gives other default values:
video_aspect (menu) : min=0 max=3 default=0 value=1
video_gop_closure (bool) : default=0 value=1
audio_sampling_frequency (menu) : min=0 max=2 default=0 value=1
audio_encoding_layer (menu) : min=0 max=2 default=0 value=1 flags=update
audio_layer_ii_bitrate (menu) : min=0 max=13 default=0 value=10

Obviously the card driver has its own default values, but uses
different "standard" values after loading. So what is the sense of a default
value if the driver sets another value by default?

I wonder if I should use the current value given by v4l2_ext_control instead
of the default values. But this values may have been changed by an
application after loading the driver. So it can be used to reset settings.

Is there any way to detect the "standard" value without reloading the driver
and immidiately call its current values?

_______________________________________________
ivtv-devel mailing list
ivtv-devel [at] ivtvdriver
http://ivtvdriver.org/mailman/listinfo/ivtv-devel


hverkuil at xs4all

Jul 14, 2008, 3:08 AM

Post #2 of 2 (1364 views)
Permalink
Re: default ctrls values not standard values? [In reply to]

On Monday 14 July 2008 11:43:55 Martin Dauskardt wrote:
> I noticed that the ivtv driver uses some values that are different
> from the default settings. After loading ivtv v4l2-ctl
> --list-ctrls-menus says:
>
> spatial_luma_filter_type (menu) : min=0 max=4 default=0
> value=1 0: Off
> 1: 1D Horizontal
> 2: 1D Vertical
> 3: 2D H/V Separable
> 4: 2D Symmetric non-separable
> spatial_chroma_filter_type (menu) : min=0 max=1 default=0
> value=1 0: Off
> 1: 1D Horizontal
> temporal_filter_mode (menu) : min=0 max=1 default=0
> value=0 flags=update
> 0: Manual
> 1: Auto
> temporal_filter (int) : min=0 max=31 step=1
> default=0 value=8 flags=slider
>
>
> For the pvrinput vdr-plugin, we are currently detecting the
> default_value by using struct v4l2_queryctrl . Unless the user does
> not set other values, those detected values are used for initialising
> the card.
>
> At least in the three cases above, this leads to other values than
> the driver would have used by itself.

It's definitely a cx2341x bug. The defaults do not match the actual
defaults as cx2341x sets them up initially. Thanks for the report, I'll
fix this in the v4l-dvb tree.

> I always thougt that the default values come from c2341x, but the
> pvrusb2 driver gives other default values:
> video_aspect (menu) : min=0 max=3 default=0 value=1
> video_gop_closure (bool) : default=0 value=1
> audio_sampling_frequency (menu) : min=0 max=2 default=0 value=1
> audio_encoding_layer (menu) : min=0 max=2 default=0 value=1
> flags=update audio_layer_ii_bitrate (menu) : min=0 max=13 default=0
> value=10

This might well be a pvrusb2 bug. I'll take a look at this as well and I
might forward this message to the pvrusb2 mailinglist if it is indeed a
pvrusb2 bug.

> Obviously the card driver has its own default values, but uses
> different "standard" values after loading. So what is the sense of a
> default value if the driver sets another value by default?

None whatsoever :-)

> I wonder if I should use the current value given by v4l2_ext_control
> instead of the default values. But this values may have been changed
> by an application after loading the driver. So it can be used to
> reset settings.
>
> Is there any way to detect the "standard" value without reloading the
> driver and immidiately call its current values?

Not really. It's a true bug. Sorry.

Regards,

Hans

_______________________________________________
ivtv-devel mailing list
ivtv-devel [at] ivtvdriver
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

ivtv devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.