Mailing List Archive: ivtv: devel

[PATCH] fix radio for ivtv in current HG

Index | Next | Previous | View Threaded

jareguero at telefonica

Dec 29, 2007, 1:53 PM

Post #1 of 7 (3444 views)
Permalink

[PATCH] fix radio for ivtv in current HG

This patch fix radio for ivtv in current HG.

Jose Alberto

Attachments:

tuner_core.patch (0.46 KB)

mike at krufky

Dec 29, 2007, 2:01 PM

Post #2 of 7 (3311 views)
Permalink

Re: [PATCH] fix radio for ivtv in current HG [In reply to]

Jose Alberto Reguero wrote:
> This patch fix radio for ivtv in current HG.
>
> Jose Alberto

Jose,

Yikes, another reverse NULL pointer check. Thanks for this bug fix....

Regards,

Mike Krufky

_______________________________________________
ivtv-devel mailing list
ivtv-devel [at] ivtvdriver
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

mkrufky at linuxtv

Dec 29, 2007, 2:06 PM

Post #3 of 7 (3323 views)
Permalink

Re: [PATCH] fix radio for ivtv in current HG [In reply to]

Michael Krufky wrote:
> Jose Alberto Reguero wrote:
>> This patch fix radio for ivtv in current HG.
>>
>> Jose Alberto
>
> Jose,
>
> Yikes, another reverse NULL pointer check. Thanks for this bug fix....

Jose,

Please send me your sign-off, so that I may include it in the patch as this is pushed into the repository.

Please use the form:

Signed-off-by: Your Name <email [at] addre>

Cheers,

Mike

_______________________________________________
ivtv-devel mailing list
ivtv-devel [at] ivtvdriver
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

jareguero at telefonica

Jan 10, 2008, 1:00 PM

Post #4 of 7 (3232 views)
Permalink

Re: [PATCH] fix radio for ivtv in current HG [In reply to]

El Miércoles, 9 de Enero de 2008, Jose Alberto Reguero escribió:
> El Martes, 8 de Enero de 2008, Jose Alberto Reguero escribió:
> > El Martes, 8 de Enero de 2008, mkrufky [at] linuxtv escribió:
> > > Jose Alberto Reguero wrote:
> > > > If I left the minimal atached patch, and without debug options, I
> > > > have no problems.
> > > > Maybe the driver needs a delay in somwhere?
> > > >
> > > > [snip]
> > > > AFC Status: 2
> > > > AFC Status: 2
> > > > AFC Status: 2
> > > > AFC Status: -1
> > > > AFC Status: 2
> > > > AFC Status: 2
> > > > [snip]
> > >
> > > Jose,
> > >
> > > What tuner do you have on your card? This behavior is strange.
> > >
> > > -Mike
> > >
> > >From logs
> >
> > tveeprom 1-0050: tuner model is Philips FM1216 ME MK3 (idx 57, type 38)
> > tveeprom 1-0050: TV standards PAL(B/G) PAL(I) SECAM(L/L') PAL(D/D1/K)
> > (eeprom 0x74)
> > tveeprom 1-0050: audio processor is MSP4418 (idx 25)
> >
> > msp3400 1-0040: MSP4418G-B3 found @ 0x80 (ivtv i2c driver #0)
> > msp3400 1-0040: MSP4418G-B3 supports nicam and radio, mode is autodetect
> > and autoselect
> >
> > tda9887 1-0043: tda988[5/6/7] found
> >
> > tuner-simple 1-0061: type set to 38 (Philips PAL/SECAM multi (FM1216ME
> > MK3))
> >
> > Thanks.
> > Jose Alberto
>
> With the attached patch and works well without debug options.
> With udelay(1), don't work.
>
> Jose Alberto

I found a solution in the ivtv driver with this hack.

diff -r e57736b60075 linux/drivers/media/video/ivtv/ivtv-driver.c
--- a/linux/drivers/media/video/ivtv/ivtv-driver.c Wed Jan 02 13:50:02
2008 -0200
+++ b/linux/drivers/media/video/ivtv/ivtv-driver.c Thu Jan 10 21:39:41
2008 +0100
@@ -1078,8 +1078,10 @@ static int __devinit ivtv_probe(struct p
}

/* The mspx4xx chips need a longer delay for some reason */
+#if 0
if (!(itv->hw_flags & IVTV_HW_MSP34XX))
itv->i2c_algo.udelay = 5;
+#endif

if (itv->std == 0) {
itv->std = V4L2_STD_NTSC_M;

My card is:
ivtv0: Initialized card #0: Hauppauge WinTV PVR-350
ivtv: End initialization
ACPI: PCI interrupt for device 0000:07:09.0 disabled
ivtv0: Removed Hauppauge WinTV PVR-350, card #0
ivtv: Start initialization, version 1.2.0
ivtv0: Initializing card #0
ivtv0: Autodetected Hauppauge card (cx23415 based)
ACPI: PCI Interrupt 0000:07:09.0[A] -> GSI 19 (level, low) -> IRQ 19
tveeprom 1-0050: Hauppauge model 48139, rev K257, serial# 7671399
tveeprom 1-0050: tuner model is Philips FM1216 ME MK3 (idx 57, type 38)
tveeprom 1-0050: TV standards PAL(B/G) PAL(I) SECAM(L/L') PAL(D/D1/K) (eeprom
0x74)
tveeprom 1-0050: audio processor is MSP4418 (idx 25)
tveeprom 1-0050: decoder processor is SAA7115 (idx 19)
tveeprom 1-0050: has radio, has IR receiver, has no IR transmitter
ivtv0: Autodetected Hauppauge WinTV PVR-350
saa7115 1-0021: saa7115 found (1f7115d0e100000) @ 0x42 (ivtv i2c driver #0)
saa7127 1-0044: saa7129 found @ 0x88 (ivtv i2c driver #0)
msp3400 1-0040: MSP4418G-B3 found @ 0x80 (ivtv i2c driver #0)
msp3400 1-0040: MSP4418G-B3 supports nicam and radio, mode is autodetect and
autoselect
tuner 1-0043: chip found @ 0x86 (ivtv i2c driver #0)
tda9887 1-0043: tda988[5/6/7] found
tuner 1-0061: chip found @ 0xc2 (ivtv i2c driver #0)
tuner-simple 1-0061: type set to 38 (Philips PAL/SECAM multi (FM1216ME MK3))
ivtv0: Registered device video1 for encoder MPG (4096 kB)
ivtv0: Registered device video33 for encoder YUV (2048 kB)
ivtv0: Registered device vbi1 for encoder VBI (1024 kB)
ivtv0: Registered device video25 for encoder PCM (320 kB)
ivtv0: Registered device radio1 for encoder radio
ivtv0: Registered device video17 for decoder MPG (1024 kB)
ivtv0: Registered device vbi9 for decoder VBI (64 kB)
ivtv0: Registered device vbi17 for decoder VOUT
ivtv0: Registered device video49 for decoder YUV (1024 kB)
ivtv0: Initialized card #0: Hauppauge WinTV PVR-350
ivtv: End initialization

Jose Alberto

_______________________________________________
ivtv-devel mailing list
ivtv-devel [at] ivtvdriver
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

hverkuil at xs4all

Jan 10, 2008, 1:38 PM

Post #5 of 7 (3246 views)
Permalink

Re: [PATCH] fix radio for ivtv in current HG [In reply to]

On Thursday 10 January 2008 22:00:36 Jose Alberto Reguero wrote:
> El Miércoles, 9 de Enero de 2008, Jose Alberto Reguero escribió:
> > El Martes, 8 de Enero de 2008, Jose Alberto Reguero escribió:
> > > El Martes, 8 de Enero de 2008, mkrufky [at] linuxtv escribió:
> > > > Jose Alberto Reguero wrote:
> > > > > If I left the minimal atached patch, and without debug
> > > > > options, I have no problems.
> > > > > Maybe the driver needs a delay in somwhere?
> > > > >
> > > > > [snip]
> > > > > AFC Status: 2
> > > > > AFC Status: 2
> > > > > AFC Status: 2
> > > > > AFC Status: -1
> > > > > AFC Status: 2
> > > > > AFC Status: 2
> > > > > [snip]
> > > >
> > > > Jose,
> > > >
> > > > What tuner do you have on your card? This behavior is strange.
> > > >
> > > > -Mike
> > > >
> > > >From logs
> > >
> > > tveeprom 1-0050: tuner model is Philips FM1216 ME MK3 (idx 57,
> > > type 38) tveeprom 1-0050: TV standards PAL(B/G) PAL(I)
> > > SECAM(L/L') PAL(D/D1/K) (eeprom 0x74)
> > > tveeprom 1-0050: audio processor is MSP4418 (idx 25)
> > >
> > > msp3400 1-0040: MSP4418G-B3 found @ 0x80 (ivtv i2c driver #0)
> > > msp3400 1-0040: MSP4418G-B3 supports nicam and radio, mode is
> > > autodetect and autoselect
> > >
> > > tda9887 1-0043: tda988[5/6/7] found
> > >
> > > tuner-simple 1-0061: type set to 38 (Philips PAL/SECAM multi
> > > (FM1216ME MK3))
> > >
> > > Thanks.
> > > Jose Alberto
> >
> > With the attached patch and works well without debug options.
> > With udelay(1), don't work.
> >
> > Jose Alberto
>
> I found a solution in the ivtv driver with this hack.
>
> diff -r e57736b60075 linux/drivers/media/video/ivtv/ivtv-driver.c
> --- a/linux/drivers/media/video/ivtv/ivtv-driver.c Wed Jan 02
> 13:50:02 2008 -0200
> +++ b/linux/drivers/media/video/ivtv/ivtv-driver.c Thu Jan 10
> 21:39:41 2008 +0100
> @@ -1078,8 +1078,10 @@ static int __devinit ivtv_probe(struct p
> }
>
> /* The mspx4xx chips need a longer delay for some reason */
> +#if 0
> if (!(itv->hw_flags & IVTV_HW_MSP34XX))
> itv->i2c_algo.udelay = 5;
> +#endif
>
> if (itv->std == 0) {
> itv->std = V4L2_STD_NTSC_M;

I'm going to remove the udelay = 5 altogether. I'll just stick to the
old value of 10. The value of 5 should be fine theoretically, but in
practice there seem to be issues for some people so I'm giving up on
it.

Regards,

Hans

>
> My card is:
> ivtv0: Initialized card #0: Hauppauge WinTV PVR-350
> ivtv: End initialization
> ACPI: PCI interrupt for device 0000:07:09.0 disabled
> ivtv0: Removed Hauppauge WinTV PVR-350, card #0
> ivtv: Start initialization, version 1.2.0
> ivtv0: Initializing card #0
> ivtv0: Autodetected Hauppauge card (cx23415 based)
> ACPI: PCI Interrupt 0000:07:09.0[A] -> GSI 19 (level, low) -> IRQ 19
> tveeprom 1-0050: Hauppauge model 48139, rev K257, serial# 7671399
> tveeprom 1-0050: tuner model is Philips FM1216 ME MK3 (idx 57, type
> 38) tveeprom 1-0050: TV standards PAL(B/G) PAL(I) SECAM(L/L')
> PAL(D/D1/K) (eeprom 0x74)
> tveeprom 1-0050: audio processor is MSP4418 (idx 25)
> tveeprom 1-0050: decoder processor is SAA7115 (idx 19)
> tveeprom 1-0050: has radio, has IR receiver, has no IR transmitter
> ivtv0: Autodetected Hauppauge WinTV PVR-350
> saa7115 1-0021: saa7115 found (1f7115d0e100000) @ 0x42 (ivtv i2c
> driver #0) saa7127 1-0044: saa7129 found @ 0x88 (ivtv i2c driver #0)
> msp3400 1-0040: MSP4418G-B3 found @ 0x80 (ivtv i2c driver #0)
> msp3400 1-0040: MSP4418G-B3 supports nicam and radio, mode is
> autodetect and autoselect
> tuner 1-0043: chip found @ 0x86 (ivtv i2c driver #0)
> tda9887 1-0043: tda988[5/6/7] found
> tuner 1-0061: chip found @ 0xc2 (ivtv i2c driver #0)
> tuner-simple 1-0061: type set to 38 (Philips PAL/SECAM multi
> (FM1216ME MK3)) ivtv0: Registered device video1 for encoder MPG (4096
> kB)
> ivtv0: Registered device video33 for encoder YUV (2048 kB)
> ivtv0: Registered device vbi1 for encoder VBI (1024 kB)
> ivtv0: Registered device video25 for encoder PCM (320 kB)
> ivtv0: Registered device radio1 for encoder radio
> ivtv0: Registered device video17 for decoder MPG (1024 kB)
> ivtv0: Registered device vbi9 for decoder VBI (64 kB)
> ivtv0: Registered device vbi17 for decoder VOUT
> ivtv0: Registered device video49 for decoder YUV (1024 kB)
> ivtv0: Initialized card #0: Hauppauge WinTV PVR-350
> ivtv: End initialization
>
> Jose Alberto
>
> --
> video4linux-list mailing list
> Unsubscribe
> mailto:video4linux-list-request [at] redhat?subject=unsubscribe
> https://www.redhat.com/mailman/listinfo/video4linux-list

_______________________________________________
ivtv-devel mailing list
ivtv-devel [at] ivtvdriver
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

hverkuil at xs4all

Jan 10, 2008, 2:02 PM

Post #6 of 7 (3249 views)
Permalink

Re: [PATCH] fix radio for ivtv in current HG [In reply to]

On Thursday 10 January 2008 22:00:36 Jose Alberto Reguero wrote:
> El Miércoles, 9 de Enero de 2008, Jose Alberto Reguero escribió:
> > El Martes, 8 de Enero de 2008, Jose Alberto Reguero escribió:
> > > El Martes, 8 de Enero de 2008, mkrufky [at] linuxtv escribió:
> > > > Jose Alberto Reguero wrote:
> > > > > If I left the minimal atached patch, and without debug
> > > > > options, I have no problems.
> > > > > Maybe the driver needs a delay in somwhere?
> > > > >
> > > > > [snip]
> > > > > AFC Status: 2
> > > > > AFC Status: 2
> > > > > AFC Status: 2
> > > > > AFC Status: -1
> > > > > AFC Status: 2
> > > > > AFC Status: 2
> > > > > [snip]
> > > >
> > > > Jose,
> > > >
> > > > What tuner do you have on your card? This behavior is strange.
> > > >
> > > > -Mike
> > > >
> > > >From logs
> > >
> > > tveeprom 1-0050: tuner model is Philips FM1216 ME MK3 (idx 57,
> > > type 38) tveeprom 1-0050: TV standards PAL(B/G) PAL(I)
> > > SECAM(L/L') PAL(D/D1/K) (eeprom 0x74)
> > > tveeprom 1-0050: audio processor is MSP4418 (idx 25)
> > >
> > > msp3400 1-0040: MSP4418G-B3 found @ 0x80 (ivtv i2c driver #0)
> > > msp3400 1-0040: MSP4418G-B3 supports nicam and radio, mode is
> > > autodetect and autoselect
> > >
> > > tda9887 1-0043: tda988[5/6/7] found
> > >
> > > tuner-simple 1-0061: type set to 38 (Philips PAL/SECAM multi
> > > (FM1216ME MK3))
> > >
> > > Thanks.
> > > Jose Alberto
> >
> > With the attached patch and works well without debug options.
> > With udelay(1), don't work.
> >
> > Jose Alberto
>
> I found a solution in the ivtv driver with this hack.
>
> diff -r e57736b60075 linux/drivers/media/video/ivtv/ivtv-driver.c
> --- a/linux/drivers/media/video/ivtv/ivtv-driver.c Wed Jan 02
> 13:50:02 2008 -0200
> +++ b/linux/drivers/media/video/ivtv/ivtv-driver.c Thu Jan 10
> 21:39:41 2008 +0100
> @@ -1078,8 +1078,10 @@ static int __devinit ivtv_probe(struct p
> }
>
> /* The mspx4xx chips need a longer delay for some reason */
> +#if 0
> if (!(itv->hw_flags & IVTV_HW_MSP34XX))
> itv->i2c_algo.udelay = 5;
> +#endif
>
> if (itv->std == 0) {
> itv->std = V4L2_STD_NTSC_M;

Jose,

For my information: which linux kernel version are you using?

Regards,

Hans

>
> My card is:
> ivtv0: Initialized card #0: Hauppauge WinTV PVR-350
> ivtv: End initialization
> ACPI: PCI interrupt for device 0000:07:09.0 disabled
> ivtv0: Removed Hauppauge WinTV PVR-350, card #0
> ivtv: Start initialization, version 1.2.0
> ivtv0: Initializing card #0
> ivtv0: Autodetected Hauppauge card (cx23415 based)
> ACPI: PCI Interrupt 0000:07:09.0[A] -> GSI 19 (level, low) -> IRQ 19
> tveeprom 1-0050: Hauppauge model 48139, rev K257, serial# 7671399
> tveeprom 1-0050: tuner model is Philips FM1216 ME MK3 (idx 57, type
> 38) tveeprom 1-0050: TV standards PAL(B/G) PAL(I) SECAM(L/L')
> PAL(D/D1/K) (eeprom 0x74)
> tveeprom 1-0050: audio processor is MSP4418 (idx 25)
> tveeprom 1-0050: decoder processor is SAA7115 (idx 19)
> tveeprom 1-0050: has radio, has IR receiver, has no IR transmitter
> ivtv0: Autodetected Hauppauge WinTV PVR-350
> saa7115 1-0021: saa7115 found (1f7115d0e100000) @ 0x42 (ivtv i2c
> driver #0) saa7127 1-0044: saa7129 found @ 0x88 (ivtv i2c driver #0)
> msp3400 1-0040: MSP4418G-B3 found @ 0x80 (ivtv i2c driver #0)
> msp3400 1-0040: MSP4418G-B3 supports nicam and radio, mode is
> autodetect and autoselect
> tuner 1-0043: chip found @ 0x86 (ivtv i2c driver #0)
> tda9887 1-0043: tda988[5/6/7] found
> tuner 1-0061: chip found @ 0xc2 (ivtv i2c driver #0)
> tuner-simple 1-0061: type set to 38 (Philips PAL/SECAM multi
> (FM1216ME MK3)) ivtv0: Registered device video1 for encoder MPG (4096
> kB)
> ivtv0: Registered device video33 for encoder YUV (2048 kB)
> ivtv0: Registered device vbi1 for encoder VBI (1024 kB)
> ivtv0: Registered device video25 for encoder PCM (320 kB)
> ivtv0: Registered device radio1 for encoder radio
> ivtv0: Registered device video17 for decoder MPG (1024 kB)
> ivtv0: Registered device vbi9 for decoder VBI (64 kB)
> ivtv0: Registered device vbi17 for decoder VOUT
> ivtv0: Registered device video49 for decoder YUV (1024 kB)
> ivtv0: Initialized card #0: Hauppauge WinTV PVR-350
> ivtv: End initialization
>
> Jose Alberto
>
> --
> video4linux-list mailing list
> Unsubscribe
> mailto:video4linux-list-request [at] redhat?subject=unsubscribe
> https://www.redhat.com/mailman/listinfo/video4linux-list

_______________________________________________
ivtv-devel mailing list
ivtv-devel [at] ivtvdriver
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

jareguero at telefonica

Jan 10, 2008, 2:22 PM

Post #7 of 7 (3223 views)
Permalink

Re: [PATCH] fix radio for ivtv in current HG [In reply to]

El Jueves, 10 de Enero de 2008, Hans Verkuil escribió:
> On Thursday 10 January 2008 22:00:36 Jose Alberto Reguero wrote:
> > El Miércoles, 9 de Enero de 2008, Jose Alberto Reguero escribió:
> > > El Martes, 8 de Enero de 2008, Jose Alberto Reguero escribió:
> > > > El Martes, 8 de Enero de 2008, mkrufky [at] linuxtv escribió:
> > > > > Jose Alberto Reguero wrote:
> > > > > > If I left the minimal atached patch, and without debug
> > > > > > options, I have no problems.
> > > > > > Maybe the driver needs a delay in somwhere?
> > > > > >
> > > > > > [snip]
> > > > > > AFC Status: 2
> > > > > > AFC Status: 2
> > > > > > AFC Status: 2
> > > > > > AFC Status: -1
> > > > > > AFC Status: 2
> > > > > > AFC Status: 2
> > > > > > [snip]
> > > > >
> > > > > Jose,
> > > > >
> > > > > What tuner do you have on your card? This behavior is strange.
> > > > >
> > > > > -Mike
> > > > >
> > > > >From logs
> > > >
> > > > tveeprom 1-0050: tuner model is Philips FM1216 ME MK3 (idx 57,
> > > > type 38) tveeprom 1-0050: TV standards PAL(B/G) PAL(I)
> > > > SECAM(L/L') PAL(D/D1/K) (eeprom 0x74)
> > > > tveeprom 1-0050: audio processor is MSP4418 (idx 25)
> > > >
> > > > msp3400 1-0040: MSP4418G-B3 found @ 0x80 (ivtv i2c driver #0)
> > > > msp3400 1-0040: MSP4418G-B3 supports nicam and radio, mode is
> > > > autodetect and autoselect
> > > >
> > > > tda9887 1-0043: tda988[5/6/7] found
> > > >
> > > > tuner-simple 1-0061: type set to 38 (Philips PAL/SECAM multi
> > > > (FM1216ME MK3))
> > > >
> > > > Thanks.
> > > > Jose Alberto
> > >
> > > With the attached patch and works well without debug options.
> > > With udelay(1), don't work.
> > >
> > > Jose Alberto
> >
> > I found a solution in the ivtv driver with this hack.
> >
> > diff -r e57736b60075 linux/drivers/media/video/ivtv/ivtv-driver.c
> > --- a/linux/drivers/media/video/ivtv/ivtv-driver.c Wed Jan 02
> > 13:50:02 2008 -0200
> > +++ b/linux/drivers/media/video/ivtv/ivtv-driver.c Thu Jan 10
> > 21:39:41 2008 +0100
> > @@ -1078,8 +1078,10 @@ static int __devinit ivtv_probe(struct p
> > }
> >
> > /* The mspx4xx chips need a longer delay for some reason */
> > +#if 0
> > if (!(itv->hw_flags & IVTV_HW_MSP34XX))
> > itv->i2c_algo.udelay = 5;
> > +#endif
> >
> > if (itv->std == 0) {
> > itv->std = V4L2_STD_NTSC_M;
>
> Jose,
>
> For my information: which linux kernel version are you using?
>
> Regards,
>
> Hans
>

I use 2.6.23 whith current v4l hg.

Jose Alberto

_______________________________________________
ivtv-devel mailing list
ivtv-devel [at] ivtvdriver
http://ivtvdriver.org/mailman/listinfo/ivtv-devel

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads