Mailing List Archive: iptables: Devel

[PATCH][CTNETLINK] return EEXIST instead of EINVAL for existing nat'ed conntracks

Index | Next | Previous | View Threaded

pablo at netfilter

Jul 26, 2007, 6:28 AM

Post #1 of 2 (719 views)
Permalink

[PATCH][CTNETLINK] return EEXIST instead of EINVAL for existing nat'ed conntracks

ctnetlink must return EEXIST for existing nat'ed conntracks instead of
EINVAL. Only return EINVAL if we try to update a conntrack with NAT
handlings (that is not allowed).

Decadence:libnetfilter_conntrack/utils# ./conntrack_create_nat
TEST: create conntrack (0)(Success)
Decadence:libnetfilter_conntrack/utils# ./conntrack_create_nat
TEST: create conntrack (-1)(Invalid argument)

Signed-off-by: Pablo Neira Ayuso <pablo [at] netfilter>

--
"Será preciso viajar a través de los ojos de los idiotas" -- Poeta en
Nueva York -- Federico García Lorca.

Attachments:

x (1.61 KB)

kaber at trash

Jul 30, 2007, 5:34 AM

Post #2 of 2 (652 views)
Permalink

Re: [PATCH][CTNETLINK] return EEXIST instead of EINVAL for existing nat'ed conntracks [In reply to]

Pablo Neira Ayuso wrote:
> ctnetlink must return EEXIST for existing nat'ed conntracks instead of
> EINVAL. Only return EINVAL if we try to update a conntrack with NAT
> handlings (that is not allowed).

Applied, thanks Pablo.

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads