Mailing List Archive: GnuPG: devel

[PATCH] Allow SHA2 hash functions on gnupg 2 with scdaemon

Index | Next | Previous | View Threaded

flameeyes at gmail

Sep 27, 2010, 10:04 AM

Post #1 of 4 (305 views)
Permalink

[PATCH] Allow SHA2 hash functions on gnupg 2 with scdaemon

Hi,

I'm attaching a patch that implement support for the SHA2 hash functions
in GnuPG 2 when using scdaemon.

A similar issue was reported and fixed (although in a different, IMHO
less optimal, way) in early 2010 [1] but the same issue held true for
GnuPG 2.

Without this patch, if ~/.gnupg/gpg.conf contains these lines:

personal-digest-preferences SHA256
cert-digest-algo SHA256
default-preference-list SHA512 SHA384 SHA256 SHA224 AES256 AES192 AES
CAST5 ZLIB BZIP2 ZIP Uncompressed

then a sign action would report this:

gpg: checking created signature failed: Bad signature
gpg: signing failed: Bad signature
gpg: [stdin]: clearsign failed: Bad signature

after applying the patch.. well, this email is signed, I hope :)

As it is, it applies fine over 2.0.16 and svn branch.

HTH,

[1] http://www.gossamer-threads.com/lists/gnupg/users/51293

--
Diego Elio Pettenò — “Flameeyes”
http://blog.flameeyes.eu/

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/

Attachments:

gnupg-2.0.16-opengpgv2-sha2.patch (1.26 KB)

signature.asc (0.48 KB)

wk at gnupg

Sep 28, 2010, 1:22 AM

Post #2 of 4 (288 views)
Permalink

Re: [PATCH] Allow SHA2 hash functions on gnupg 2 with scdaemon [In reply to]

On Mon, 27 Sep 2010 19:04, flameeyes [at] gmail said:

> I'm attaching a patch that implement support for the SHA2 hash functions
> in GnuPG 2 when using scdaemon.

I just commited a similar change.

Thanks,

Werner

--
Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz.

_______________________________________________
Gnupg-devel mailing list
Gnupg-devel [at] gnupg
http://lists.gnupg.org/mailman/listinfo/gnupg-devel

flameeyes at gmail

Sep 28, 2010, 7:25 AM

Post #3 of 4 (287 views)
Permalink

Re: [PATCH] Allow SHA2 hash functions on gnupg 2 with scdaemon [In reply to]

Il giorno mar, 28/09/2010 alle 10.22 +0200, Werner Koch ha scritto:
> I just commited a similar change.
>
Thanks, but it's broken, the original (and my version) had a trailing
whitespace on the --hash parameter strings, your commit doesn't have
those so it ends up mangling the PKSIGN commandline:

scdaemon[32606.7] DBG: <- PKSIGN
--hash=sha256XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
scdaemon[32606.7] DBG: -> ERR 100663576 IPC parameter error <SCD> -
invalid hash algorithm

>
--
Diego Elio Pettenò — “Flameeyes”
http://blog.flameeyes.eu/

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/

_______________________________________________
Gnupg-devel mailing list
Gnupg-devel [at] gnupg
http://lists.gnupg.org/mailman/listinfo/gnupg-devel

wk at gnupg

Sep 29, 2010, 1:36 AM

Post #4 of 4 (288 views)
Permalink

Re: [PATCH] Allow SHA2 hash functions on gnupg 2 with scdaemon [In reply to]

On Tue, 28 Sep 2010 16:25, flameeyes [at] gmail said:

> Thanks, but it's broken, the original (and my version) had a trailing
> whitespace on the --hash parameter strings, your commit doesn't have

Fixed.

Salam-Shalom,

Werner

--
Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz.

_______________________________________________
Gnupg-devel mailing list
Gnupg-devel [at] gnupg
http://lists.gnupg.org/mailman/listinfo/gnupg-devel

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads