Mailing List Archive: GnuPG: devel

[PATCH] - pinentry pinentry-curses.c

Index | Next | Previous | View Threaded

Wyllys.Ingersoll at Sun

Dec 1, 2009, 1:00 PM

Post #1 of 2 (432 views)
Permalink

[PATCH] - pinentry pinentry-curses.c

pinentry-curses.c has a switch statement that looks for
characters like "\t" and "\e", it should use numerical values
for these constants, different compilers intepret the characters
differently which results in unexpected behavior.

Attached is a patch against the source from the pinentry-0.7.6 tarball.

-Wyllys Ingersoll

Attachments:

pinentry-curses.c.patch (0.65 KB)

wk at gnupg

Dec 2, 2009, 12:06 AM

Post #2 of 2 (396 views)
Permalink

Re: [PATCH] - pinentry pinentry-curses.c [In reply to]

Hi!

On Tue, 01 Dec 2009 16:00:40 -0500, Wyllys Ingersoll <Wyllys.Ingersoll [at] Sun> wrote:
> pinentry-curses.c has a switch statement that looks for
> characters like "\t" and "\e", it should use numerical values
> for these constants, different compilers intepret the characters
> differently which results in unexpected behavior.

I agree that \e is a non-standard extension and should be replace.
However \t is a TAB and that is the same on all ASCII based systems.
Right, we don't care about EBCDIC.

Salam-Shalom,

Werner

--
Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz.

_______________________________________________
Gnupg-devel mailing list
Gnupg-devel [at] gnupg
http://lists.gnupg.org/mailman/listinfo/gnupg-devel

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads