Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Gentoo: Dev

prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete

 

 

Gentoo dev RSS feed   Index | Next | Previous | View Threaded


ssuominen at gentoo

Jun 27, 2012, 12:12 PM

Post #1 of 4 (188 views)
Permalink
prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete

The logic in prune_libtool_files is not perfect[1].

If you are updating ebuild for whatever reason and see `find` command to
punt .la files, and replace it with prune_libtool_files then you also
need to build the package (with "every" possible USE flag combination)
to see if --all argument is also needed.

To clarify:

Use `prune_libtool_files --all` instead of plain `prune_libtool_files`
if you don't test the package with the USE flags.

Not going to point anyone with a finger but the accident has already
happened couple of times in tree :P

[1] http://bugs.gentoo.org/421197


mgorny at gentoo

Jun 28, 2012, 1:26 AM

Post #2 of 4 (179 views)
Permalink
Re: prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete [In reply to]

On Wed, 27 Jun 2012 22:12:34 +0300
Samuli Suominen <ssuominen [at] gentoo> wrote:

> The logic in prune_libtool_files is not perfect[1].

Define 'perfect'.

> To clarify:
>
> Use `prune_libtool_files --all` instead of plain
> `prune_libtool_files` if you don't test the package with the USE
> flags.

Sounds like abuse of '--all' to me. It's like calling 'rm -r' for
single file...

> [1] http://bugs.gentoo.org/421197

--
Best regards,
Michał Górny
Attachments: signature.asc (0.31 KB)


pacho at gentoo

Jun 28, 2012, 2:18 PM

Post #3 of 4 (175 views)
Permalink
Re: prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete [In reply to]

El jue, 28-06-2012 a las 10:26 +0200, Michał Górny escribió:
> On Wed, 27 Jun 2012 22:12:34 +0300
> Samuli Suominen <ssuominen [at] gentoo> wrote:
>
> > The logic in prune_libtool_files is not perfect[1].
>
> Define 'perfect'.
>
> > To clarify:
> >
> > Use `prune_libtool_files --all` instead of plain
> > `prune_libtool_files` if you don't test the package with the USE
> > flags.
>
> Sounds like abuse of '--all' to me. It's like calling 'rm -r' for
> single file...
>
> > [1] http://bugs.gentoo.org/421197
>

But we will need to use "--all" in cases like pointed in that bug
report, no? :/
Attachments: signature.asc (0.19 KB)


mgorny at gentoo

Jun 30, 2012, 12:42 AM

Post #4 of 4 (175 views)
Permalink
Re: prune_libtool_files is NOT a direct replacement for, example, find "${D}" -name '*.la' -delete [In reply to]

On Thu, 28 Jun 2012 23:18:56 +0200
Pacho Ramos <pacho [at] gentoo> wrote:

> El jue, 28-06-2012 a las 10:26 +0200, Michał Górny escribió:
> > On Wed, 27 Jun 2012 22:12:34 +0300
> > Samuli Suominen <ssuominen [at] gentoo> wrote:
> >
> > > The logic in prune_libtool_files is not perfect[1].
> >
> > Define 'perfect'.
> >
> > > To clarify:
> > >
> > > Use `prune_libtool_files --all` instead of plain
> > > `prune_libtool_files` if you don't test the package with the USE
> > > flags.
> >
> > Sounds like abuse of '--all' to me. It's like calling 'rm -r' for
> > single file...
> >
> > > [1] http://bugs.gentoo.org/421197
> >
>
> But we will need to use "--all" in cases like pointed in that bug
> report, no? :/

You need to use it if the package passes '-module' to libtool,
and doesn't use plugin loader which uses .la files (ltdl, gmodule).

The main point is that installing _those_ .la files doesn't do any harm
to the system (they can't be linked against). Removing them may (for
example, in ImageMagick).

It's sad that people start running with pitchforks when they see
anything looking like .la without really understanding what it does.
And yes, I already had users removing all *.la files and then
complaining programs no longer work...

--
Best regards,
Michał Górny
Attachments: signature.asc (0.31 KB)

Gentoo dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.