Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Gentoo: Dev

[RFC]flag-o-matic.eclass strip-flags change to support prefix

 

 

Gentoo dev RSS feed   Index | Next | Previous | View Threaded


maksbotan at gentoo

Jun 17, 2012, 5:13 AM

Post #1 of 9 (708 views)
Permalink
[RFC]flag-o-matic.eclass strip-flags change to support prefix

Hi,
During prefix bootstrap i noticed that strip-flags removes -L and -I
flags from *FLAGS while these flags are essential for prefix
bootstrapping. Therefore i propose a fix for strip-flags function to
make it preserve prefix-related flags. I have attached a patch, please
review it. It works for me, but I'm unsure how it will work with
spaces in ${EPREFIX}

Thanks,
Maxim.
Attachments: flag-o-matic.patch (0.36 KB)


jlec at gentoo

Jun 17, 2012, 5:21 AM

Post #2 of 9 (665 views)
Permalink
Re: [RFC]flag-o-matic.eclass strip-flags change to support prefix [In reply to]

On 17.06.2012 14:13, Maxim Koltsov wrote:
> Hi,
> During prefix bootstrap i noticed that strip-flags removes -L and -I
> flags from *FLAGS while these flags are essential for prefix
> bootstrapping. Therefore i propose a fix for strip-flags function to

Is this really necessary? I never experienced any problems which need
this when following the guides. I looks like a hack, because something
else is borked.

> make it preserve prefix-related flags. I have attached a patch, please
> review it. It works for me, but I'm unsure how it will work with
> spaces in ${EPREFIX}

Why not use "use prefix" instead of checking for the variable?
Attachments: signature.asc (0.29 KB)


maksbotan at gentoo

Jun 17, 2012, 6:23 AM

Post #3 of 9 (663 views)
Permalink
Re: [RFC]flag-o-matic.eclass strip-flags change to support prefix [In reply to]

2012/6/17 Justin <jlec [at] gentoo>:
> On 17.06.2012 14:13, Maxim Koltsov wrote:
>> Hi,
>> During prefix bootstrap i noticed that strip-flags removes -L and -I
>> flags from *FLAGS while these flags are essential for prefix
>> bootstrapping. Therefore i propose a fix for strip-flags function to
>
> Is this really necessary? I never experienced any problems which need
> this when following the guides. I looks like a hack, because something
> else is borked.

I've just hit binutils on OpenBSD not finding libdl.so installed in
$EPREFIX/usr/lib/ because of this.
Don't tell me that OpenBSD prefix is unsupported, i'm working on
getting it supported.

>> make it preserve prefix-related flags. I have attached a patch, please
>> review it. It works for me, but I'm unsure how it will work with
>> spaces in ${EPREFIX}
>
> Why not use "use prefix" instead of checking for the variable?
>
>

I didn't know about prefix use flag. I attach the fixed patch.
Attachments: flag-o-matic.patch (0.35 KB)


maksbotan at gentoo

Jun 17, 2012, 6:49 AM

Post #4 of 9 (660 views)
Permalink
Re: [RFC]flag-o-matic.eclass strip-flags change to support prefix [In reply to]

2012/6/17 Richard Yao <ryao [at] gentoo>:
> On 06/17/2012 09:23 AM, Maxim Koltsov wrote:
>> Don't tell me that OpenBSD prefix is unsupported, i'm working on
>> getting it supported.
>
> OpenBSD is listed on the platform matrix, but it has lacked a maintainer
> for quite some time:
>
> http://www.gentoo.org/proj/en/gentoo-alt/prefix/
>
> I am happy to see that you are working on this. If you have questions
> about prefix, feel free to ping me in IRC. :)

Gentoo/OpenBSD was listed in my gentooRoles since the beginning, but i
had no time for it until this summer :)
Thank's for you offer, i will ping you if needed.


jlec at gentoo

Jun 17, 2012, 7:00 AM

Post #5 of 9 (660 views)
Permalink
Re: [RFC]flag-o-matic.eclass strip-flags change to support prefix [In reply to]

On 17.06.2012 15:23, Maxim Koltsov wrote:
> 2012/6/17 Justin <jlec [at] gentoo>:
>> On 17.06.2012 14:13, Maxim Koltsov wrote:
>>> Hi,
>>> During prefix bootstrap i noticed that strip-flags removes -L and -I
>>> flags from *FLAGS while these flags are essential for prefix
>>> bootstrapping. Therefore i propose a fix for strip-flags function to
>>
>> Is this really necessary? I never experienced any problems which need
>> this when following the guides. I looks like a hack, because something
>> else is borked.
>
> I've just hit binutils on OpenBSD not finding libdl.so installed in
> $EPREFIX/usr/lib/ because of this.
> Don't tell me that OpenBSD prefix is unsupported, i'm working on
> getting it supported.
>

I am still not convinced. libdl.so is provided by glibc, at least on my
linux system. And glibc is one of the rare packages which needs to be
provided by the host system instead of being installed in the prefix.

Is there something different on BSD which makes libdl.so appear inside
the prefix?

justin
Attachments: signature.asc (0.29 KB)


grobian at gentoo

Jun 17, 2012, 7:20 AM

Post #6 of 9 (667 views)
Permalink
Re: [RFC]flag-o-matic.eclass strip-flags change to support prefix [In reply to]

On 17-06-2012 16:13:33 +0400, Maxim Koltsov wrote:
> Hi,
> During prefix bootstrap i noticed that strip-flags removes -L and -I
> flags from *FLAGS while these flags are essential for prefix
> bootstrapping. Therefore i propose a fix for strip-flags function to
> make it preserve prefix-related flags. I have attached a patch, please
> review it. It works for me, but I'm unsure how it will work with
> spaces in ${EPREFIX}

https://bugs.gentoo.org/show_bug.cgi?id=414641


--
Fabian Groffen
Gentoo on a different level
Attachments: signature.asc (0.19 KB)


maksbotan at gentoo

Jun 17, 2012, 8:03 AM

Post #7 of 9 (653 views)
Permalink
Re: [RFC]flag-o-matic.eclass strip-flags change to support prefix [In reply to]

2012/6/17 Justin <jlec [at] gentoo>:
> On 17.06.2012 15:23, Maxim Koltsov wrote:
>> 2012/6/17 Justin <jlec [at] gentoo>:
>>> On 17.06.2012 14:13, Maxim Koltsov wrote:
>>>> Hi,
>>>> During prefix bootstrap i noticed that strip-flags removes -L and -I
>>>> flags from *FLAGS while these flags are essential for prefix
>>>> bootstrapping. Therefore i propose a fix for strip-flags function to
>>>
>>> Is this really necessary? I never experienced any problems which need
>>> this when following the guides. I looks like a hack, because something
>>> else is borked.
>>
>> I've just hit binutils on OpenBSD not finding libdl.so installed in
>> $EPREFIX/usr/lib/ because of this.
>> Don't tell me that OpenBSD prefix is unsupported, i'm working on
>> getting it supported.
>>
>
> I am still not convinced. libdl.so is provided by glibc, at least on my
> linux system. And glibc is one of the rare packages which needs to be
> provided by the host system instead of being installed in the prefix.
>
> Is there something different on BSD which makes libdl.so appear inside
> the prefix?

At least on OpenBSD dlopen() is not in libdl.so, but in ld.so itself,
so I have to install dummy libdl.so to ${EPREFIX}/usr/lib.
I think we should use Fabian's solution from the bug, if it does not
cause any unwanted consequences.


mgorny at gentoo

Jun 17, 2012, 8:48 AM

Post #8 of 9 (655 views)
Permalink
Re: [RFC]flag-o-matic.eclass strip-flags change to support prefix [In reply to]

On Sun, 17 Jun 2012 19:03:22 +0400
Maxim Koltsov <maksbotan [at] gentoo> wrote:

> 2012/6/17 Justin <jlec [at] gentoo>:
> > On 17.06.2012 15:23, Maxim Koltsov wrote:
> >> 2012/6/17 Justin <jlec [at] gentoo>:
> >>> On 17.06.2012 14:13, Maxim Koltsov wrote:
> >>>> Hi,
> >>>> During prefix bootstrap i noticed that strip-flags removes -L
> >>>> and -I flags from *FLAGS while these flags are essential for
> >>>> prefix bootstrapping. Therefore i propose a fix for strip-flags
> >>>> function to
> >>>
> >>> Is this really necessary? I never experienced any problems which
> >>> need this when following the guides. I looks like a hack, because
> >>> something else is borked.
> >>
> >> I've just hit binutils on OpenBSD not finding libdl.so installed in
> >> $EPREFIX/usr/lib/ because of this.
> >> Don't tell me that OpenBSD prefix is unsupported, i'm working on
> >> getting it supported.
> >>
> >
> > I am still not convinced. libdl.so is provided by glibc, at least
> > on my linux system. And glibc is one of the rare packages which
> > needs to be provided by the host system instead of being installed
> > in the prefix.
> >
> > Is there something different on BSD which makes libdl.so appear
> > inside the prefix?
>
> At least on OpenBSD dlopen() is not in libdl.so, but in ld.so itself,
> so I have to install dummy libdl.so to ${EPREFIX}/usr/lib.
> I think we should use Fabian's solution from the bug, if it does not
> cause any unwanted consequences.

Shouldn't configure detect that no libdl is necessary?


--
Best regards,
Michał Górny
Attachments: signature.asc (0.31 KB)


maksbotan at gentoo

Jun 17, 2012, 8:57 AM

Post #9 of 9 (656 views)
Permalink
Re: [RFC]flag-o-matic.eclass strip-flags change to support prefix [In reply to]

2012/6/17 Michał Górny <mgorny [at] gentoo>:
> On Sun, 17 Jun 2012 19:03:22 +0400
> Maxim Koltsov <maksbotan [at] gentoo> wrote:
>
>> 2012/6/17 Justin <jlec [at] gentoo>:
>> > On 17.06.2012 15:23, Maxim Koltsov wrote:
>> >> 2012/6/17 Justin <jlec [at] gentoo>:
>> >>> On 17.06.2012 14:13, Maxim Koltsov wrote:
>> >>>> Hi,
>> >>>> During prefix bootstrap i noticed that strip-flags removes -L
>> >>>> and -I flags from *FLAGS while these flags are essential for
>> >>>> prefix bootstrapping. Therefore i propose a fix for strip-flags
>> >>>> function to
>> >>>
>> >>> Is this really necessary? I never experienced any problems which
>> >>> need this when following the guides. I looks like a hack, because
>> >>> something else is borked.
>> >>
>> >> I've just hit binutils on OpenBSD not finding libdl.so installed in
>> >> $EPREFIX/usr/lib/ because of this.
>> >> Don't tell me that OpenBSD prefix is unsupported, i'm working on
>> >> getting it supported.
>> >>
>> >
>> > I am still not convinced. libdl.so is provided by glibc, at least
>> > on my linux system. And glibc is one of the rare packages which
>> > needs to be provided by the host system instead of being installed
>> > in the prefix.
>> >
>> > Is there something different on BSD which makes libdl.so appear
>> > inside the prefix?
>>
>> At least on OpenBSD dlopen() is not in libdl.so, but in ld.so itself,
>> so I have to install dummy libdl.so to ${EPREFIX}/usr/lib.
>> I think we should use Fabian's solution from the bug, if it does not
>> cause any unwanted consequences.
>
> Shouldn't configure detect that no libdl is necessary?

Should, but eclass does the bad thing anyway.

>
> --
> Best regards,
> Michał Górny

Gentoo dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.