dirtyepic at gentoo
Apr 26, 2012, 10:19 PM
On Thu, 26 Apr 2012 17:06:45 -0300
Re: [gentoo-commits] gentoo-x86 commit in www-plugins/adobe-flash: metadata.xml adobe-flash-22.214.171.124.ebuild ChangeLog
[In reply to]
Alexis Ballier <aballier [at] gentoo> wrote:
> On Thu, 26 Apr 2012 15:15:34 -0400
> Matt Turner <mattst88 [at] gentoo> wrote:
> > On Thu, Apr 26, 2012 at 1:01 PM, Christian Ruppert <idl0r [at] gentoo>
> > wrote:
> > > I haven't followed the prev. conversation but what's wrong with a
> > > USE flag for SSE2? We already have SSE2 flags, even global..
> > That's not it. The flash binary uses SSE2 instructions without
> > checking for their presence, which causes bad things on systems
> > without SSE2. The purpose of the 'sse2check' flag was to die if the
> > system doesn't have SSE2 and print a message telling the user to use
> > an older version of flash.
> > The relevant bug is https://bugs.gentoo.org/show_bug.cgi?id=410547
> wouldnt adding a sse2 useflag and putting it in REQUIRED_USE solve the
> problem ?
> afaik portage wont even try to upgrade if people have -sse2
I like that, but it doesn't address building on a host not supporting SSE2 for
a target that does. That's the reason the USE flag was added - to provide a
workaround for the die. I'm saying just don't die at all. It doesn't
provide anything but another way for the ebuild to fail. An ewarn for the
very few people that will actually encounter this should be enough.