Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Gentoo: Dev

About validate_desktop_entries in eutils.eclass

 

 

Gentoo dev RSS feed   Index | Next | Previous | View Threaded


pacho at gentoo

Apr 15, 2012, 2:59 AM

Post #1 of 8 (756 views)
Permalink
About validate_desktop_entries in eutils.eclass

Hello

I am unsure about validate_desktop_entries() utility. It's currently
provided by eutils.eclass and only called by net-firewall/fwbuilder.
Shouldn't this be moved to a "qa" check? Current way is pretty useless
as it's not used by most of packages, and calling it from a lot of
eclasses/ebuilds doesn't sound me like a good idea.

What do you think?
Attachments: signature.asc (0.19 KB)


ssuominen at gentoo

Apr 15, 2012, 3:20 AM

Post #2 of 8 (730 views)
Permalink
Re: About validate_desktop_entries in eutils.eclass [In reply to]

On 04/15/2012 12:59 PM, Pacho Ramos wrote:
> Hello
>
> I am unsure about validate_desktop_entries() utility. It's currently
> provided by eutils.eclass and only called by net-firewall/fwbuilder.

and xfconf.eclass :)

> Shouldn't this be moved to a "qa" check? Current way is pretty useless
> as it's not used by most of packages, and calling it from a lot of
> eclasses/ebuilds doesn't sound me like a good idea.
>
> What do you think?

+1 for making it more easily available


mgorny at gentoo

Apr 15, 2012, 7:02 AM

Post #3 of 8 (730 views)
Permalink
Re: About validate_desktop_entries in eutils.eclass [In reply to]

On Sun, 15 Apr 2012 11:59:50 +0200
Pacho Ramos <pacho [at] gentoo> wrote:

> I am unsure about validate_desktop_entries() utility. It's currently
> provided by eutils.eclass and only called by net-firewall/fwbuilder.
> Shouldn't this be moved to a "qa" check? Current way is pretty useless
> as it's not used by most of packages, and calling it from a lot of
> eclasses/ebuilds doesn't sound me like a good idea.
>
> What do you think?

Agreed. It should be in repoman.

--
Best regards,
Michał Górny
Attachments: signature.asc (0.31 KB)


pacho at gentoo

Apr 15, 2012, 7:12 AM

Post #4 of 8 (726 views)
Permalink
Re: About validate_desktop_entries in eutils.eclass [In reply to]

El dom, 15-04-2012 a las 16:02 +0200, Michał Górny escribió:
> On Sun, 15 Apr 2012 11:59:50 +0200
> Pacho Ramos <pacho [at] gentoo> wrote:
>
> > I am unsure about validate_desktop_entries() utility. It's currently
> > provided by eutils.eclass and only called by net-firewall/fwbuilder.
> > Shouldn't this be moved to a "qa" check? Current way is pretty useless
> > as it's not used by most of packages, and calling it from a lot of
> > eclasses/ebuilds doesn't sound me like a good idea.
> >
> > What do you think?
>
> Agreed. It should be in repoman.
>

The check needs to be run over desktop file going to be installed, not
sure how repoman can handle it, it looked to me more like a emerge job
(like is done with other qa checks run before installation)
Attachments: signature.asc (0.19 KB)


mgorny at gentoo

Apr 15, 2012, 7:23 AM

Post #5 of 8 (734 views)
Permalink
Re: About validate_desktop_entries in eutils.eclass [In reply to]

On Sun, 15 Apr 2012 16:12:11 +0200
Pacho Ramos <pacho [at] gentoo> wrote:

> El dom, 15-04-2012 a las 16:02 +0200, Michał Górny escribió:
> > On Sun, 15 Apr 2012 11:59:50 +0200
> > Pacho Ramos <pacho [at] gentoo> wrote:
> >
> > > I am unsure about validate_desktop_entries() utility. It's
> > > currently provided by eutils.eclass and only called by
> > > net-firewall/fwbuilder. Shouldn't this be moved to a "qa" check?
> > > Current way is pretty useless as it's not used by most of
> > > packages, and calling it from a lot of eclasses/ebuilds doesn't
> > > sound me like a good idea.
> > >
> > > What do you think?
> >
> > Agreed. It should be in repoman.
> >
>
> The check needs to be run over desktop file going to be installed, not
> sure how repoman can handle it, it looked to me more like a emerge job
> (like is done with other qa checks run before installation)

Tfu, you're right. It should be in *however portage calls it runtime QA
thingy* :P.

--
Best regards,
Michał Górny
Attachments: signature.asc (0.31 KB)


betelgeuse at gentoo

Apr 29, 2012, 9:45 AM

Post #6 of 8 (694 views)
Permalink
Re: About validate_desktop_entries in eutils.eclass [In reply to]

On 15.04.2012 17:12, Pacho Ramos wrote:
> El dom, 15-04-2012 a las 16:02 +0200, Michał Górny escribió:
>> On Sun, 15 Apr 2012 11:59:50 +0200
>> Pacho Ramos <pacho [at] gentoo> wrote:
>>
>>> I am unsure about validate_desktop_entries() utility. It's currently
>>> provided by eutils.eclass and only called by net-firewall/fwbuilder.
>>> Shouldn't this be moved to a "qa" check? Current way is pretty useless
>>> as it's not used by most of packages, and calling it from a lot of
>>> eclasses/ebuilds doesn't sound me like a good idea.
>>>
>>> What do you think?
>>
>> Agreed. It should be in repoman.
>>
>
> The check needs to be run over desktop file going to be installed, not
> sure how repoman can handle it, it looked to me more like a emerge job
> (like is done with other qa checks run before installation)

There's actually already code in repoman that runs
desktop-file-validate. It of course only works for installed packages.
Someone could make it run runtime too.

Regards,
Petteri
Attachments: signature.asc (0.88 KB)


zmedico at gentoo

Apr 30, 2012, 10:05 AM

Post #7 of 8 (693 views)
Permalink
Re: About validate_desktop_entries in eutils.eclass [In reply to]

On 04/29/2012 09:45 AM, Petteri Räty wrote:
> On 15.04.2012 17:12, Pacho Ramos wrote:
>> El dom, 15-04-2012 a las 16:02 +0200, Michał Górny escribió:
>>> On Sun, 15 Apr 2012 11:59:50 +0200
>>> Pacho Ramos <pacho [at] gentoo> wrote:
>>>
>>>> I am unsure about validate_desktop_entries() utility. It's currently
>>>> provided by eutils.eclass and only called by net-firewall/fwbuilder.
>>>> Shouldn't this be moved to a "qa" check? Current way is pretty useless
>>>> as it's not used by most of packages, and calling it from a lot of
>>>> eclasses/ebuilds doesn't sound me like a good idea.
>>>>
>>>> What do you think?
>>>
>>> Agreed. It should be in repoman.
>>>
>>
>> The check needs to be run over desktop file going to be installed, not
>> sure how repoman can handle it, it looked to me more like a emerge job
>> (like is done with other qa checks run before installation)
>
> There's actually already code in repoman that runs
> desktop-file-validate. It of course only works for installed packages.
> Someone could make it run runtime too.

The repoman code works on $FILESDIR. It looks like we also want to run
it after src_install.

Also, it looks like we might need to handle a special case for Konqueror
Service Menus:

https://bugs.gentoo.org/show_bug.cgi?id=414125
--
Thanks,
Zac


pacho at gentoo

Apr 30, 2012, 10:50 AM

Post #8 of 8 (690 views)
Permalink
Re: About validate_desktop_entries in eutils.eclass [In reply to]

El lun, 30-04-2012 a las 10:05 -0700, Zac Medico escribió:
> On 04/29/2012 09:45 AM, Petteri Räty wrote:
> > On 15.04.2012 17:12, Pacho Ramos wrote:
> >> El dom, 15-04-2012 a las 16:02 +0200, Michał Górny escribió:
> >>> On Sun, 15 Apr 2012 11:59:50 +0200
> >>> Pacho Ramos <pacho [at] gentoo> wrote:
> >>>
> >>>> I am unsure about validate_desktop_entries() utility. It's currently
> >>>> provided by eutils.eclass and only called by net-firewall/fwbuilder.
> >>>> Shouldn't this be moved to a "qa" check? Current way is pretty useless
> >>>> as it's not used by most of packages, and calling it from a lot of
> >>>> eclasses/ebuilds doesn't sound me like a good idea.
> >>>>
> >>>> What do you think?
> >>>
> >>> Agreed. It should be in repoman.
> >>>
> >>
> >> The check needs to be run over desktop file going to be installed, not
> >> sure how repoman can handle it, it looked to me more like a emerge job
> >> (like is done with other qa checks run before installation)
> >
> > There's actually already code in repoman that runs
> > desktop-file-validate. It of course only works for installed packages.
> > Someone could make it run runtime too.
>
> The repoman code works on $FILESDIR. It looks like we also want to run
> it after src_install.
>
> Also, it looks like we might need to handle a special case for Konqueror
> Service Menus:
>
> https://bugs.gentoo.org/show_bug.cgi?id=414125

Yes, I would like to also check other desktop files than those coming
from FILESDIR
Attachments: signature.asc (0.19 KB)

Gentoo dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.