Mailing List Archive: Forrest: Dev

ElemTemplateElement error: carry-body-attribs caused by r887050

Index | Next | Previous | View Threaded

sjurnm at mac

May 7, 2010, 3:59 AM

Post #1 of 13 (571 views)
Permalink

ElemTemplateElement error: carry-body-attribs caused by r887050

Hello all,

I'm not able to build my site anymore, due to the following error:

X [0] linkmap.html BROKEN: ElemTemplateElement error: carry-body-attribs

I was finally able to track down the cause of the error being the commit r887050. I haven't identified this earlier since I hadn't been updating my Forrest instance in a while, and then didn't have time to track down the error earlier.

Tracking down ... that's kind of an overstatement, since the actual bug is not found. The thing is, this bug does NOT display using a regular seed. I can only trigger this bug using my own site. And this commit was a massive one, with 47 files being modified. But grepping for carry-body-attribs, there are only two matches among the modified files:

a83-245-189-120:main sjur$ grep -r 'carry-body-attribs' * | grep -v '\.svn' | cut -d':' -f1 | sort -u
webapp/skins/common/xslt/html/document-to-html.xsl <--- not modified
webapp/skins/common/xslt/html/site-to-xhtml.xsl <--- not modified
webapp/skins/pelt/xslt/html/document-to-html.xsl
webapp/skins/pelt/xslt/html/site-to-xhtml.xsl

and the only changes to these two files are:

a83-245-189-120:main sjur$ svn diff -c 887050 webapp/skins/pelt/xslt/html/document-to-html.xsl
Index: webapp/skins/pelt/xslt/html/document-to-html.xsl
===================================================================
--- webapp/skins/pelt/xslt/html/document-to-html.xsl (revision 887049)
+++ webapp/skins/pelt/xslt/html/document-to-html.xsl (revision 887050)
@@ -20,7 +20,7 @@
imported document-to-html.xsl for details.
-->
<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
- <xsl:import href="../../../common/xslt/html/document-to-html.xsl"/>
+ <xsl:import href="lm://transform.skin.common.html.document-to-html"/>
<xsl:template match="document">
<meta-data>
<xsl:apply-templates select="header/meta"/>

a83-245-189-120:main sjur$ svn diff -c 887050 webapp/skins/pelt/xslt/html/site-to-xhtml.xsl
Index: webapp/skins/pelt/xslt/html/site-to-xhtml.xsl
===================================================================
--- webapp/skins/pelt/xslt/html/site-to-xhtml.xsl (revision 887049)
+++ webapp/skins/pelt/xslt/html/site-to-xhtml.xsl (revision 887050)
@@ -35,7 +35,7 @@
-->
<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
xmlns:i18n="http://apache.org/cocoon/i18n/2.1" exclude-result-prefixes="i18n">
- <xsl:import href="../../../common/xslt/html/site-to-xhtml.xsl"/>
+ <xsl:import href="lm://transform.skin.common.html.site-to-xhtml"/>


That is, using LM instead of relative paths. It seems pretty harmless, so this error puzzles me. The only explanation I can think of is that by changing to using LM refs instead of path refs, that the included file is somehow changed, ie the LM resolves differently than the previous path reference, and the new file somehow cause the bug.

I also assume that the bug is related to

https://issues.apache.org/jira/browse/FOR-1167

which introduced this attribute.

Any comments or insights would be very appreciated.

Sjur

bdube at apache

May 12, 2010, 5:55 PM

Post #2 of 13 (549 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

On Fri, May 07, 2010 at 02:59:51PM +0300, Sjur Moshagen wrote:
> Hello all,
>
> I'm not able to build my site anymore, due to the following error:
>
> X [0] linkmap.html BROKEN: ElemTemplateElement error: carry-body-attribs
>
> I was finally able to track down the cause of the error being the commit r887050. I haven't identified this earlier since I hadn't been updating my Forrest instance in a while, and then didn't have time to track down the error earlier.
>
> Tracking down ... that's kind of an overstatement, since the actual bug is not found. The thing is, this bug does NOT display using a regular seed. I can only trigger this bug using my own site.

How is the bug triggered?

-Brian

crossley at apache

May 13, 2010, 12:50 AM

Post #3 of 13 (548 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

Brian M Dube wrote:
> Sjur Moshagen wrote:
> >
> > I'm not able to build my site anymore, due to the following error:
> >
> > X [0] linkmap.html BROKEN: ElemTemplateElement error: carry-body-attribs
> >
> > I was finally able to track down the cause of the error being the commit r887050. I haven't identified this earlier since I hadn't been updating my Forrest instance in a while, and then didn't have time to track down the error earlier.
> >
> > Tracking down ... that's kind of an overstatement, since the actual bug is not found. The thing is, this bug does NOT display using a regular seed. I can only trigger this bug using my own site.
>
> How is the bug triggered?

I presume just by running 'forrest' (i.e. 'forrest site').
In default sites, "linkmap.html" is the first document to
be processed.

Remember that "linkmap" is a special pipeline.

To help isolate the problem, try setting the "start-uri"
to be something else (in forrest.properties)
e.g. project.start-uri=index.html

Don't know if that is of any help.

---oOo---

Sjur, you are talking about a Dispatcher-based site, correct?

Are you sure that r887050 is the cause?
Remember that the svn merge of the new Dispatcher branch
happened one day prior to that date, 03 December 2009.

-David

sjurnm at mac

May 13, 2010, 4:36 AM

Post #4 of 13 (550 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

Den 13. mai. 2010 kl. 11.50 skrev David Crossley:

> Brian M Dube wrote:
>> Sjur Moshagen wrote:
>>>
>>> I'm not able to build my site anymore, due to the following error:
>>>
>>> X [0] linkmap.html BROKEN: ElemTemplateElement error: carry-body-attribs
>>>
>>> I was finally able to track down the cause of the error being the commit r887050. I haven't identified this earlier since I hadn't been updating my Forrest instance in a while, and then didn't have time to track down the error earlier.
>>>
>>> Tracking down ... that's kind of an overstatement, since the actual bug is not found. The thing is, this bug does NOT display using a regular seed. I can only trigger this bug using my own site.
>>
>> How is the bug triggered?
>
> I presume just by running 'forrest' (i.e. 'forrest site').

Yes.

> In default sites, "linkmap.html" is the first document to
> be processed.
>
> Remember that "linkmap" is a special pipeline.
>
> To help isolate the problem, try setting the "start-uri"
> to be something else (in forrest.properties)
> e.g. project.start-uri=index.html

I will try that as soon as I have some more time.

> Don't know if that is of any help.
>
> ---oOo---
>
> Sjur, you are talking about a Dispatcher-based site, correct?

Yes, but the bug is showing up whether or not I have dispatcher enabled. I stripped the plugins down to only pdf, and I still got that bug.

> Are you sure that r887050 is the cause?
> Remember that the svn merge of the new Dispatcher branch
> happened one day prior to that date, 03 December 2009.

I know, and that was what I suspected as well. But so far r887050 is the one that triggers the bug. That doesn't mean that the bug hasn't been introduced earlier, but somehow was hidden until this revision.

Thansk for following up on this, both of you.

Best regards,
Sjur

bdube at apache

May 13, 2010, 6:05 AM

Post #5 of 13 (553 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

bdube at apache

May 14, 2010, 6:33 PM

Post #6 of 13 (549 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

On Thu, May 13, 2010 at 03:36:36PM +0300, Sjur Moshagen wrote:
> Den 13. mai. 2010 kl. 11.50 skrev David Crossley:
>
> > Brian M Dube wrote:
> >> Sjur Moshagen wrote:
> >>>
> >>> I'm not able to build my site anymore, due to the following error:
> >>>
> >>> X [0] linkmap.html BROKEN: ElemTemplateElement error: carry-body-attribs
> >>>
> > Sjur, you are talking about a Dispatcher-based site, correct?
>
> Yes, but the bug is showing up whether or not I have dispatcher enabled. I stripped the plugins down to only pdf, and I still got that bug.

That's interesting. I can only find carry-body-attribs in skins
stylesheets.

ElemTemplateElement is in Xalan, but I couldn't find in the source
where Cocoon makes use of this class. I have a stack trace, and that
may or may not help us. It's all I have to go by for now since I can't
reproduce the bug.

[1] org.apache.xalan.templates.ElemTemplateElement.<init> (ElemTemplateElement.java:70)
[2] org.apache.xalan.templates.OutputProperties.<init> (OutputProperties.java:82)
[3] org.apache.xalan.transformer.TransformerImpl.<init> (TransformerImpl.java:182)
[4] org.apache.xalan.templates.StylesheetRoot.newTransformer (StylesheetRoot.java:200)
[5] org.apache.xalan.processor.TransformerFactoryImpl.newTransformerHandler (TransformerFactoryImpl.java:701)
[6] org.apache.cocoon.components.xslt.TraxProcessor.getTemplates (TraxProcessor.java:496)
[7] org.apache.cocoon.components.xslt.TraxProcessor.getTransformerHandlerAndValidity (TraxProcessor.java:198)
[8] org.apache.cocoon.transformation.TraxTransformer.setup (TraxTransformer.java:331)
[9] org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.setupPipeline (AbstractProcessingPipeline.java:400)
[10] org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline.setupPipeline (AbstractCachingProcessingPipeline.java:737)
[11] org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.preparePipeline (AbstractProcessingPipeline.java:503)
[12] org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.prepareInternal (AbstractProcessingPipeline.java:517)
[13] org.apache.cocoon.components.source.impl.SitemapSource.init (SitemapSource.java:343)
[14] org.apache.cocoon.components.source.impl.SitemapSource.<init> (SitemapSource.java:215)
[15] org.apache.cocoon.components.source.impl.SitemapSourceFactory.getSource (SitemapSourceFactory.java:65)
[16] sun.reflect.GeneratedMethodAccessor4.invoke (null)
[17] sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
[18] java.lang.reflect.Method.invoke (Method.java:616)
[19] org.apache.avalon.excalibur.component.ComponentProxyGenerator$ComponentInvocationHandler.invoke (ComponentProxyGenerator.java:143)
[20] $Proxy3.getSource (null)
[21] org.apache.excalibur.source.impl.AbstractSourceResolver.resolveURI (AbstractSourceResolver.java:146)
[22] sun.reflect.GeneratedMethodAccessor3.invoke (null)
[23] sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
[24] java.lang.reflect.Method.invoke (Method.java:616)
[25] org.apache.avalon.excalibur.component.ComponentProxyGenerator$ComponentInvocationHandler.invoke (ComponentProxyGenerator.java:143)
[26] $Proxy8.resolveURI (null)
[27] org.apache.cocoon.components.CocoonComponentManager.resolveURI (CocoonComponentManager.java:558)
[28] org.apache.cocoon.environment.AbstractEnvironment.resolveURI (AbstractEnvironment.java:555)
[29] org.apache.cocoon.environment.AbstractEnvironment.resolveURI (AbstractEnvironment.java:542)
[30] org.apache.cocoon.sitemap.ContentAggregator.setup (ContentAggregator.java:290)
[31] org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.setupPipeline (AbstractProcessingPipeline.java:387)
[32] org.apache.cocoon.components.pipeline.impl.AbstractCachingProcessingPipeline.setupPipeline (AbstractCachingProcessingPipeline.java:737)
[33] org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.preparePipeline (AbstractProcessingPipeline.java:503)
[34] org.apache.cocoon.components.pipeline.AbstractProcessingPipeline.process (AbstractProcessingPipeline.java:455)
[35] org.apache.cocoon.components.treeprocessor.sitemap.SerializeNode.invoke (SerializeNode.java:144)
[36] org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes (AbstractParentProcessingNode.java:69)
[37] org.apache.cocoon.components.treeprocessor.ContainerNode.invoke (ContainerNode.java:32)
[38] org.apache.cocoon.components.treeprocessor.sitemap.CallNode.invoke (CallNode.java:94)
[39] org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes (AbstractParentProcessingNode.java:47)
[40] org.apache.cocoon.components.treeprocessor.sitemap.MatchNode.invoke (MatchNode.java:108)
[41] org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes (AbstractParentProcessingNode.java:69)
[42] org.apache.cocoon.components.treeprocessor.sitemap.PipelineNode.invoke (PipelineNode.java:143)
[43] org.apache.cocoon.components.treeprocessor.AbstractParentProcessingNode.invokeNodes (AbstractParentProcessingNode.java:69)
[44] org.apache.cocoon.components.treeprocessor.sitemap.PipelinesNode.invoke (PipelinesNode.java:93)
[45] org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process (ConcreteTreeProcessor.java:235)
[46] org.apache.cocoon.components.treeprocessor.ConcreteTreeProcessor.process (ConcreteTreeProcessor.java:177)
[47] org.apache.cocoon.components.treeprocessor.TreeProcessor.process (TreeProcessor.java:254)
[48] org.apache.cocoon.Cocoon.process (Cocoon.java:699)
[49] org.apache.cocoon.servlet.CocoonServlet.service (CocoonServlet.java:1,154)
[50] javax.servlet.http.HttpServlet.service (HttpServlet.java:853)
[51] org.mortbay.jetty.servlet.ServletHolder.handle (ServletHolder.java:354)
[52] org.mortbay.jetty.servlet.WebApplicationHandler.dispatch (WebApplicationHandler.java:294)
[53] org.mortbay.jetty.servlet.ServletHandler.handle (ServletHandler.java:567)
[54] org.mortbay.http.HttpContext.handle (HttpContext.java:1,808)
[55] org.mortbay.jetty.servlet.WebApplicationContext.handle (WebApplicationContext.java:525)
[56] org.mortbay.http.HttpContext.handle (HttpContext.java:1,758)
[57] org.mortbay.http.HttpServer.service (HttpServer.java:879)
[58] org.mortbay.http.HttpConnection.service (HttpConnection.java:790)
[59] org.mortbay.http.HttpConnection.handleNext (HttpConnection.java:952)
[60] org.mortbay.http.HttpConnection.handle (HttpConnection.java:807)
[61] org.mortbay.http.SocketListener.handleConnection (SocketListener.java:197)
[62] org.mortbay.util.ThreadedServer.handle (ThreadedServer.java:289)
[63] org.mortbay.util.ThreadPool$PoolThread.run (ThreadPool.java:501)

-Brian

sina at khakbaz

May 14, 2010, 7:26 PM

Post #7 of 13 (547 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

Brian M Dube wrote:
> Sjur Moshagen wrote:
>> David Crossley wrote:
>> > Brian M Dube wrote:
>> >> Sjur Moshagen wrote:
>> >>>
>> >>> I'm not able to build my site anymore, due to the following error:
>> >>>
>> >>> X [0] linkmap.html BROKEN: ElemTemplateElement error: carry-body-attribs
>> >>>
>> > Sjur, you are talking about a Dispatcher-based site, correct?
>>
>> Yes, but the bug is showing up whether or not I have dispatcher enabled. I
>> stripped the plugins down to only pdf, and I still got that bug.
>
> That's interesting. I can only find carry-body-attribs in skins
> stylesheets.

Yes. These templates were only added to skin-based stylesheets.

> ElemTemplateElement is in Xalan, but I couldn't find in the source
> where Cocoon makes use of this class. I have a stack trace, and that
> may or may not help us. It's all I have to go by for now since I can't
> reproduce the bug.
>
> [1] org.apache.xalan.templates.ElemTemplateElement.<init>
> (ElemTemplateElement.java:70)
> [2] org.apache.xalan.templates.OutputProperties.<init>
> (OutputProperties.java:82)
> [3] org.apache.xalan.transformer.TransformerImpl.<init>
> (TransformerImpl.java:182)
> [4] org.apache.xalan.templates.StylesheetRoot.newTransformer
> (StylesheetRoot.java:200)
> [5] org.apache.xalan.processor.TransformerFactoryImpl.newTransformerHandler
> (TransformerFactoryImpl.java:701)
> [6] org.apache.cocoon.components.xslt.TraxProcessor.getTemplates
> (TraxProcessor.java:496)

Cocoon delegates the transformation to a TraxProcessor and that all there is to it as far as Cocoon is concerned. The computation fails at a lower level during the actual XSL transformation takes place.

Let's find out which statement in the stylesheets causes the issue. I suggest placing <xsl:message/> statements in order to locate the hot spot.

Sina

sina at khakbaz

May 14, 2010, 7:31 PM

Post #8 of 13 (553 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

(Fixed typos in my earlier post.)

Brian M Dube wrote:
> Sjur Moshagen wrote:
>> David Crossley wrote:
>> > Brian M Dube wrote:
>> >> Sjur Moshagen wrote:
>> >>>
>> >>> I'm not able to build my site anymore, due to the following error:
>> >>>
>> >>> X [0] linkmap.html BROKEN: ElemTemplateElement error: carry-body-attribs
>> >>>
>> > Sjur, you are talking about a Dispatcher-based site, correct?
>>
>> Yes, but the bug is showing up whether or not I have dispatcher enabled. I
>> stripped the plugins down to only pdf, and I still got that bug.
>
> That's interesting. I can only find carry-body-attribs in skins
> stylesheets.

Yes. These templates were only added to skin-based stylesheets.

> ElemTemplateElement is in Xalan, but I couldn't find in the source
> where Cocoon makes use of this class. I have a stack trace, and that
> may or may not help us. It's all I have to go by for now since I can't
> reproduce the bug.
>
> [1] org.apache.xalan.templates.ElemTemplateElement.<init>
> (ElemTemplateElement.java:70)
> [2] org.apache.xalan.templates.OutputProperties.<init>
> (OutputProperties.java:82)
> [3] org.apache.xalan.transformer.TransformerImpl.<init>
> (TransformerImpl.java:182)
> [4] org.apache.xalan.templates.StylesheetRoot.newTransformer
> (StylesheetRoot.java:200)
> [5] org.apache.xalan.processor.TransformerFactoryImpl.newTransformerHandler
> (TransformerFactoryImpl.java:701)
> [6] org.apache.cocoon.components.xslt.TraxProcessor.getTemplates
> (TraxProcessor.java:496)

Cocoon delegates the transformation to a TraxProcessor and that's all there is to it as far as Cocoon is concerned. The computation fails at a lower level during the actual XSL transformation.

Let's find out which statement in the stylesheets causes the issue. I suggest placing <xsl:message/> statements in order to locate the hot spot.

Sina

sjurnm at mac

May 19, 2010, 12:48 PM

Post #9 of 13 (547 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

Den 13. mai. 2010 kl. 15.36 skrev Sjur Moshagen:

> Den 13. mai. 2010 kl. 11.50 skrev David Crossley:
>> In default sites, "linkmap.html" is the first document to
>> be processed.
>>
>> Remember that "linkmap" is a special pipeline.
>>
>> To help isolate the problem, try setting the "start-uri"
>> to be something else (in forrest.properties)
>> e.g. project.start-uri=index.html
>
> I will try that as soon as I have some more time.

Now I got the time, and here is the result:

X [0] index.html BROKEN: ElemTemplateElement error: carry-body-attribs

I tried with a couple of other start pages as well, and they all gave the same result.

>> Don't know if that is of any help.
>>
>> ---oOo---
>>
>> Sjur, you are talking about a Dispatcher-based site, correct?
>
> Yes, but the bug is showing up whether or not I have dispatcher enabled. I stripped the plugins down to only pdf, and I still got that bug.
>
>> Are you sure that r887050 is the cause?
>> Remember that the svn merge of the new Dispatcher branch
>> happened one day prior to that date, 03 December 2009.
>
> I know, and that was what I suspected as well. But so far r887050 is the one that triggers the bug. That doesn't mean that the bug hasn't been introduced earlier, but somehow was hidden until this revision.

I found the bug - it is on our side. It turned out that at some point the default skin directory tree was copied from the forrest code to our project code, and perhaps slightly modified. This local skin copy of course was not kept in sync with the improvements and bug fixes made to the common skin files were transfered to our local copy. After I updated all local files to be in sync with the Forrest ones, the bug disappeared.

I guess that before that specific commit, only parts of the local skin files were used, as the pre-lm solution probably didn't as thoroughly ckeck for local overrides of all files. That would explain why the site had worked before, and why not after this commit.

Anyway - this is a lession to our group, and perhaps a relief regarding the Forrest code: there was no bug in Forrest:)

Best regards,
Sjur

sina at khakbaz

May 19, 2010, 3:23 PM

Post #10 of 13 (547 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

Sjur Moshagen wrote:
> Den 13. mai. 2010 kl. 15.36 skrev Sjur Moshagen:
>> Den 13. mai. 2010 kl. 11.50 skrev David Crossley:
>>> In default sites, "linkmap.html" is the first document to
>>> be processed.
>>>
>>> Remember that "linkmap" is a special pipeline.
>>>
>>> To help isolate the problem, try setting the "start-uri"
>>> to be something else (in forrest.properties)
>>> e.g. project.start-uri=index.html
>>
>> I will try that as soon as I have some more time.
>
> Now I got the time, and here is the result:
>
> X [0] index.html BROKEN: ElemTemplateElement error: carry-body-attribs
>
> I tried with a couple of other start pages as well, and they all gave the same
> result.
>
>>> Don't know if that is of any help.
>>>
>>> ---oOo---
>>>
>>> Sjur, you are talking about a Dispatcher-based site, correct?
>>
>> Yes, but the bug is showing up whether or not I have dispatcher enabled. I
>> stripped the plugins down to only pdf, and I still got that bug.
>>
>>> Are you sure that r887050 is the cause?
>>> Remember that the svn merge of the new Dispatcher branch
>>> happened one day prior to that date, 03 December 2009.
>>
>> I know, and that was what I suspected as well. But so far r887050 is the one that
>> triggers the bug. That doesn't mean that the bug hasn't been introduced earlier,
>> but somehow was hidden until this revision.
>
> I found the bug - it is on our side. It turned out that at some point the default
> skin directory tree was copied from the forrest code to our project code, and
> perhaps slightly modified. This local skin copy of course was not kept in sync
> with the improvements and bug fixes made to the common skin files were transfered
> to our local copy. After I updated all local files to be in sync with the Forrest
> ones, the bug disappeared.
>
> Anyway - this is a lession to our group, and perhaps a relief regarding the
> Forrest code: there was no bug in Forrest:)

Good job finding the cause.

Sina

bdube at apache

May 25, 2010, 7:25 PM

Post #11 of 13 (550 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

On Wed, May 19, 2010 at 11:48:49PM +0300, Sjur Moshagen wrote:
> Den 13. mai. 2010 kl. 15.36 skrev Sjur Moshagen:
>
> > Den 13. mai. 2010 kl. 11.50 skrev David Crossley:
> >> In default sites, "linkmap.html" is the first document to
> >> be processed.
> >>
> >> Remember that "linkmap" is a special pipeline.
> >>
> >> To help isolate the problem, try setting the "start-uri"
> >> to be something else (in forrest.properties)
> >> e.g. project.start-uri=index.html
> >
> > I will try that as soon as I have some more time.
>
> Now I got the time, and here is the result:
>
> X [0] index.html BROKEN: ElemTemplateElement error: carry-body-attribs
>
> I tried with a couple of other start pages as well, and they all
> gave the same result.
>
> >> Don't know if that is of any help.
> >>
> >> ---oOo---
> >>
> >> Sjur, you are talking about a Dispatcher-based site, correct?
> >
> > Yes, but the bug is showing up whether or not I have dispatcher
> > enabled. I stripped the plugins down to only pdf, and I still got
> > that bug.
> >
> >> Are you sure that r887050 is the cause?
> >> Remember that the svn merge of the new Dispatcher branch
> >> happened one day prior to that date, 03 December 2009.
> >
> > I know, and that was what I suspected as well. But so far r887050
> > is the one that triggers the bug. That doesn't mean that the bug
> > hasn't been introduced earlier, but somehow was hidden until this
> > revision.
>
> I found the bug - it is on our side. It turned out that at some
> point the default skin directory tree was copied from the forrest
> code to our project code, and perhaps slightly modified. This local
> skin copy of course was not kept in sync with the improvements and
> bug fixes made to the common skin files were transfered to our local
> copy. After I updated all local files to be in sync with the Forrest
> ones, the bug disappeared.

Out of date skins files prevented your site from building while
dispatcher was enabled?

And it hasn't been clear to me, does your site even use body
attributes?

-Brian

> I guess that before that specific commit, only parts of the local
> skin files were used, as the pre-lm solution probably didn't as
> thoroughly ckeck for local overrides of all files. That would
> explain why the site had worked before, and why not after this
> commit.
>
> Anyway - this is a lession to our group, and perhaps a relief
> regarding the Forrest code: there was no bug in Forrest:)
>
> Best regards,
> Sjur
>

sjurnm at mac

May 26, 2010, 3:02 AM

Post #12 of 13 (548 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

Den 26. mai. 2010 kl. 06.25 skrev Brian M Dube:

>>>> Sjur, you are talking about a Dispatcher-based site, correct?
>>>
>>> Yes, but the bug is showing up whether or not I have dispatcher
>>> enabled. I stripped the plugins down to only pdf, and I still got
>>> that bug.
>>>
>>>> Are you sure that r887050 is the cause?
>>>> Remember that the svn merge of the new Dispatcher branch
>>>> happened one day prior to that date, 03 December 2009.
>>>
>>> I know, and that was what I suspected as well. But so far r887050
>>> is the one that triggers the bug. That doesn't mean that the bug
>>> hasn't been introduced earlier, but somehow was hidden until this
>>> revision.
>>
>> I found the bug - it is on our side. It turned out that at some
>> point the default skin directory tree was copied from the forrest
>> code to our project code, and perhaps slightly modified. This local
>> skin copy of course was not kept in sync with the improvements and
>> bug fixes made to the common skin files were transfered to our local
>> copy. After I updated all local files to be in sync with the Forrest
>> ones, the bug disappeared.
>
> Out of date skins files prevented your site from building while
> dispatcher was enabled?

No. Out-of-date skins files prevented the site from building independently of dispatcher being enabled or not (see above). Dispatcher wasn't part of the problem at all.

> And it hasn't been clear to me, does your site even use body
> attributes?

Only in two documents.

Best,
Sjur

brolin at brolin

Jan 19, 2011, 5:41 PM

Post #13 of 13 (547 views)
Permalink

Re: ElemTemplateElement error: carry-body-attribs caused by r887050 [In reply to]

Sjur Moshagen wrote:
> Tracking down ... that's kind of an overstatement, since the actual bug is not found. The thing is, this bug does NOT display using a regular seed. I can only trigger this bug using my own site. And this commit was a massive one, with 47 files being modified. But grepping for carry-body-attribs, there are only two matches among the modified files:
>
> a83-245-189-120:main sjur$ grep -r 'carry-body-attribs' * | grep -v '\.svn' | cut -d':' -f1 | sort -u
> webapp/skins/common/xslt/html/document-to-html.xsl<--- not modified
> webapp/skins/common/xslt/html/site-to-xhtml.xsl<--- not modified
> webapp/skins/pelt/xslt/html/document-to-html.xsl
> webapp/skins/pelt/xslt/html/site-to-xhtml.xsl

At least with GNU grep, you do not need to filter grep�s output with cut
as you have done: you can use �grep -l� (--files-with-matches). You
can also probably use �grep --exclude-dir� instead of filtering grep�s
output with �grep -v�.

You can also blame (praise) me for FOR-1167. ;)

--
Sometimes I forget how to do small talk: <http://xkcd.com/222/>

�If you have to ask why, you�re not a member of the intended audience.�
� Bob Zimbinski, <http://webpages.mr.net/bobz/ttyquake/>

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads