Mailing List Archive: exim: users

[PATCH] add verify=header_sender[=header_type] functionality

Index | Next | Previous | View Threaded

sean at donelan

Nov 14, 2009, 6:43 PM

Post #1 of 3 (496 views)
Permalink

[PATCH] add verify=header_sender[=header_type] functionality

Nothing like a new release to remind me about the pain of migrating
custom patches to each release. If you would like to incorporate this
in a future release, please do.

I wanted specify which header sender field to verify, I've expanded the
verify=header_sender command. I also fixed some of the header syntax
checking to recognize some additional valid, and sometimes used, address
list formats.

http://www.donelan.com/exim-patches/header-verify.patch
http://www.donelan.com/exim-patches/header-verify.readme

verify = header_sender[=header_type]/<options>

Header type can specify which "sender" header field to check.

* returns true if any sender header address is verifiable
all returns true if all header sender addresses are verifiable
from returns true if verifiable address in From: header line
reply_to returns true if verifiable address in Reply-To: header line
sender returns true if verifiable address in Sender: header line

The default action is "*" which is the current (4.70) behavior.

Example from EXIM configuration

# Check if just the header From: can be (partially) verified

warn condition = ${if def:h_from: {true}{false}}
!verify = header_sender=from
logwrite = X-Header-Error: $acl_verify_message
add_header = :at_start:X-Header-Error: \
could not verify "From:" header address

--
## List details at http://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

eximusers at downhill

Nov 15, 2009, 2:09 AM

Post #2 of 3 (468 views)
Permalink

Re: [PATCH] add verify=header_sender[=header_type] functionality [In reply to]

Sean Donelan <sean [at] donelan> wrote:
[...]
> I wanted specify which header sender field to verify, I've expanded the
> verify=header_sender command.
[...]
> Header type can specify which "sender" header field to check.

> * returns true if any sender header address is verifiable
> all returns true if all header sender addresses are verifiable
> from returns true if verifiable address in From: header line
> reply_to returns true if verifiable address in Reply-To: header line
> sender returns true if verifiable address in Sender: header line

> The default action is "*" which is the current (4.70) behavior.
[...]

Shouldn't the default be named "any" instead of "*"? I am no native
speaker but without consulting docs I would guess
"require verify = header_sender=*"
to mean that *every* address in the respective fields needs to be
verifyable. (which is what you correctly labeled as "all".)

cu andreas

--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

--
## List details at http://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

sean at donelan

Nov 15, 2009, 3:09 AM

Post #3 of 3 (452 views)
Permalink

Re: [PATCH] add verify=header_sender[=header_type] functionality [In reply to]

On Sun, 15 Nov 2009, Andreas Metzler wrote:
>> I wanted specify which header sender field to verify, I've expanded the
>> verify=header_sender command.
> [...]
>> Header type can specify which "sender" header field to check.
>
>> * returns true if any sender header address is verifiable
>> all returns true if all header sender addresses are verifiable
>> from returns true if verifiable address in From: header line
>> reply_to returns true if verifiable address in Reply-To: header line
>> sender returns true if verifiable address in Sender: header line
>
>> The default action is "*" which is the current (4.70) behavior.
> [...]
>
> Shouldn't the default be named "any" instead of "*"? I am no native
> speaker but without consulting docs I would guess
> "require verify = header_sender=*"
> to mean that *every* address in the respective fields needs to be
> verifyable. (which is what you correctly labeled as "all".)

The default is meant to be backward compatible with the current behavior;
which is difficult to explain in a single word in any language. I don't
have a problem with the Exim maintainers deciding to use different
keywords.

--
## List details at http://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads