git at exim
Jun 4, 2013, 3:17 PM
Post #1 of 1
(90 views)
Permalink
|
|
[Bug 1363] eximon does not continuously update logfile widget
|
|
------- You are receiving this mail because: -------
You are on the CC list for the bug.
http://bugs.exim.org/show_bug.cgi?id=1363
Git Commit <git [at] exim> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |git [at] exim
--- Comment #1 from Git Commit <git [at] exim> 2013-06-04 23:17:06 ---
Git commit:
http://git.exim.org/exim.git/commitdiff/8c02018827314fde071df70e2e1e080d241ffc49
commit 8c02018827314fde071df70e2e1e080d241ffc49
Author: Phil Pennock <pdp [at] exim>
AuthorDate: Tue Jun 4 17:34:36 2013 -0400
Commit: Phil Pennock <pdp [at] exim>
CommitDate: Tue Jun 4 17:34:36 2013 -0400
Fix eximon continuous updating with timestamped log-files.
Report and fix from Heiko Schlichting.
Fixes 1363.
---
doc/doc-txt/ChangeLog | 6 ++++++
src/exim_monitor/em_log.c | 4 +++-
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog
index 11079a2..e0411ba 100644
--- a/doc/doc-txt/ChangeLog
+++ b/doc/doc-txt/ChangeLog
@@ -196,6 +196,12 @@ PP/20 Added force_command boolean option to pipe
transport.
JH/15 AUTH support on callouts (and hence cutthrough-deliveries).
Bugzilla 321, 823.
+PP/21 Fix eximon continuous updating with timestamped log-files.
+ Broken in a format-string cleanup in 4.80, missed when I repaired the
+ other false fix of the same issue.
+ Report and fix from Heiko Schlichting.
+ Bugzilla 1363.
+
Exim version 4.80.1
-------------------
diff --git a/src/exim_monitor/em_log.c b/src/exim_monitor/em_log.c
index bd1d462..0441edd 100644
--- a/src/exim_monitor/em_log.c
+++ b/src/exim_monitor/em_log.c
@@ -364,7 +364,9 @@ link count of zero on the currently open file. */
if (log_datestamping)
{
uschar log_file_wanted[256];
- string_format(log_file_wanted, sizeof(log_file_wanted), "%s", CS log_file);
+ /* Do *not* use "%s" here, we need the %D datestamp in the log_file to
+ * be expanded! */
+ string_format(log_file_wanted, sizeof(log_file_wanted), CS log_file);
if (Ustrcmp(log_file_wanted, log_file_open) != 0)
{
if (LOG != NULL)
--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
|
