Mailing List Archive: exim: dev

[Bug 1267] Negation does not work with inlist and inlisti

Index | Next | Previous | View Threaded

jgh146exb at wizmail

Jul 5, 2012, 3:08 PM

Post #1 of 9 (410 views)
Permalink

[Bug 1267] Negation does not work with inlist and inlisti

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1267

Jeremy Harris <jgh146exb [at] wizmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |jgh146exb [at] wizmail
AssignedTo|nigel [at] exim |jgh146exb [at] wizmail

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

jgh146exb at wizmail

Jul 5, 2012, 3:12 PM

Post #2 of 9 (401 views)
Permalink

[Bug 1267] Negation does not work with inlist and inlisti [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1267

Jeremy Harris <jgh146exb [at] wizmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC|jgh146exb [at] wizmail |

--- Comment #1 from Jeremy Harris <jgh146exb [at] wizmail> 2012-07-05 23:12:23 ---
Well spotted; looks like a simple omission in the coding.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

git at exim

Jul 5, 2012, 5:17 PM

Post #3 of 9 (397 views)
Permalink

[Bug 1267] Negation does not work with inlist and inlisti [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1267

Git Commit <git [at] exim> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |git [at] exim

--- Comment #2 from Git Commit <git [at] exim> 2012-07-06 01:17:07 ---
Git commit:
http://git.exim.org/exim.git/commitdiff/b5b871aca49fbf0fcc2c91997e70c3c57f77faa9

commit b5b871aca49fbf0fcc2c91997e70c3c57f77faa9
Author: Jeremy Harris <jgh146exb [at] wizmail>
AuthorDate: Thu Jul 5 23:59:20 2012 +0100
Commit: Jeremy Harris <jgh146exb [at] wizmail>
CommitDate: Thu Jul 5 23:59:20 2012 +0100

fix bug 1267 - inlist/i were ignoring negation.

fix the acl condition also; and make editor brace-matching a
little better.
----
src/src/expand.c | 85 ++++++++++++++++++++++++++++++------------------------
1 files changed, 47 insertions(+), 38 deletions(-)

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

tlyons at ivenue

Jul 5, 2012, 7:17 PM

Post #4 of 9 (394 views)
Permalink

Re: [Bug 1267] Negation does not work with inlist and inlisti [In reply to]

On Thu, Jul 5, 2012 at 5:17 PM, Git Commit <git [at] exim> wrote:
>
> fix bug 1267 - inlist/i were ignoring negation.
>
> fix the acl condition also; and make editor brace-matching a
> little better.

There should definitely be a test added for that. I'm planning on
doing a push tomorrow to make +smtp_confirmation be a default log
selector (one line of code change leading to lots of log/*, stdout/*,
and stderr/* minor changes). I'll make a second small commit to add a
testcase for the above. I can test it before and after your commit
(am currently working on a branch that's a couple of weeks old) to
make sure it looks for the right thing.

...Todd
--
The total budget at all receivers for solving senders' problems is $0.
If you want them to accept your mail and manage it the way you want,
send it the way the spec says to. --John Levine

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

tlyons at ivenue

Jul 5, 2012, 7:17 PM

Post #5 of 9 (393 views)
Permalink

[Bug 1267] Negation does not work with inlist and inlisti [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1267

--- Comment #3 from Todd Lyons <tlyons [at] ivenue> 2012-07-06 03:17:47 ---
On Thu, Jul 5, 2012 at 5:17 PM, Git Commit <git [at] exim> wrote:
>
> fix bug 1267 - inlist/i were ignoring negation.
>
> fix the acl condition also; and make editor brace-matching a
> little better.

There should definitely be a test added for that. I'm planning on
doing a push tomorrow to make +smtp_confirmation be a default log
selector (one line of code change leading to lots of log/*, stdout/*,
and stderr/* minor changes). I'll make a second small commit to add a
testcase for the above. I can test it before and after your commit
(am currently working on a branch that's a couple of weeks old) to
make sure it looks for the right thing.

...Todd

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

pdp at exim

Jul 6, 2012, 12:32 AM

Post #6 of 9 (390 views)
Permalink

[Bug 1267] Negation does not work with inlist and inlisti [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1267

--- Comment #4 from Phil Pennock <pdp [at] exim> 2012-07-06 08:32:47 ---
Yes, this one's my fault, and it's the same mistake as when I added
bool/bool_lax. :(

Sorry folks.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

jgh146exb at wizmail

Jul 6, 2012, 12:15 PM

Post #7 of 9 (384 views)
Permalink

[Bug 1267] Negation does not work with inlist and inlisti [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1267

--- Comment #5 from Jeremy Harris <jgh146exb [at] wizmail> 2012-07-06 20:15:44 ---
It's an easy mistake to make (I did it too) and I think the coding should be
restructured to make it so anyone adding any more cases doesn't need to worry
about that bit of complexity. I made a start in that direction but more is
needed.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

jgh146exb at wizmail

Jul 7, 2012, 2:10 PM

Post #8 of 9 (376 views)
Permalink

[Bug 1267] Negation does not work with inlist and inlisti [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1267

Jeremy Harris <jgh146exb [at] wizmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

tlyons at ivenue

Jul 8, 2012, 4:39 PM

Post #9 of 9 (364 views)
Permalink

[Bug 1267] Negation does not work with inlist and inlisti [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1267

Todd Lyons <tlyons [at] ivenue> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tlyons [at] ivenue

--- Comment #6 from Todd Lyons <tlyons [at] ivenue> 2012-07-09 00:39:54 ---
Took content below, added to tests with correct output to basic test 0002.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads