Mailing List Archive: exim: dev

Exim/Linux: CFLAGS fix from Debian?

Index | Next | Previous | View Threaded

pdp at exim

Jun 24, 2012, 3:45 AM

Post #1 of 6 (274 views)
Permalink

Exim/Linux: CFLAGS fix from Debian?

This patch:
http://patch-tracker.debian.org/patch/series/view/exim4/4.80-2/30_dontoverridecflags.dpatch
causes Exim to conditionally set CFLAGS in OS/Makefile-Linux using ?=
syntax.

That seems eminently sane to me. Does anyone know a reason to not
apply this to base?

I think this is rather old syntax, so likely to be supported by even the
creakiest of Linux systems. Anyone know otherwise? We use it currently
in GNU and NetBSD systems.

I just double-checked, and it looks like only '=' assignment of macros
is guaranteed by POSIX, which matches my creaky recollection. I know
the BSD systems have supported '?=' for a long time, and I know Gnu make
has supported ':=' for a long time; I'm just unclear on the age of ?=
support in GNU Mkae.

Thanks,
-Phil

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

develop at kristov

Jun 24, 2012, 4:00 AM

Post #2 of 6 (258 views)
Permalink

Re: Exim/Linux: CFLAGS fix from Debian? [In reply to]

Hello!

Phil Pennock schrieb am Sun, 24 Jun 2012 03:45:59 -0700:

> I'm just unclear on the age of ?=
> support in GNU Mkae.

From [1]:

1998-03-02 Paul D. Smith <psmith [at] gnu>

* variable.c (try_variable_definition): Implement ?=.

That would mean it is supported from 3.76.90 on, which was released on
1998-05-20, also according to [1].

Regards,

Christoph

[1] cvs.savannah.gnu.org/viewvc/make/ChangeLog.2?root=make&view=markup

pdp at exim

Jun 24, 2012, 4:13 AM

Post #3 of 6 (260 views)
Permalink

Re: Exim/Linux: CFLAGS fix from Debian? [In reply to]

On 2012-06-24 at 13:00 +0200, Christoph Schulz wrote:
> Hello!
>
> Phil Pennock schrieb am Sun, 24 Jun 2012 03:45:59 -0700:
>
> > I'm just unclear on the age of ?=
> > support in GNU Mkae.
>
> From [1]:
>
> 1998-03-02 Paul D. Smith <psmith [at] gnu>
>
> * variable.c (try_variable_definition): Implement ?=.
>
> That would mean it is supported from 3.76.90 on, which was released on
> 1998-05-20, also according to [1].

Okay, so there's a 50/50 chance RedHat RHEL5 supports it then. :)

/me runs

Thanks for looking that up, it's appreciated.
-Phil

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

A.C.Aitchison at dpmms

Jun 24, 2012, 5:35 AM

Post #4 of 6 (259 views)
Permalink

Re: Exim/Linux: CFLAGS fix from Debian? [In reply to]

On Sun, 24 Jun 2012, Phil Pennock wrote:

> On 2012-06-24 at 13:00 +0200, Christoph Schulz wrote:
>> Hello!
>>
>> Phil Pennock schrieb am Sun, 24 Jun 2012 03:45:59 -0700:
>>
>>> I'm just unclear on the age of ?=
>>> support in GNU Mkae.
>>
>> From [1]:
>>
>> 1998-03-02 Paul D. Smith <psmith [at] gnu>
>>
>> * variable.c (try_variable_definition): Implement ?=.
>>
>> That would mean it is supported from 3.76.90 on, which was released on
>> 1998-05-20, also according to [1].

# cat /etc/redhat-release
Scientific Linux SL release 5.7 (Boron)
# make -v
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for x86_64-redhat-linux-gnu

--- 8<
So we should be OK with current (5.8) RHEL5 systems.

Looking at my incomplete archive 5.5 had the same 3.81 make package
and RHEL5 contains a source package for make 3.81 built in Jan 2007.

> Okay, so there's a 50/50 chance RedHat RHEL5 supports it then. :)
>
> /me runs

So you got lucky this time :-)

--
Dr. Andrew C. Aitchison Computer Officer, DPMMS, Cambridge
A.C.Aitchison [at] dpmms http://www.dpmms.cam.ac.uk/~werdna

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

jgh at wizmail

Jun 24, 2012, 6:45 AM

Post #5 of 6 (263 views)
Permalink

Re: Exim/Linux: CFLAGS fix from Debian? [In reply to]

On 2012-06-24 11:45, Phil Pennock wrote:
> This patch:
> http://patch-tracker.debian.org/patch/series/view/exim4/4.80-2/30_dontoverridecflags.dpatch
> causes Exim to conditionally set CFLAGS in OS/Makefile-Linux using ?=
> syntax.
>
> That seems eminently sane to me. Does anyone know a reason to not
> apply this to base?

I'd suggest checking with builds on systems that might not use Gnu Make -
Solaris, HPUX, AIX &c.
--
Jeremy

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

pdp at exim

Jun 25, 2012, 3:21 AM

Post #6 of 6 (254 views)
Permalink

Re: Exim/Linux: CFLAGS fix from Debian? [In reply to]

On 2012-06-24 at 14:45 +0100, Jeremy Harris wrote:
> On 2012-06-24 11:45, Phil Pennock wrote:
> > This patch:
> > http://patch-tracker.debian.org/patch/series/view/exim4/4.80-2/30_dontoverridecflags.dpatch
> > causes Exim to conditionally set CFLAGS in OS/Makefile-Linux using ?=
> > syntax.
> >
> > That seems eminently sane to me. Does anyone know a reason to not
> > apply this to base?
>
> I'd suggest checking with builds on systems that might not use Gnu Make -
> Solaris, HPUX, AIX &c.

This is OS/Makefile-Linux. We permit the -variant files to use
system-specific Make syntax. For instance, OS/Makefile-FreeBSD uses
".ifdef" which with GNU Make would be spelt "ifdef".

-Phil

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads