Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: exim: dev
DCC header corruption
 

Index | Next | Previous | View Flat


stu at metanate

May 17, 2012, 2:40 AM


Views: 374
Permalink
DCC header corruption

I have recently been experiencing corruption and/or truncation of the DCC header being logged and added to my messages using the built-in exim dcc support in the data acl.

Upon investigation, I note that in dcc.c the global dcc_header is being pointed at a stack based string before the dcc code returns, despite the fact that there appears to be a global dcc_header_str which is presumably intended to have the header copied in to it and then dcc_header pointed at that.

Certainly replacing the following line (483 in src/dcc.c):

dcc_header = xhdr;

with

strncpy(dcc_header = dcc_header_str, xhdr, sizeof(dcc_header_str));

seems to cure the problem for me, although being unfamiliar with Exim's source base, it's not clear to me if this is the correct solution.

Regards

Stu


--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

Subject User Time
DCC header corruption stu at metanate May 17, 2012, 2:40 AM
    DCC header corruption stu at metanate May 18, 2012, 3:53 AM
        Re: DCC header corruption wbreyha at gmx May 18, 2012, 7:38 AM
        Re: DCC header corruption wbreyha at gmx May 18, 2012, 7:46 AM
            Re: DCC header corruption stu at metanate May 18, 2012, 8:03 AM
        Re: DCC header corruption marcin at mejor May 18, 2012, 9:32 AM
            Re: DCC header corruption pdp at exim May 18, 2012, 12:33 PM
                Re: DCC header corruption marcin at mejor May 18, 2012, 1:26 PM
                    Re: DCC header corruption pdp at exim May 18, 2012, 3:20 PM
                        Re: DCC header corruption marcin at mejor May 21, 2012, 2:15 AM
                            Re: DCC header corruption pdp at exim May 21, 2012, 2:41 AM

  Index | Next | Previous | View Flat
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.