nigel at dotdot
May 11, 2012, 1:35 AM
Post #2 of 2
(148 views)
Permalink
|
I'm somewhat stunned. A group of people have gone ahead with
implementation and maintenance of a patch to do this over a period of
nearly 8 years, and never bothered to to talk to the exim development
lists...
The patch as given has no documentation (other than the Readme) and no
tests. All the code is surrounded by #ifdef SUPPORT_DSN .
However, if enabled, there is a non backwards compatible spool file
format change, so backing out could be problematic.
A very quick skim of the internets seems to show little evidence of
people being happy with its functionality - there are various messages
saying "how do I use this" but few saying "this works well" - that may
just be that happy users have no reason to make noise.
No real comments on quality of implementation - looks cleanish, but I
don't fully understand the functionality.
My feeling is that I'd be happy for someone to integrate it with the
following caveats:-
1. Documentation updates for the main spec file
2. At least a review of what this does to the test suite - it will
break tests, so those tests need to be reviewed/updated
3. Ideally tests to support it
4. If at all possible make the spool file changes more portable
between DSN/Non-DSN versions
I suggest someone interested talk to us about it, and/or take a git fork
and implement at least 1 + 4. Remember even if you are not one of the
exim maintainers/committers, you can always clone the repo and offer a
branch back to us or fork on github - see http://wiki.exim.org/EximGit
Nigel.
David Saez Padros wrote:
> Hi
>
> would be great to have dsn support in exim, having this patch:
>
> http://sourceforge.net/projects/eximdsn
>
> applied to the main source code will help
>
--
[ Nigel Metheringham ------------------------------ nigel [at] dotdot ]
[ Ellipsis Intangible Technologies ]
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
|
