Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: exim: dev

[Bug 1224] testsuite fails for lsearch

 

 

exim dev RSS feed   Index | Next | Previous | View Threaded


tlyons at ivenue

Apr 16, 2012, 6:15 PM

Post #1 of 9 (535 views)
Permalink
[Bug 1224] testsuite fails for lsearch

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1224

Todd Lyons <tlyons [at] ivenue> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tlyons [at] ivenue




--- Comment #1 from Todd Lyons <tlyons [at] ivenue> 2012-04-17 02:15:14 ---
+1 for me too

Basic/0002 Common string expansions
===============f test-stderr-munged with stderr/0002 failed
Line 177 of "test-stderr-munged" does not match line 177 of "stderr/0002".
----------
5TESTSUITE/aux-fixed/0002.lsearch
----------
:TESTSUITE/aux-fixed/0002.lsearch
===============
Line 222 of "test-stderr-munged" does not match line 222 of "stderr/0002".
----------
5TESTSUITE/aux-fixed/0002.lsearch
----------
:TESTSUITE/aux-fixed/0002.lsearch
===============
2 differences found.
"test-stderr-munged" contains 363 lines; "stderr/0002" contains 363 lines.


exim-build [at] tlyon:~/projects/exim/src$ ./build-Linux-i386/exim -bV
Exim version 4.77_1112-f700899-XX #1 built 16-Apr-2012 08:47:36
Copyright (c) University of Cambridge, 1995 - 2007
Berkeley DB: Berkeley DB 4.7.25: (May 15, 2008)
Support for: crypteq iconv() Content_Scanning DKIM Old_Demime
Lookups (built-in): lsearch wildlsearch nwildlsearch iplsearch dbm dbmjz dbmnz
dnsdb mysql
Authenticators: plaintext
Routers: accept dnslookup ipliteral manualroute queryprogram redirect
Transports: appendfile/maildir/mbx autoreply pipe smtp
Fixed never_users: 0
Size of off_t: 4
Configuration file is /work/home/exim/tmp/etc/exim/exim.conf
exim-build [at] tlyon:~/projects/exim/src$


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


tlyons at ivenue

Apr 16, 2012, 6:56 PM

Post #2 of 9 (519 views)
Permalink
[Bug 1224] testsuite fails for lsearch [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1224




--- Comment #2 from Todd Lyons <tlyons [at] ivenue> 2012-04-17 02:56:07 ---
Created an attachment (id=561)
--> (http://bugs.exim.org/attachment.cgi?id=561)
gdb output of this symptom

gdb output while processing a sample command that generates this odd output.
Looking at the data in the struct, I see why it prints the undesired number,
but I do not quite understand how it prints out the actual filename because
that data does not appear to be in the struct.

The breakpoint starts at the first line below and steps through each line
shown:

debug_printf("LRU list:\n");
while (t != NULL)
{
search_cache *c = (search_cache *)(t->data.ptr);
debug_printf(" %s\n", t->name);
if (t == open_bot) debug_printf(" End\n");
t = c->down;
}
}

I don't understand what it is doing at this point.


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


pdp at exim

Apr 16, 2012, 9:47 PM

Post #3 of 9 (512 views)
Permalink
[Bug 1224] testsuite fails for lsearch [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1224




--- Comment #3 from Phil Pennock <pdp [at] exim> 2012-04-17 05:47:26 ---
Inline memory allocation, where a struct ends with a character array and the
storage allocated is sized to the struct plus the additional storage.

search.c:
524 else if (do_cache)
525 {
526 int len = keylength + 1;
527 t = store_get(sizeof(tree_node) + len);
528 memcpy(t->name, keystring, len);
529 t->data.ptr = data;
530 tree_insertnode(&c->item_cache, t);
531 }

The format of the data used as the key, in looking up the filename, is at:

353 sprintf(CS keybuffer, "%c%.254s", search_type + '0',
354 (filename == NULL)? US"" : filename);

Thus, as discussed with Jeremy, this is showing a ':' simply because ':' is
after '9' in ASCII, and the test suite currently assumes a fixed set of lookup
types and is not resilient to Exim being built with a different set of lookups.
The fix, which I believe Jeremy is preparing / has prepared, is to
canonicalise the lookup type index to some dummy value (eg, '0').


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


jgh146exb at wizmail

Apr 18, 2012, 1:34 PM

Post #4 of 9 (503 views)
Permalink
[Bug 1224] testsuite fails for lsearch [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1224

Jeremy Harris <jgh146exb [at] wizmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nigel [at] exim |jgh146exb [at] wizmail




--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


jgh146exb at wizmail

Apr 18, 2012, 1:36 PM

Post #5 of 9 (504 views)
Permalink
[Bug 1224] testsuite fails for lsearch [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1224

Jeremy Harris <jgh146exb [at] wizmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED




--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


git at exim

Apr 18, 2012, 5:17 PM

Post #6 of 9 (501 views)
Permalink
[Bug 1224] testsuite fails for lsearch [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1224

Git Commit <git [at] exim> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |git [at] exim




--- Comment #4 from Git Commit <git [at] exim> 2012-04-19 01:17:05 ---
Git commit:
http://git.exim.org/exim.git/commitdiff/44e6236daf6d9988dc66c1ce28b11fcc54d76a16

commit 44e6236daf6d9988dc66c1ce28b11fcc54d76a16
Author: Jeremy Harris <jgh146exb [at] wizmail>
AuthorDate: Thu Apr 19 00:43:11 2012 +0100
Commit: Jeremy Harris <jgh146exb [at] wizmail>
CommitDate: Thu Apr 19 00:43:11 2012 +0100

fix bug 1224.

replace the lookup index char in sterr traces with a zero;
update testcase expected stderr files to match.
----
test/runtest | 3 +
test/stderr/0002 | 4 +-
test/stderr/0085 | 18 ++--
test/stderr/0123 | 102 +++++++++---------
test/stderr/0387 | 32 +++---
test/stderr/0403 | 4 +-
test/stderr/0414 | 14 +-
test/stderr/0464 | 6 +-
test/stderr/0471 | 330 +++++++++++++++++++++++++++---------------------------
test/stderr/0484 | 30 +++---
10 files changed, 273 insertions(+), 270 deletions(-)


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


git at exim

Apr 18, 2012, 6:17 PM

Post #7 of 9 (502 views)
Permalink
[Bug 1224] testsuite fails for lsearch [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1224




--- Comment #5 from Git Commit <git [at] exim> 2012-04-19 02:17:04 ---
Git commit:
http://git.exim.org/exim.git/commitdiff/1bad4ba467f200ec1629bcd83cdaf76be5c1fe26

commit 1bad4ba467f200ec1629bcd83cdaf76be5c1fe26
Author: Jeremy Harris <jgh146exb [at] wizmail>
AuthorDate: Thu Apr 19 01:52:07 2012 +0100
Commit: Jeremy Harris <jgh146exb [at] wizmail>
CommitDate: Thu Apr 19 01:52:07 2012 +0100

Bug 1224 followon - avoid breaking other testcases.

Add specific patterns to avoid when munging the output.
This is fragile and may still be broken outside my specific test
environment.
---
test/runtest | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/test/runtest b/test/runtest
index ab87ab3..31aaaa9 100755
--- a/test/runtest
+++ b/test/runtest
@@ -687,8 +687,11 @@ RESET_AFTER_EXTRA_LINE_READ:
s/^\d\d\d(?=[PFS*])/ddd/;


- # Lookups have a char which depends on the number of lookup types compiled
in.
- s%(?<!lsearch)[0-?]TESTSUITE/aux-fixed/%0TESTSUITE/aux-fixed/%g;
+ # ========= Exim lookups ==================
+ # Lookups have a char which depends on the number of lookup types compiled
in,
+ # in stderr output. Replace with a "0". Recognising this while avoiding
+ # other output is fragile; perhaps the debug output should be revised
instead.
+
s%(?<!sqlite)(?<!lsearch\*@)(?<!lsearch\*)(?<!lsearch)[0-?]TESTSUITE/aux-fixed/%0TESTSUITE/aux-fixed/%g;

# ==========================================================
# Some munging is specific to the specific file types


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


git at exim

Apr 22, 2012, 3:17 PM

Post #8 of 9 (475 views)
Permalink
[Bug 1224] testsuite fails for lsearch [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1224




--- Comment #6 from Git Commit <git [at] exim> 2012-04-22 23:17:09 ---
Git commit:
http://git.exim.org/exim.git/commitdiff/b6f9e920ce28fb89c4905d54e4fee159172ad777

commit b6f9e920ce28fb89c4905d54e4fee159172ad777
Author: Jeremy Harris <jgh146exb [at] wizmail>
AuthorDate: Sun Apr 22 16:13:22 2012 +0100
Commit: Jeremy Harris <jgh146exb [at] wizmail>
CommitDate: Sun Apr 22 16:13:22 2012 +0100

bug 1224: fixup testsuite case output from testdb.
----
test/stderr/3212 | 22 +++++++++++-----------
1 files changed, 11 insertions(+), 11 deletions(-)


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


jgh146exb at wizmail

Apr 25, 2012, 1:27 PM

Post #9 of 9 (439 views)
Permalink
[Bug 1224] testsuite fails for lsearch [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1224

Jeremy Harris <jgh146exb [at] wizmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED




--- Comment #7 from Jeremy Harris <jgh146exb [at] wizmail> 2012-04-25 21:27:31 ---
I think most of the failing cases have been found now.


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

exim dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.