Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: exim: dev

[Bug 1226] testsuite trips on ls output

 

 

exim dev RSS feed   Index | Next | Previous | View Threaded


jgh146exb at wizmail

Mar 27, 2012, 2:09 PM

Post #1 of 5 (287 views)
Permalink
[Bug 1226] testsuite trips on ls output

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1226

Jeremy Harris <jgh146exb [at] wizmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED




--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


jgh146exb at wizmail

Mar 27, 2012, 4:16 PM

Post #2 of 5 (274 views)
Permalink
[Bug 1226] testsuite trips on ls output [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1226

Jeremy Harris <jgh146exb [at] wizmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nigel [at] exim |jgh146exb [at] wizmail
Status|ASSIGNED |NEW




--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


jgh146exb at wizmail

Mar 28, 2012, 12:56 PM

Post #3 of 5 (268 views)
Permalink
[Bug 1226] testsuite trips on ls output [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1226

Jeremy Harris <jgh146exb [at] wizmail> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED




--- Comment #1 from Jeremy Harris <jgh146exb [at] wizmail> 2012-03-28 20:56:43 ---
Suggested fix: apply the following diff to the "runtest" script,
then run the 0240 testcase and accept the new output
(there should now always be a trailing space, but no ACL indicator).

--------%cut here%--------
diff --git a/test/runtest b/test/runtest
index 6a6aadd..165351c 100755
--- a/test/runtest
+++ b/test/runtest
@@ -593,7 +593,13 @@ RESET_AFTER_EXTRA_LINE_READ:

# ======== Output from ls ========
# Different operating systems use different spacing on long output
- s/ +/ /g if /^[-rwd]{10} /;
+ #s/ +/ /g if /^[-rwd]{10} /;
+ # (Bug 1226) SUSv3 allows a trailing printable char for modified access
method control.
+ # Handle only the Gnu and MacOS space, dot, plus and at-sign. A full
[[:graph:]]
+ # unfortunately matches a non-ls linefull of dashes.
+ # Allow the case where we've already picked out the file protection bits.
+ s/^([-d]([-r][-w][-stx]){3})[.+@]?( +|$)/\1 /;
+


# ======== Message sizes =========
--------%cut here%--------


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


pdp at exim

Mar 30, 2012, 1:55 PM

Post #4 of 5 (254 views)
Permalink
[Bug 1226] testsuite trips on ls output [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1226

Phil Pennock <pdp [at] exim> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |pdp [at] exim
Status|ASSIGNED |RESOLVED
Resolution| |FIXED




--- Comment #2 from Phil Pennock <pdp [at] exim> 2012-03-30 21:55:10 ---
Fixed in c1e49b7.

I took your text but modified the regexp slightly. Mostly to handle other
possible 'x' position values, as both 't' and 's' can be capitalised if the 'x'
bit is absent.


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


git at exim

Mar 30, 2012, 2:17 PM

Post #5 of 5 (255 views)
Permalink
[Bug 1226] testsuite trips on ls output [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=1226

Git Commit <git [at] exim> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |git [at] exim




--- Comment #3 from Git Commit <git [at] exim> 2012-03-30 22:17:12 ---
Git commit:
http://git.exim.org/exim.git/commitdiff/c1e49b796a61a19bc61e8c6349e90614690189a0

commit c1e49b796a61a19bc61e8c6349e90614690189a0
Author: Phil Pennock <pdp [at] exim>
AuthorDate: Fri Mar 30 13:52:17 2012 -0700
Commit: Phil Pennock <pdp [at] exim>
CommitDate: Fri Mar 30 13:52:17 2012 -0700

Handle alternate access method flag in ls.

Jeremy Harris found ls output not parsing on SELinux systems. I
identified this as SUSv3's "optional alternate access method flag".
Jeremy wrote the patch, I adjusted a little.

fixes bug 1226
---
test/runtest | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/test/runtest b/test/runtest
index 4543915..2a8dd16 100755
--- a/test/runtest
+++ b/test/runtest
@@ -593,7 +593,12 @@ RESET_AFTER_EXTRA_LINE_READ:

# ======== Output from ls ========
# Different operating systems use different spacing on long output
- s/ +/ /g if /^[-rwd]{10} /;
+ #s/ +/ /g if /^[-rwd]{10} /;
+ # (Bug 1226) SUSv3 allows a trailing printable char for modified access
method control.
+ # Handle only the Gnu and MacOS space, dot, plus and at-sign. A full
[[:graph:]]
+ # unfortunately matches a non-ls linefull of dashes.
+ # Allow the case where we've already picked out the file protection bits.
+ s/^([-d](?:[-r][-w][-SsTtx]){3})[.+@]?( +|$)/\1 /;


# ======== Message sizes =========


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

exim dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.