Mailing List Archive: exim: dev

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

Index | Next | Previous | View Threaded

wbreyha at gmx

Nov 10, 2009, 5:08 AM

Post #1 of 11 (1442 views)
Permalink

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

Wolfgang Breyha <wbreyha [at] gmx> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |wbreyha [at] gmx

--- Comment #1 from Wolfgang Breyha <wbreyha [at] gmx> 2009-11-10 13:08:19 ---
I fixed the rest of "-W all" warnings for dcc.c. patch attached. patch is
against >exim-4.70-CVS.2009.11.09-differ_in_signedness.patch< !

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

wbreyha at gmx

Nov 10, 2009, 5:09 AM

Post #2 of 11 (1393 views)
Permalink

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100) [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #2 from Wolfgang Breyha <wbreyha [at] gmx> 2009-11-10 13:09:34 ---
Created an attachment (id=342)
--> (http://bugs.exim.org/attachment.cgi?id=342)
dcc.c fixes (unused variables, pointer fix)

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

serge at srv0

Nov 10, 2009, 5:46 AM

Post #3 of 11 (1385 views)
Permalink

Re: [Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100) [In reply to]

Le Tuesday 10 November 2009 14:09:34 Wolfgang Breyha, vous avez écrit :
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
>
> http://bugs.exim.org/show_bug.cgi?id=905
>
>
>
>
> --- Comment #2 from Wolfgang Breyha <wbreyha [at] gmx> 2009-11-10 13:09:34
> --- Created an attachment (id=342)
> --> (http://bugs.exim.org/attachment.cgi?id=342)
> dcc.c fixes (unused variables, pointer fix)
>
>
> --
> Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

Hi,

with your last patch, it still remains:

312c312
< debug_printf("\n****************************\n", sendbuf);
---
> debug_printf("\n****************************\n%s", sendbuf);
363c363
< while(resp = read(sockfd, recvbuf, sizeof(recvbuf)-1) > 0) {
---
> while((resp = read(sockfd, recvbuf, sizeof(recvbuf)-1)) > 0) {
388c388
< dcc_result = "A";
---
> dcc_result = US"A";
394c394
< dcc_result = "R";
---
> dcc_result = US"R";
410c410
< dcc_result = "A";
---
> dcc_result = US"A";
417c417
< dcc_result = "G";
---
> dcc_result = US"G";
426c426
< dcc_result = "T";
---
> dcc_result = US"T";
434c434
< dcc_result = "T";
---
> dcc_result = US"T";
500c500
< if (((xtra_hdrs = expand_string("$acl_m_dcc_add_header")) != NULL) &&
(xtra_hdrs[0] != '\0')) {
---
> if (((xtra_hdrs = expand_string(US"$acl_m_dcc_add_header")) != NULL) &&
(xtra_hdrs[0] != '\0')) {

---------------------------------------
Regards
--Serge

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

nigel at exim

Nov 11, 2009, 2:08 AM

Post #4 of 11 (1378 views)
Permalink

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100) [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #3 from Nigel Metheringham <nigel [at] exim> 2009-11-11 10:08:03 ---
CVS commit by nm4:

Applied signed/unsigned fixes. Need confirmation that this completely deals
with bug. Related: bug#905

--- CVS commit summary ---
1.3 1.4 +12 -32 - exim/exim-src/src/dcc.c
1.19 1.20 +1 -1 - exim/exim-src/src/dns.c
1.17 1.18 +1 -1 - exim/exim-src/src/malware.c
1.18 1.19 +2 -2 - exim/exim-src/src/mime.c
1.50 1.51 +3 -2 - exim/exim-src/src/receive.c
1.8 1.9 +5 -5 - exim/exim-src/src/spf.c

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

serge-exim at srv0

Nov 11, 2009, 5:29 AM

Post #5 of 11 (1369 views)
Permalink

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100) [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

Serge Demonchaux <serge-exim [at] srv0> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |serge-exim [at] srv0

--- Comment #4 from Serge Demonchaux <serge-exim [at] srv0> 2009-11-11 13:29:48 ---
Very good.

src/dns.c ===> OK
src/dcc.c ===> OK
src/malware.c ===> OK
src/mime.c ===> OK
src/receive.c ===> OK
src/spf.c ===> OK

I'm missed this 'src/lookups/spf.c'
========================
--- /caos.dev/usr/src/rpm/BUILD/exim-4.70CVS/src/lookups/spf.c.ORI 2009-11-11
12:00:26 +0100
+++ /caos.dev/usr/src/rpm/BUILD/exim-4.70CVS/src/lookups/spf.c 2009-11-11
12:00:17 +0100
@@ -59,11 +59,11 @@
return FAIL;
}

- if (SPF_request_set_ipv4_str(spf_request, filename)) {
+ if (SPF_request_set_ipv4_str(spf_request, CS filename)) {
*errmsg = string_sprintf("invalid IP address '%s'", filename);
return FAIL;
}
- if (SPF_request_set_env_from(spf_request, keystring)) {
+ if (SPF_request_set_env_from(spf_request, CS keystring)) {
*errmsg = string_sprintf("invalid envelope from address '%s'",
keystring);
return FAIL;
}
========================

With Linux i386 + GCC (-Wall), Exim is compiled well. On the x86_64
AMD , there are problems with 'off_t': (build-Linux-x86_64/config.h)

#ifndef OFF_T_FMT
#define OFF_T_FMT "%lld"
#define LONGLONG_T long long int
#endif

[...]
appendfile.c:2641: warning: format '%lld' expects type 'long long int', but
argument 3 has type 'off_t'
[...]

by changing the definitions, i have no warnings

build-Linux-x86_64/config.h:

--- exim-4.70/build-Linux-x86_64/config.h.ORI 2009-11-11 14:24:47 +0100
+++ exim-4.70/build-Linux-x86_64/config.h 2009-11-11 14:25:54 +0100
@@ -7,12 +7,12 @@
Do not edit it. Instead, edit Local/Makefile and rerun make. */

#ifndef OFF_T_FMT
-#define OFF_T_FMT "%lld"
+#define OFF_T_FMT "%" PRIi64
#define LONGLONG_T int64_t
#endif

#ifndef TIME_T_FMT
-#define TIME_T_FMT "%lld"
+#define TIME_T_FMT "%" PRIi64
#undef LONGLONG_T
#define LONGLONG_T int64_t
#endif

Regards,
--Serge

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

nigel at exim

Nov 11, 2009, 6:43 AM

Post #6 of 11 (1363 views)
Permalink

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100) [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #5 from Nigel Metheringham <nigel [at] exim> 2009-11-11 14:43:29 ---
CVS commit by nm4:

More signed/unsigned fixes. Need confirmation that this completely deals with
bug. Related: bug#905

--- CVS commit summary ---
1.2 1.3 +2 -2 - exim/exim-src/src/lookups/spf.c

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

nigel at exim

Nov 11, 2009, 6:45 AM

Post #7 of 11 (1368 views)
Permalink

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100) [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #6 from Nigel Metheringham <nigel [at] exim> 2009-11-11 14:45:03 ---
We need to change those config.h changes to a Makefile or buildconfig.c
patch.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

serge-exim at srv0

Nov 11, 2009, 7:14 AM

Post #8 of 11 (1365 views)
Permalink

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100) [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #7 from Serge Demonchaux <serge-exim [at] srv0> 2009-11-11 15:14:14 ---
> More signed/unsigned fixes. Need confirmation that this completely deals
> with bug. Related: bug#905

src/dns.c ===> OK
src/dcc.c ===> OK
src/malware.c ===> OK
src/mime.c ===> OK
src/receive.c ===> OK
src/spf.c ===> OK
src/lookups/spf.c ===> OK

------- Comment #6 From Nigel Metheringham 2009-11-11 14:45:03
> We need to change those config.h changes to a Makefile or buildconfig.c
> patch.

...or to leave the choie to the packager? I would not be to answer.
Call the list about this ?

See more about 'off_t' with "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
<http://lists.freebsd.org/pipermail/freebsd-arch/2005-December/004685.html>

In Linux x86 with "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
$ uname -m == i686
sizeof(test_off_t) == 8

In Linux x86 withOUT "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
$ uname -m == i686
sizeof(test_off_t) == 4

In Linux x86_64 with "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
$ uname -m == x86_64
sizeof(test_off_t) == 8

=============start=====================
--- exim-4.70/src/buildconfig.c.ORI 2009-11-11 15:05:15 +0100
+++ exim-4.70/src/buildconfig.c 2009-11-11 15:05:33 +0100
@@ -147,8 +147,8 @@
fprintf(new, "#ifndef OFF_T_FMT\n");
if (sizeof(test_off_t) > 4)
{
- fprintf(new, "#define OFF_T_FMT \"%%lld\"\n");
- fprintf(new, "#define LONGLONG_T long long int\n");
+ fprintf(new, "#define OFF_T_FMT \"%%\" PRIi64\n");
+ fprintf(new, "#define LONGLONG_T int64_t\n");
}
else
{
@@ -165,9 +165,9 @@
fprintf(new, "#ifndef TIME_T_FMT\n");
if (sizeof(test_time_t) > 4)
{
- fprintf(new, "#define TIME_T_FMT \"%%lld\"\n");
+ fprintf(new, "#define TIME_T_FMT \"%%\" PRIi64\n");
fprintf(new, "#undef LONGLONG_T\n");
- fprintf(new, "#define LONGLONG_T long long int\n");
+ fprintf(new, "#define LONGLONG_T int64_t\n");
}
else
{
=============end=====================

Best regards,
--Serge

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

nigel at exim

Nov 11, 2009, 7:49 AM

Post #9 of 11 (1357 views)
Permalink

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100) [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #8 from Nigel Metheringham <nigel [at] exim> 2009-11-11 15:49:14 ---
I'm not willing to take the buildconfig.c changes unless we can ensure that
this will not break older (or non linux/bsd) systems.

Are there any 64 bit systems which have older C libraries?
I guess this is the case since I was using Alpha based systems more
than 15 years back...

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

serge-exim at srv0

Nov 11, 2009, 8:52 AM

Post #10 of 11 (1348 views)
Permalink

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100) [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

--- Comment #9 from Serge Demonchaux <serge-exim [at] srv0> 2009-11-11 16:52:22 ---
---- Comment #8 From Nigel Metheringham 2009-11-11 15:49:14 -------
> I'm not willing to take the buildconfig.c changes unless we can ensure that
> this will not break older (or non linux/bsd) systems.
>
> Are there any 64 bit systems which have older C libraries?
> I guess this is the case since I was using Alpha based systems more
> than 15 years back...

I'm in complete agreement with you on this. We are only sure for the x86_64.

We are too close to the release to consider this change. The next time after
tests in CVS...

Now it is possible to inform in documentation of this option of compilation.

See: ISO C99: 7.8 Format conversion of integer types <inttypes.h>
/usr/include/inttypes.h

Regards,
--Serge

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

serge-exim at srv0

Nov 11, 2009, 9:00 AM

Post #11 of 11 (1357 views)
Permalink

[Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100) [In reply to]

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads