Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: exim: dev

[Bug 39] decoding of base64 MIME parts does not work for unusual line lengths

 

 

exim dev RSS feed   Index | Next | Previous | View Threaded


nigel at exim

Nov 6, 2009, 5:29 AM

Post #1 of 3 (570 views)
Permalink
[Bug 39] decoding of base64 MIME parts does not work for unusual line lengths

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=39

Nigel Metheringham <nigel [at] exim> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED




--- Comment #11 from Nigel Metheringham <nigel [at] exim> 2009-11-06 13:29:47 ---
CVS commit by nm4:

Base64 decode bug fixes. Fixes: bug#39

--- CVS commit summary ---
1.587 1.588 +3 -0 - exim/exim-doc/doc-txt/ChangeLog
1.15 1.16 +147 -151 - exim/exim-src/src/mime.c


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


jh.exim-bugzilla at plonk

Nov 7, 2009, 5:28 AM

Post #2 of 3 (517 views)
Permalink
[Bug 39] decoding of base64 MIME parts does not work for unusual line lengths [In reply to]

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=39

Jakob Hirsch <jh.exim-bugzilla [at] plonk> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC|jh.exim [at] plonk |nigel [at] exim
Status|RESOLVED |REOPENED
Resolution|FIXED |




--- Comment #12 from Jakob Hirsch <jh.exim-bugzilla [at] plonk> 2009-11-07 13:28:14 ---
little change, sorry for being late:

diff --git a/src/mime.c b/src/mime.c
index 9c7ac32..f15ffea 100644
--- a/src/mime.c
+++ b/src/mime.c
@@ -341,7 +341,7 @@ int mime_decode(uschar **listptr) {
clearerr(mime_stream);
fseek(mime_stream, f_pos, SEEK_SET);

- if (size_counter < 0 || fclose(decode_file) != 0)
+ if (fclose(decode_file) != 0 || size_counter < 0)
return DEFER;

/* round up to the next KiB */


fclose() should always be done, but the impact is not that big, as
mime_decode() is only done by short-lived processes and we return DEFER, so no
content scanning will be done, but still...


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##


nigel at exim

Nov 7, 2009, 9:17 AM

Post #3 of 3 (520 views)
Permalink
[Bug 39] decoding of base64 MIME parts does not work for unusual line lengths [In reply to]

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=39

Nigel Metheringham <nigel [at] exim> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED




--- Comment #13 from Nigel Metheringham <nigel [at] exim> 2009-11-07 17:17:18 ---
CVS commit by nm4:

Fix close buglet in mime handling. Fixes: bug#39

--- CVS commit summary ---
1.16 1.17 +1 -1 - exim/exim-src/src/mime.c


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

exim dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.