Mailing List Archive: exim: dev

[Bug 870] Compile warnings for new DKIM code

Index | Next | Previous | View Threaded

dwmw2 at infradead

Aug 27, 2009, 4:02 AM

Post #1 of 3 (1030 views)
Permalink

[Bug 870] Compile warnings for new DKIM code

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=870

David Woodhouse <dwmw2 [at] infradead> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |dwmw2 [at] infradead
Priority|medium |high

--- Comment #1 from David Woodhouse <dwmw2 [at] infradead> 2009-08-27 12:02:09 ---
The one in expand.c is fairly harmless, and could be handled by just changing
the datatype to a 'long'.

The ones in dkim.c are very much _not_ harmless, AFAICT. When you ask it to
expand $dkim_algo, $dkim_canon_body or $dkim_canon_headers, it looks like it's
going to return the value of an integer field, when it should be returning a
string. This isn't an "I think I can store pointers in an int" bug -- it's
actually returning _real_ integer values, AFAICT. It looks like it'll crash.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

dwmw2 at infradead

Aug 27, 2009, 4:07 AM

Post #2 of 3 (941 views)
Permalink

[Bug 870] Compile warnings for new DKIM code [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=870

--- Comment #2 from David Woodhouse <dwmw2 [at] infradead> 2009-08-27 12:07:25 ---
Created an attachment (id=323)
--> (http://bugs.exim.org/attachment.cgi?id=323)
potential fix

This may fix it. I removed the checking of ->algo, ->canon_body and
->canon_headers against zero, because zero is a perfectly valid value for
those. I think these fields will _always_ be set to something valid if
dkim_cur_sig is non-NULL?

Tom?

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

tom at duncanthrax

Aug 31, 2009, 2:16 PM

Post #3 of 3 (913 views)
Permalink

[Bug 870] Compile warnings for new DKIM code [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=870

Tom Kistner <tom [at] duncanthrax> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED

--- Comment #3 from Tom Kistner <tom [at] duncanthrax> 2009-08-31 22:16:34 ---
Fixed :) Thanks for the patch. I opted not to pull in the string constants from
the pdkim side.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads