Mailing List Archive: exim: dev

[Bug 846] [PATCH] Push headers added by acl to spamd

Index | Next | Previous | View Threaded

temnota.am at gmail

Apr 29, 2009, 9:40 AM

Post #1 of 7 (1154 views)
Permalink

[Bug 846] [PATCH] Push headers added by acl to spamd

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=846

--- Comment #1 from Andrey Jr. Melnikov <temnota.am[at]gmail.com> 2009-04-29 17:40:58 ---
Created an attachment (id=313)
--> (http://bugs.exim.org/attachment.cgi?id=313)
src/spool_mbox.c patch

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

johannes at sipsolutions

Apr 30, 2009, 1:15 AM

Post #2 of 7 (1081 views)
Permalink

[Bug 846] [PATCH] Push headers added by acl to spamd [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=846

--- Comment #2 from Johannes Berg <johannes[at]sipsolutions.net> 2009-04-30 09:15:44 ---
I like this, but think it should be optional because it's a significant change
in behaviour.

Maybe by a global variable, or an option such as
spam = <username>/acl_headers

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

johannes at sipsolutions

Apr 30, 2009, 1:17 AM

Post #3 of 7 (1078 views)
Permalink

[Bug 846] [PATCH] Push headers added by acl to spamd [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=846

--- Comment #3 from Johannes Berg <johannes[at]sipsolutions.net> 2009-04-30 09:17:14 ---
Also, shouldn't added header lines come after the original ones? Or do they? I
can't really tell in your patch. How about leaving out deleted header lines?

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

exim-users at lists

Apr 30, 2009, 1:37 AM

Post #4 of 7 (1072 views)
Permalink

[Bug 846] [PATCH] Push headers added by acl to spamd [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=846

Mike Cardwell <exim-users[at]lists.grepular.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |exim-
| |users[at]lists.grepular.com

--- Comment #4 from Mike Cardwell <exim-users[at]lists.grepular.com> 2009-04-30 09:37:43 ---
I agree that there should be a switch to turn this on as it's not going to be
backwards compatible with some peoples config. It's the sort of thing that
could be turned on by default after a major revision change eg Exim4 to Exim5.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

temnota.am at gmail

Apr 30, 2009, 3:16 AM

Post #5 of 7 (1072 views)
Permalink

[Bug 846] [PATCH] Push headers added by acl to spamd [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=846

--- Comment #5 from Andrey Jr. Melnikov <temnota.am[at]gmail.com> 2009-04-30 11:16:31 ---
I think adding new switch '/acl_headers' is overload. Exim already overloaded
with 'small significant switch specific to this command' and read complex
configuration - not easy.
Headers specially added after first Recivied line, to avoid mess with DKIM
signed headers.
If someone really want add headers invisible to spam scaninng - just rearrange
acl and add it later, after spam scanning command.

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

exim-users at lists

Apr 30, 2009, 3:28 AM

Post #6 of 7 (1075 views)
Permalink

[Bug 846] [PATCH] Push headers added by acl to spamd [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=846

--- Comment #6 from Mike Cardwell <exim-users[at]lists.grepular.com> 2009-04-30 11:28:42 ---
(In reply to comment #5)

> I think adding new switch '/acl_headers' is overload. Exim already overloaded
> with 'small significant switch specific to this command' and read complex
> configuration - not easy.
> Headers specially added after first Recivied line, to avoid mess with DKIM
> signed headers.
> If someone really want add headers invisible to spam scaninng - just rearrange
> acl and add it later, after spam scanning command.

Adding extra config to turn on your feature isn't ideal, correct. However, all
minor revision changes should be backwards compatible or you break systems. As
I understand it, this is the way Exim updates have always happened. If we were
moving from Exim 4 to Exim 5 rather than from one version of Exim 4 to another
then yes, it would be ok, but we're not...

The majority of people don't expect upgrading from 4.69 to 4.70 to require them
to change their configuration, for things to continue to work as normal.

Mike

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

johannes at sipsolutions

May 1, 2009, 1:36 AM

Post #7 of 7 (1074 views)
Permalink

[Bug 846] [PATCH] Push headers added by acl to spamd [In reply to]

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=846

--- Comment #7 from Johannes Berg <johannes[at]sipsolutions.net> 2009-05-01 09:36:40 ---
(In reply to comment #6)

> Adding extra config to turn on your feature isn't ideal, correct. However, all
> minor revision changes should be backwards compatible or you break systems. As
> I understand it, this is the way Exim updates have always happened. If we were
> moving from Exim 4 to Exim 5 rather than from one version of Exim 4 to another
> then yes, it would be ok, but we're not...
>
> The majority of people don't expect upgrading from 4.69 to 4.70 to require them
> to change their configuration, for things to continue to work as normal.

Exactly. As much as I like the feature and would love to have it, I don't think
there's a chance it can be added soon. I'd rather have it soon with config
option rather than wait (probably forever) until it can be added a little
cleaner.

It's also not always trivial to add header lines after spam scanning, since you
might have code adding header lines in ACLs before DATA, and now you'd have to
rewrite your config to store those in an acl_m_ variable and add them later
${if def:acl_m_...} -- rather complex.

Also, can you explain DKIM considerations? Exim always seems to add header
lines after (or before) all others and afaik DKIM says explicitly which are
signed, so I'm not sure I see the problem?

--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com