Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: exim: dev

4.51 Transport Filter Timeout patch

 

 

exim dev RSS feed   Index | Next | Previous | View Threaded


ben at cpanel

May 4, 2005, 11:28 AM

Post #1 of 2 (81 views)
Permalink
4.51 Transport Filter Timeout patch

The recent patch to correct the timeout issue with spamd does not work
as expected. Since the transport filter has timed out, it sends a
malformed or incomplete data stream. This patch kills of the child
process and prevents checking of its exit status. This should prevent
the transport filter timeout message from getting overwritten by the
child's exit error.
--
Ben M. Thomas <ben [at] cpanel>
cPanel Inc.
Attachments: exim-transport_filter_timeout-4.51.patch (0.99 KB)


ph10 at cus

May 5, 2005, 2:17 AM

Post #2 of 2 (78 views)
Permalink
Re: 4.51 Transport Filter Timeout patch [In reply to]

On Wed, 4 May 2005, Ben M. Thomas wrote:

> The recent patch to correct the timeout issue with spamd does not work
> as expected. Since the transport filter has timed out, it sends a
> malformed or incomplete data stream. This patch kills of the child
> process and prevents checking of its exit status. This should prevent
> the transport filter timeout message from getting overwritten by the
> child's exit error.

In the 4.51 release (released yesterday) I put in something similar to
the patch (but with a default FAIL rather than DEFER, to match what
happens for a pipe process timeout). In my tests on Gentoo Linux, the
transport filter timeout message did not get overwritten.

However, I am sure that the behaviour is probably highly dependent on
the operating system, the pipe command, and on exactly the timing
characteristics of a particular case.

It is now possible for the transport to detect whether it was the
transport filter that timed out, or the pipe command itself. I suppose
that it should refrain from overwriting the error message if it knows
the transport filter timed out. I will think about this.

--
Philip Hazel University of Cambridge Computing Service,
ph10 [at] cus Cambridge, England. Phone: +44 1223 334714.
Get the Exim 4 book: http://www.uit.co.uk/exim-book

exim dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.