Vassilii.Khachaturov at comverse
Aug 19, 2002, 7:03 AM
Post #5 of 7
(7472 views)
Permalink
|
|
RE: Re: dfilter2sgml patched to handle DOCSIS
[In reply to]
|
|
Hi Anand,
thanks for your retesting attempts.
I have just reviewed the exact contents of what had been checked
in by Guy yesterday. It turns out that the patch
against the 'ethereal-doc' version of dfilter2sgml wasn't applied,
and hence you are still having your problem.
Anand+Guy: Attached is the rediffed remaining portion of the patch,
to be applied against the current ethereal-doc/dfilter2sgml.
For retesting (works here!), proceed from (2') below using the
attached patch.
Guy: maybe you'd like to eliminate the orphaned clone of dfilter2sgml
from ethereal/doc/, or at least make it a link to
ethereal-doc/dfilter2sgml.
Kind regards,
Vassilii
-----Original Message-----
From: Anand V. Narwani [mailto:anarwani [at] cisco]
Sent: Monday, August 19, 2002 9:10 AM
To: Vassilii Khachaturov
Cc: ethereal-doc [at] ethereal
Subject: [Ethereal-doc] Re: dfilter2sgml patched to handle DOCSIS
Vassilii,
Sorry... It's taken a while to get this done. I noticed that Guy checked in
your patch so I decided to pull down the latest CVS source and test it with
that. After spending a few minutes getting db2pdf installed on my system, I
noticed that I am still seeing the problems with the DOCSIS source. Here's
the make_user-guide.log:
Using catalogs: /etc/sgml/sgml-docbook-4.1.cat
Using stylesheet:
/usr/share/sgml/docbook/utils-0.6.9/docbook-utils.dsl#print
Working on: /home/docsis/ethereal-doc/user-guide.sgml
jade:/home/docsis/ethereal-doc/./ug-src/filter-fields.sgml:7065:13:E:
character "'" is not allowed in the value of attribute "ID"
jade:/home/docsis/ethereal-doc/./ug-src/filter-fields.sgml:7067:11:E:
character "'" is not allowed in the value of attribute "ID"
I looked at the two offending entries in filter-fields.sgml and removed the
's from the ID fields it compiles fine. I'm not sure if you want me to
modify the string in the disector or if you want to modify the script that
generates the filter-fields.sgml file. Let me know if there's anything I can
do...
Anand
At 05:02 PM 8/17/2002 -0400, Vassilii Khachaturov wrote:
No apologies needed - I'm aware that most of the work effort is concentrated
on real
dissecting issues and hence the doc-related things tend to get
overlooked. I'm in the docs
myself just because I am a newbie in ethereal-dev so I started looking
in the docs more
than an avg developer :-)
1) You can verify the bug by setting up the ethereal-doc env,
and then (using the latest CVS ethereal)
do a manual
ethereal -G | ./dfilter2sgml sgml.doc.template >
ug-src/filter-fields.sgml
in the ethereal-doc tree, and then perform a make. It is broken for me
because of DOCSIS autogenerated entries.
2) My patch consists of 2 parts.
First thing you have to do is to apply my patch from
http://www.ethereal.com/lists/ethereal-dev/200208/msg00121.html
in the 'ethereal' cvs module environment, and compile that.
Its portion applying to doc/dfilter2sgml is irrelevant - turns out
ethereal-doc has a more recent copy of the same script.
This will expand ethereal -G output to include the 'blurb'.
If you build this, you'll see more verbose ethereal/tethereal manpages.
2') Next, apply the patch from
http://www.ethereal.com/lists/ethereal-doc/200208/msg00001.html
in the 'ethereal-doc' cvs module environment, and proceed
as per the instructions in (1) above to re-test the user guide build -
it should work now - both with the DOCSIS breakage fix
and with more verbose tables - with a 4th column 'Description'
to include the hfinfo->blurb.
3a) If it doesn't work for you, bug me!
3b) If it does, use your good name around here to ask the busy
guys responsible for the check-ins to please apply the patches in the
cvs env;
as well as resolve the cvs adm. issues raised in the above linked
message from ethereal-doc.
:-)))
Kind regards,
Vassilii
----- Original Message -----
From: "Anand V. Narwani" <anarwani [at] cisco>
To: "Khachaturov Vassilii" <Vassilii.Khachaturov [at] comverse>
Cc: <ethereal-doc [at] ethereal>
Sent: Friday, August 16, 2002 4:13 PM
Subject: Re: dfilter2sgml patched to handle DOCSIS
Hi Vassilli,
My apologies, I must have missed that thread. I just looked at the man
pages generated from the CVS build and it seems that the DOCSIS stuff is
all there. Do you have a copy of the patch and can you point me to how I
can verify if it fixes the user guide?
Sorry for being a bit clueless...
Anand
At 12:11 PM 8/16/2002 -0400, Khachaturov Vassilii wrote:
>Hi Anand,
>I'm writing this to you as you seem to be the DOCSIS dissector guy.
>My recent patch fixes handling of the new DOCSIS stuff in
>the user guide build processing, see the thread
>
>[PATCH] -G option & doc/dfilter... change to include hfinfo->blurb
>
>on ethereal-dev [epan/proto.c & doc/dfilter2pod.pl changes]/
>ethereal-doc[dfilter2sgml changes], yet I got no feedback on it so far.
>Perhaps if you could check it works indeed for you & then confirm
>it on the list, it will expedite the patch acceptance?
>
>Right now the user guide build from the most recent CVS
>ethereal's -G output is broken on the DOCSIS sections.
--
Anand V. Narwani, CCIE 3892
Advanced Engineering Services
Cisco Systems, Inc.
Direct/Fax: 919.392.3404
Email: anarwani [at] cisco
"Meddle not in the affairs of dragons, for you are crunchy and taste good
with ketchup"
|
dfilter2sgml.patch
