From 4b33ccc72a9a3b8199990b5439834afe999d73a2 Mon Sep 17 00:00:00 2001
From: Christian Loos <cloos@netcologne.de>
Date: Thu, 16 Dec 2010 13:17:15 +0100
Subject: [PATCH 2/7] only record transaction on success

---
 lib/RT/Reminders.pm |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/lib/RT/Reminders.pm b/lib/RT/Reminders.pm
index 70cf67c..49d8183 100644
--- a/lib/RT/Reminders.pm
+++ b/lib/RT/Reminders.pm
@@ -116,7 +116,7 @@ sub Add {
     );
 
     my $reminder = RT::Ticket->new($self->CurrentUser);
-    $reminder->Create(
+    my ( $status, $msg ) = $reminder->Create(
         Subject => $args{'Subject'},
         Owner => $args{'Owner'},
         Due => $args{'Due'},
@@ -128,30 +128,33 @@ sub Add {
         Type => 'AddReminder',
         Field => 'RT::Ticket',
         NewValue => $reminder->id
-    );
+    ) if $status;
+    return ( $status, $msg );
 }
 
 sub Open {
     my $self = shift;
     my $reminder = shift;
 
-    $reminder->SetStatus('open');
+    my ( $status, $msg ) = $reminder->SetStatus('open');
     $self->TicketObj->_NewTransaction(
         Type => 'OpenReminder',
         Field => 'RT::Ticket',
         NewValue => $reminder->id
-    );
+    ) if $status;
+    return ( $status, $msg );
 }
 
 sub Resolve {
     my $self = shift;
     my $reminder = shift;
-    $reminder->SetStatus('resolved');
+    my ( $status, $msg ) = $reminder->SetStatus('resolved');
     $self->TicketObj->_NewTransaction(
         Type => 'ResolveReminder',
         Field => 'RT::Ticket',
         NewValue => $reminder->id
-    );
+    ) if $status;
+    return ( $status, $msg );
 }
 
 RT::Base->_ImportOverlays();
-- 
1.7.1