bugtrack at dbmail
Apr 9, 2012, 3:35 AM
Post #4 of 4
(195 views)
Permalink
|
|
[DBMail 0000966]: Completion of error handling
[In reply to]
|
|
The following issue has been CLOSED
======================================================================
http://www.dbmail.org/mantis/view.php?id=966
======================================================================
Reported By: elfring
Assigned To:
======================================================================
Project: DBMail
Issue ID: 966
Category: General
Reproducibility: have not tried
Severity: major
Priority: normal
Status: closed
target:
Resolution: won't fix
Fixed in Version:
======================================================================
Date Submitted: 08-Apr-12 19:10 CEST
Last Modified: 09-Apr-12 12:35 CEST
======================================================================
Summary: Completion of error handling
Description:
I have looked at a few source files for your current software. I have
noticed that some checks for return codes are missing.
Would you like to add more error handling for return values from functions
like the following?
- chmod ⇒ pidfile_create
https://github.com/pjstevns/dbmail/blob/c93755763d1608c549b246e222cf3ae1d45e5d97/src/dm_pidfile.c#L98
- printf ⇒ main
https://github.com/pjstevns/dbmail/blob/8dc7ab5ec45a4321af191fecd7da1f50d76d3ce1/src/main.c#L80
======================================================================
----------------------------------------------------------------------
(0003432) paul (administrator) - 08-Apr-12 19:41
http://www.dbmail.org/mantis/view.php?id=966#c3432
----------------------------------------------------------------------
Whenever not checking a return value could lead to degraded behavior of
the program I would happily accept that as a bug. In either of the cases
you report however, no such degraded behavior is even remotely conceivable.
So either you are for real or you're just trolling. Either way, when you
submit a 'major' bug, at the very least at least describe the actual
problem.
----------------------------------------------------------------------
(0003433) elfring (reporter) - 08-Apr-12 20:17
http://www.dbmail.org/mantis/view.php?id=966#c3433
----------------------------------------------------------------------
I suggest to avoid unchecked function calls.
Would you like to detect every error situation as early as possible?
----------------------------------------------------------------------
(0003436) paul (administrator) - 09-Apr-12 12:35
http://www.dbmail.org/mantis/view.php?id=966#c3436
----------------------------------------------------------------------
I'm closing this as "won't fix" since the cases you report can not lead to
security problems, crashes or other forms of degraded behavior.
Issue History
Date Modified Username Field Change
======================================================================
08-Apr-12 19:10 elfring New Issue
08-Apr-12 19:13 elfring Issue Monitored: elfring
08-Apr-12 19:41 paul Note Added: 0003432
08-Apr-12 20:17 elfring Note Added: 0003433
09-Apr-12 12:35 paul Note Added: 0003436
09-Apr-12 12:35 paul Status new => closed
09-Apr-12 12:35 paul Resolution open => won't fix
======================================================================
_______________________________________________
Dbmail-dev mailing list
Dbmail-dev [at] dbmail
http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev
|
