Mailing List Archive: conserver: users

uds console FD leak

Index | Next | Previous | View Threaded

michael_heironimus at archwayconcepts

Apr 8, 2007, 12:53 PM

Post #1 of 2 (1354 views)
Permalink

uds console FD leak

I've been setting up conserver to provide console access and logging for
VMware machines running Linux, using the uds console type and a virtual
serial port. When the VM isn't running conserver uses another file
descriptor every time it tries to open the socket. If it's configured to
automatically reopen consoles that go down it eventually runs out of
file descriptors.

I added a few lines to consent.c to close the socket on failure and it
seems to work (patch against 8.1.15 attached). I'm not sure that this is
really the right way to handle it, but I haven't seen any problems in my
testing and the number of open file descriptors holds steady.

--
Michael Heironimus

Attachments:

conserver.udsclose.diff (0.73 KB)

bryan at conserver

Apr 9, 2007, 8:57 AM

Post #2 of 2 (1273 views)
Permalink

Re: uds console FD leak [In reply to]

On Sun, Apr 08, 2007 at 02:53:14PM -0500, Michael Heironimus wrote:
> When the VM isn't running conserver uses another file descriptor every
> time it tries to open the socket.

thanks for the patch! and thanks to this, i looked at the tcp code (for
'host' type consoles) and it too leaks file descriptors when failures
happen early on...so i've patched both cases. 8.1.16 will be available
in the very near future.

Bryan
_______________________________________________
users mailing list
users [at] conserver
https://www.conserver.com/mailman/listinfo/users

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads