Mailing List Archive: ClamAV: devel

clamav-milter v.0.92 vs. SIGUSR2

Index | Next | Previous | View Threaded

ew-reg at mailbox

Dec 20, 2007, 4:42 AM

Post #1 of 2 (1176 views)
Permalink

clamav-milter v.0.92 vs. SIGUSR2

Good morning,

I find something incomprehensible in clamav-milter.c code. When clamav-
milter daemon do the scanning work itself after getting the first
SIGUSR2 it installs a new signal handler, SIGHUP:

sigusr2(int sig)
{
signal(SIGUSR2, sighup);

logg("^SIGUSR2 caught: scheduling database reload\n");
reload++;
}

IMHO I don't see any reason to do that, shouldn't it be changed to:

signal(SIGUSR2, sigusr2);

Best regards,
Ernest Wypierowski
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

njh at bandsman

Dec 20, 2007, 5:02 AM

Post #2 of 2 (1039 views)
Permalink

Re: clamav-milter v.0.92 vs. SIGUSR2 [In reply to]

Ernest Wypierowski wrote:
> Good morning,
>
> I find something incomprehensible in clamav-milter.c code. When clamav-
> milter daemon do the scanning work itself after getting the first
> SIGUSR2 it installs a new signal handler, SIGHUP:

I noticed that too, 1 hour ago, and have already committed a fix to SVN.

-Nigel

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads