Mailing List Archive: ClamAV: devel

acinclude.m4 update, please

Index | Next | Previous | View Threaded

steve at lobefin

Jul 2, 2006, 4:23 AM

Post #1 of 3 (1650 views)
Permalink

acinclude.m4 update, please

Hello all,

So yesterday I was building Debian packages of the new version, and I
was updating the libtool version and so forth, and wondering why I have
more trouble doing so with clamav than other projects, so I finally took
a real look.

It turns out AC_PROG_LIBTOOL is AC_DEFUN'd in acinclude.m4, rather
than aclocal.m4. This prevents a run of aclocal from updating it to
a newer version. The best way to fix this is just to remove the 3,800
lines from acinclude.m4, and run aclocal again. I could send a patch,
but I'm not sure anyone here wants a patch approaching 4000 lines to go
the mailing list :)

If you want a patch mailed to you outside of the list, let me know - I'd
be happy to provide one.

Thanks,
--
--------------------------------------------------------------------------
| Stephen Gran | He that would govern others, first |
| steve [at] lobefin | should be the master of himself. |
| http://www.lobefin.net/~steve | |
--------------------------------------------------------------------------

Attachments:

signature.asc (0.18 KB)

rurban at x-ray

Mar 3, 2007, 2:06 PM

Post #2 of 3 (1332 views)
Permalink

Re: acinclude.m4 update, please [In reply to]

Stephen Gran schrieb:
> Hello all,
>
> So yesterday I was building Debian packages of the new version, and I
> was updating the libtool version and so forth, and wondering why I have
> more trouble doing so with clamav than other projects, so I finally took
> a real look.
>
> It turns out AC_PROG_LIBTOOL is AC_DEFUN'd in acinclude.m4, rather
> than aclocal.m4. This prevents a run of aclocal from updating it to
> a newer version. The best way to fix this is just to remove the 3,800
> lines from acinclude.m4, and run aclocal again. I could send a patch,
> but I'm not sure anyone here wants a patch approaching 4000 lines to go
> the mailing list :)
>
> If you want a patch mailed to you outside of the list, let me know - I'd
> be happy to provide one.

Thanks for having finally done this. This made the cygwin patch easier
and smaller.

Now only the borked d_ino logic is problematic.
The d_ino field is only wrong on certain cygwin builds from last year.
newer cygwin1.dll get that right, so no d_ino exclusion is necessary.
That's why I added a configure check if d_ino works ok or not. You just
assume that cygwin has no reliable d_ino which makes tree traversing in
cygwin slow.
The patch is in the cygwin src pkg.
--
Reini Urban - clamav cygwin maintainer
http://phpwiki.org/ http://murbreak.at/
http://helsinki.at/ http://spacemovie.mur.at/
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

rurban at x-ray

Jun 16, 2007, 10:39 AM

Post #3 of 3 (1197 views)
Permalink

Re: acinclude.m4 update, please [In reply to]

Reini Urban wrote at 03.03.2007 23:06:
> Now only the borked d_ino logic is problematic.
> The d_ino field is only wrong on certain cygwin builds from last year.
> newer cygwin1.dll get that right, so no d_ino exclusion is necessary.
> That's why I added a configure check if d_ino works ok or not. You just
> assume that cygwin has no reliable d_ino which makes tree traversing in
> cygwin slow.
> The patch is in the cygwin src pkg.

Your d_ino logic is still problematic, it got worse and it is inconsistent.

Now I attach the patch:

Attachments:

d_ino.patch (9.59 KB)

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads